From 42900e46c45e47e0406196559115ce9e7f2e3ec8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Arapiles?= <aarapiles@idealista.com>
Date: Thu, 26 May 2022 12:55:48 +0200
Subject: [PATCH] Improve README init scrips to avoid errors when create two
 roles on same path because already pipenv exists. Change travis.yml order of
 email notification as documentation explains. Add first line `---` to
 ansible-lint file because it's a yml. #92 Fix meta.yml lint warning from
 `galaxy-tags` to `galaxy_tags`.

---
 .travis.yml                                  | 6 +++---
 CHANGELOG.md                                 | 7 +++++++
 README.md                                    | 3 ++-
 {{cookiecutter.app_name}}_role/.ansible-lint | 1 +
 {{cookiecutter.app_name}}_role/meta/main.yml | 2 +-
 5 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index a709d07..7fe9692 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,8 +15,8 @@ script:
   - ./test.sh
 notifications:
   email:
-    if: branch = master
-    on_success: change
-    on_failure: always
     recipients:
       - desarrollo.benders@idealista.com
+      if: branch = master
+      on_success: change
+      on_failure: always
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9ccfdb9..764a454 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,13 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/) and [Keep a changelog](https://github.com/olivierlacan/keep-a-changelog).
 
 ## Unreleased
+### Changed
+- *Improve README init scrips to avoid errors when create two roles on same path because already pipenv exists.* @adrian-arapiles
+- *Change travis.yml order of email notification as documentation explains.* @adrian-arapiles
+- *Add first line `---` to ansible-lint file because it's a yml.* @adrian-arapiles 
+### Fixed
+- *[92](https://github.com/idealista/cookiecutter-ansible-role/issues/92) Fix meta.yml lint warning from `galaxy-tags` to `galaxy_tags`.* @adrian-arapiles
+
 ## [2.9.0](https://github.com/idealista/cookiecutter-ansible-role/tree/2.9.0)
 ### [Full Changelog](https://github.com/idealista/cookiecutter-ansible-role/compare/2.8.1...2.9.0)
 ### Changed
diff --git a/README.md b/README.md
index ac95f8f..3d81ecd 100644
--- a/README.md
+++ b/README.md
@@ -29,7 +29,8 @@ You just need to have [pipenv](https://github.com/pypa/pipenv) installed.
 
 ## Usage
 
-To generate your ansible role type ```printf "cookiecutter==1.7.2\nJinja2==2.11.2" > requirements.txt && pipenv install -r requirements.txt && pipenv run cookiecutter https://github.com/idealista/cookiecutter-ansible-role && rm Pipfile* requirements.txt```.
+To generate your ansible role type ```printf "cookiecutter==1.7.2\nJinja2==2.11.2" > requirements.txt && pipenv install -r requirements.txt && pipenv run cookiecutter https://github.com/idealista/cookiecutter-ansible-role && rm -rf Pipfile*
+requirements.txt && pipenv --rm```.
 
 Then, introduce some parameters needed for generating it. 
 
diff --git a/{{cookiecutter.app_name}}_role/.ansible-lint b/{{cookiecutter.app_name}}_role/.ansible-lint
index 59eca22..355eeac 100644
--- a/{{cookiecutter.app_name}}_role/.ansible-lint
+++ b/{{cookiecutter.app_name}}_role/.ansible-lint
@@ -1,3 +1,4 @@
+---
 exclude_paths:
   - ./molecule
   - ./.travis.yml
diff --git a/{{cookiecutter.app_name}}_role/meta/main.yml b/{{cookiecutter.app_name}}_role/meta/main.yml
index 2bc2c18..03785df 100644
--- a/{{cookiecutter.app_name}}_role/meta/main.yml
+++ b/{{cookiecutter.app_name}}_role/meta/main.yml
@@ -6,7 +6,7 @@ galaxy_info:
   description: {{ cookiecutter.app_name | replace('_',' ') | title }} Role
   min_ansible_version: {{ cookiecutter.min_ansible_version }}
   license: {{ cookiecutter.license }}
-  galaxy-tags:
+  galaxy_tags:
     - {{ cookiecutter.galaxy_tag_1 }}
     - {{ cookiecutter.galaxy_tag_2 }}
     - {{ cookiecutter.galaxy_tag_3 }}