From 316be5eac5b9935c054e922afd0d1d93bb4a6d7b Mon Sep 17 00:00:00 2001
From: James Brunton <jbrunton96@gmail.com>
Date: Mon, 8 Sep 2025 09:55:30 +0100
Subject: [PATCH] Fix types of onParameterChange methods (#4415)

# Description of Changes
Fix types of onParameterChange methods
---
 .../tools/addPassword/AddPasswordSettings.tsx |  2 +-
 .../ChangePermissionsSettings.tsx             |  2 +-
 .../tools/compress/CompressSettings.tsx       |  2 +-
 .../convert/ConvertFromEmailSettings.tsx      | 44 +++++++++----------
 .../convert/ConvertFromImageSettings.tsx      |  2 +-
 .../tools/convert/ConvertFromWebSettings.tsx  | 26 +++++------
 .../tools/convert/ConvertSettings.tsx         |  2 +-
 .../tools/convert/ConvertToImageSettings.tsx  |  2 +-
 .../tools/convert/ConvertToPdfaSettings.tsx   | 20 ++++-----
 .../tools/ocr/AdvancedOCRSettings.tsx         |  8 ++--
 .../src/components/tools/ocr/OCRSettings.tsx  |  2 +-
 .../removePassword/RemovePasswordSettings.tsx |  2 +-
 .../tools/sanitize/SanitizeSettings.tsx       |  2 +-
 .../components/tools/split/SplitSettings.tsx  |  6 +--
 14 files changed, 61 insertions(+), 61 deletions(-)

diff --git a/frontend/src/components/tools/addPassword/AddPasswordSettings.tsx b/frontend/src/components/tools/addPassword/AddPasswordSettings.tsx
index 36ef3ce01..beb8c432c 100644
--- a/frontend/src/components/tools/addPassword/AddPasswordSettings.tsx
+++ b/frontend/src/components/tools/addPassword/AddPasswordSettings.tsx
@@ -4,7 +4,7 @@ import { AddPasswordParameters } from "../../../hooks/tools/addPassword/useAddPa
 
 interface AddPasswordSettingsProps {
   parameters: AddPasswordParameters;
-  onParameterChange: (key: keyof AddPasswordParameters, value: any) => void;
+  onParameterChange: <K extends keyof AddPasswordParameters>(key: K, value: AddPasswordParameters[K]) => void;
   disabled?: boolean;
 }
 
diff --git a/frontend/src/components/tools/changePermissions/ChangePermissionsSettings.tsx b/frontend/src/components/tools/changePermissions/ChangePermissionsSettings.tsx
index 071e27cfd..06ac6ac69 100644
--- a/frontend/src/components/tools/changePermissions/ChangePermissionsSettings.tsx
+++ b/frontend/src/components/tools/changePermissions/ChangePermissionsSettings.tsx
@@ -4,7 +4,7 @@ import { ChangePermissionsParameters } from "../../../hooks/tools/changePermissi
 
 interface ChangePermissionsSettingsProps {
   parameters: ChangePermissionsParameters;
-  onParameterChange: (key: keyof ChangePermissionsParameters, value: boolean) => void;
+  onParameterChange: <K extends keyof ChangePermissionsParameters>(key: K, value: ChangePermissionsParameters[K]) => void;
   disabled?: boolean;
 }
 
diff --git a/frontend/src/components/tools/compress/CompressSettings.tsx b/frontend/src/components/tools/compress/CompressSettings.tsx
index 42d270abb..28035bfe3 100644
--- a/frontend/src/components/tools/compress/CompressSettings.tsx
+++ b/frontend/src/components/tools/compress/CompressSettings.tsx
@@ -5,7 +5,7 @@ import { CompressParameters } from "../../../hooks/tools/compress/useCompressPar
 
 interface CompressSettingsProps {
   parameters: CompressParameters;
-  onParameterChange: (key: keyof CompressParameters, value: any) => void;
+  onParameterChange: <K extends keyof CompressParameters>(key: K, value: CompressParameters[K]) => void;
   disabled?: boolean;
 }
 
diff --git a/frontend/src/components/tools/convert/ConvertFromEmailSettings.tsx b/frontend/src/components/tools/convert/ConvertFromEmailSettings.tsx
index 59fa824ee..943e0feed 100644
--- a/frontend/src/components/tools/convert/ConvertFromEmailSettings.tsx
+++ b/frontend/src/components/tools/convert/ConvertFromEmailSettings.tsx
@@ -5,40 +5,40 @@ import { ConvertParameters } from '../../../hooks/tools/convert/useConvertParame
 
 interface ConvertFromEmailSettingsProps {
   parameters: ConvertParameters;
-  onParameterChange: (key: keyof ConvertParameters, value: any) => void;
+  onParameterChange: <K extends keyof ConvertParameters>(key: K, value: ConvertParameters[K]) => void;
   disabled?: boolean;
 }
 
-const ConvertFromEmailSettings = ({ 
-  parameters, 
-  onParameterChange, 
-  disabled = false 
+const ConvertFromEmailSettings = ({
+  parameters,
+  onParameterChange,
+  disabled = false
 }: ConvertFromEmailSettingsProps) => {
   const { t } = useTranslation();
 
   return (
     <Stack gap="sm" data-testid="email-settings">
       <Text size="sm" fw={500}>{t("convert.emailOptions", "Email to PDF Options")}:</Text>
-      
+
       <Checkbox
         label={t("convert.includeAttachments", "Include email attachments")}
         checked={parameters.emailOptions.includeAttachments}
-        onChange={(event) => onParameterChange('emailOptions', { 
-          ...parameters.emailOptions, 
-          includeAttachments: event.currentTarget.checked 
+        onChange={(event) => onParameterChange('emailOptions', {
+          ...parameters.emailOptions,
+          includeAttachments: event.currentTarget.checked
         })}
         disabled={disabled}
         data-testid="include-attachments-checkbox"
       />
-      
+
       {parameters.emailOptions.includeAttachments && (
         <Stack gap="xs">
           <Text size="xs" fw={500}>{t("convert.maxAttachmentSize", "Maximum attachment size (MB)")}:</Text>
           <NumberInput
             value={parameters.emailOptions.maxAttachmentSizeMB}
-            onChange={(value) => onParameterChange('emailOptions', { 
-              ...parameters.emailOptions, 
-              maxAttachmentSizeMB: Number(value) || 10 
+            onChange={(value) => onParameterChange('emailOptions', {
+              ...parameters.emailOptions,
+              maxAttachmentSizeMB: Number(value) || 10
             })}
             min={1}
             max={100}
@@ -48,24 +48,24 @@ const ConvertFromEmailSettings = ({
           />
         </Stack>
       )}
-      
+
       <Checkbox
         label={t("convert.includeAllRecipients", "Include CC and BCC recipients in header")}
         checked={parameters.emailOptions.includeAllRecipients}
-        onChange={(event) => onParameterChange('emailOptions', { 
-          ...parameters.emailOptions, 
-          includeAllRecipients: event.currentTarget.checked 
+        onChange={(event) => onParameterChange('emailOptions', {
+          ...parameters.emailOptions,
+          includeAllRecipients: event.currentTarget.checked
         })}
         disabled={disabled}
         data-testid="include-all-recipients-checkbox"
       />
-      
+
       <Checkbox
         label={t("convert.downloadHtml", "Download HTML intermediate file instead of PDF")}
         checked={parameters.emailOptions.downloadHtml}
-        onChange={(event) => onParameterChange('emailOptions', { 
-          ...parameters.emailOptions, 
-          downloadHtml: event.currentTarget.checked 
+        onChange={(event) => onParameterChange('emailOptions', {
+          ...parameters.emailOptions,
+          downloadHtml: event.currentTarget.checked
         })}
         disabled={disabled}
         data-testid="download-html-checkbox"
@@ -74,4 +74,4 @@ const ConvertFromEmailSettings = ({
   );
 };
 
-export default ConvertFromEmailSettings;
\ No newline at end of file
+export default ConvertFromEmailSettings;
diff --git a/frontend/src/components/tools/convert/ConvertFromImageSettings.tsx b/frontend/src/components/tools/convert/ConvertFromImageSettings.tsx
index 0681821fd..eb0457f13 100644
--- a/frontend/src/components/tools/convert/ConvertFromImageSettings.tsx
+++ b/frontend/src/components/tools/convert/ConvertFromImageSettings.tsx
@@ -6,7 +6,7 @@ import { ConvertParameters } from "../../../hooks/tools/convert/useConvertParame
 
 interface ConvertFromImageSettingsProps {
   parameters: ConvertParameters;
-  onParameterChange: (key: keyof ConvertParameters, value: any) => void;
+  onParameterChange: <K extends keyof ConvertParameters>(key: K, value: ConvertParameters[K]) => void;
   disabled?: boolean;
 }
 
diff --git a/frontend/src/components/tools/convert/ConvertFromWebSettings.tsx b/frontend/src/components/tools/convert/ConvertFromWebSettings.tsx
index 270980f82..f6101d1c1 100644
--- a/frontend/src/components/tools/convert/ConvertFromWebSettings.tsx
+++ b/frontend/src/components/tools/convert/ConvertFromWebSettings.tsx
@@ -5,28 +5,28 @@ import { ConvertParameters } from '../../../hooks/tools/convert/useConvertParame
 
 interface ConvertFromWebSettingsProps {
   parameters: ConvertParameters;
-  onParameterChange: (key: keyof ConvertParameters, value: any) => void;
+  onParameterChange: <K extends keyof ConvertParameters>(key: K, value: ConvertParameters[K]) => void;
   disabled?: boolean;
 }
 
-const ConvertFromWebSettings = ({ 
-  parameters, 
-  onParameterChange, 
-  disabled = false 
+const ConvertFromWebSettings = ({
+  parameters,
+  onParameterChange,
+  disabled = false
 }: ConvertFromWebSettingsProps) => {
   const { t } = useTranslation();
 
   return (
     <Stack gap="sm" data-testid="web-settings">
       <Text size="sm" fw={500}>{t("convert.webOptions", "Web to PDF Options")}:</Text>
-      
+
       <Stack gap="xs">
         <Text size="xs" fw={500}>{t("convert.zoomLevel", "Zoom Level")}:</Text>
         <NumberInput
           value={parameters.htmlOptions.zoomLevel}
-          onChange={(value) => onParameterChange('htmlOptions', { 
-            ...parameters.htmlOptions, 
-            zoomLevel: Number(value) || 1.0 
+          onChange={(value) => onParameterChange('htmlOptions', {
+            ...parameters.htmlOptions,
+            zoomLevel: Number(value) || 1.0
           })}
           min={0.1}
           max={3.0}
@@ -36,9 +36,9 @@ const ConvertFromWebSettings = ({
         />
         <Slider
           value={parameters.htmlOptions.zoomLevel}
-          onChange={(value) => onParameterChange('htmlOptions', { 
-            ...parameters.htmlOptions, 
-            zoomLevel: value 
+          onChange={(value) => onParameterChange('htmlOptions', {
+            ...parameters.htmlOptions,
+            zoomLevel: value
           })}
           min={0.1}
           max={3.0}
@@ -51,4 +51,4 @@ const ConvertFromWebSettings = ({
   );
 };
 
-export default ConvertFromWebSettings;
\ No newline at end of file
+export default ConvertFromWebSettings;
diff --git a/frontend/src/components/tools/convert/ConvertSettings.tsx b/frontend/src/components/tools/convert/ConvertSettings.tsx
index 3a019f8da..2b1de9302 100644
--- a/frontend/src/components/tools/convert/ConvertSettings.tsx
+++ b/frontend/src/components/tools/convert/ConvertSettings.tsx
@@ -26,7 +26,7 @@ import { StirlingFile } from "../../../types/fileContext";
 
 interface ConvertSettingsProps {
   parameters: ConvertParameters;
-  onParameterChange: (key: keyof ConvertParameters, value: any) => void;
+  onParameterChange: <K extends keyof ConvertParameters>(key: K, value: ConvertParameters[K]) => void;
   getAvailableToExtensions: (fromExtension: string) => Array<{value: string, label: string, group: string}>;
   selectedFiles: StirlingFile[];
   disabled?: boolean;
diff --git a/frontend/src/components/tools/convert/ConvertToImageSettings.tsx b/frontend/src/components/tools/convert/ConvertToImageSettings.tsx
index 9d67bfbf6..887685501 100644
--- a/frontend/src/components/tools/convert/ConvertToImageSettings.tsx
+++ b/frontend/src/components/tools/convert/ConvertToImageSettings.tsx
@@ -6,7 +6,7 @@ import { ConvertParameters } from "../../../hooks/tools/convert/useConvertParame
 
 interface ConvertToImageSettingsProps {
   parameters: ConvertParameters;
-  onParameterChange: (key: keyof ConvertParameters, value: any) => void;
+  onParameterChange: <K extends keyof ConvertParameters>(key: K, value: ConvertParameters[K]) => void;
   disabled?: boolean;
 }
 
diff --git a/frontend/src/components/tools/convert/ConvertToPdfaSettings.tsx b/frontend/src/components/tools/convert/ConvertToPdfaSettings.tsx
index 49e057a1c..b9a572b8d 100644
--- a/frontend/src/components/tools/convert/ConvertToPdfaSettings.tsx
+++ b/frontend/src/components/tools/convert/ConvertToPdfaSettings.tsx
@@ -7,16 +7,16 @@ import { StirlingFile } from '../../../types/fileContext';
 
 interface ConvertToPdfaSettingsProps {
   parameters: ConvertParameters;
-  onParameterChange: (key: keyof ConvertParameters, value: any) => void;
+  onParameterChange: <K extends keyof ConvertParameters>(key: K, value: ConvertParameters[K]) => void;
   selectedFiles: StirlingFile[];
   disabled?: boolean;
 }
 
-const ConvertToPdfaSettings = ({ 
-  parameters, 
+const ConvertToPdfaSettings = ({
+  parameters,
   onParameterChange,
   selectedFiles,
-  disabled = false 
+  disabled = false
 }: ConvertToPdfaSettingsProps) => {
   const { t } = useTranslation();
   const { hasDigitalSignatures, isChecking } = usePdfSignatureDetection(selectedFiles);
@@ -29,7 +29,7 @@ const ConvertToPdfaSettings = ({
   return (
     <Stack gap="sm" data-testid="pdfa-settings">
       <Text size="sm" fw={500}>{t("convert.pdfaOptions", "PDF/A Options")}:</Text>
-      
+
       {hasDigitalSignatures && (
         <Alert color="yellow">
           <Text size="sm">
@@ -37,14 +37,14 @@ const ConvertToPdfaSettings = ({
           </Text>
         </Alert>
       )}
-      
+
       <Stack gap="xs">
         <Text size="xs" fw={500}>{t("convert.outputFormat", "Output Format")}:</Text>
         <Select
           value={parameters.pdfaOptions.outputFormat}
-          onChange={(value) => onParameterChange('pdfaOptions', { 
-            ...parameters.pdfaOptions, 
-            outputFormat: value || 'pdfa-1' 
+          onChange={(value) => onParameterChange('pdfaOptions', {
+            ...parameters.pdfaOptions,
+            outputFormat: value || 'pdfa-1'
           })}
           data={pdfaFormatOptions}
           disabled={disabled || isChecking}
@@ -58,4 +58,4 @@ const ConvertToPdfaSettings = ({
   );
 };
 
-export default ConvertToPdfaSettings;
\ No newline at end of file
+export default ConvertToPdfaSettings;
diff --git a/frontend/src/components/tools/ocr/AdvancedOCRSettings.tsx b/frontend/src/components/tools/ocr/AdvancedOCRSettings.tsx
index a38926edf..a6965bb09 100644
--- a/frontend/src/components/tools/ocr/AdvancedOCRSettings.tsx
+++ b/frontend/src/components/tools/ocr/AdvancedOCRSettings.tsx
@@ -16,7 +16,7 @@ interface AdvancedOption {
 interface AdvancedOCRSettingsProps {
   advancedOptions: string[];
   ocrRenderType?: string;
-  onParameterChange: (key: keyof OCRParameters, value: any) => void;
+  onParameterChange: <K extends keyof OCRParameters>(key: K, value: OCRParameters[K]) => void;
   disabled?: boolean;
 }
 
@@ -40,7 +40,7 @@ const AdvancedOCRSettings: React.FC<AdvancedOCRSettingsProps> = ({
   // Handle individual checkbox changes
   const handleCheckboxChange = (optionValue: string, checked: boolean) => {
     const option = advancedOptionsData.find(opt => opt.value === optionValue);
-    
+
     if (option?.isSpecial) {
       // Handle special options (like compatibility mode) differently
       if (optionValue === 'compatibilityMode') {
@@ -69,7 +69,7 @@ const AdvancedOCRSettings: React.FC<AdvancedOCRSettingsProps> = ({
         <Text size="sm" fw={500} mb="md">
           {t('ocr.settings.advancedOptions.label', 'Processing Options')}
         </Text>
-        
+
         <Stack gap="sm">
           {advancedOptionsData.map((option) => (
             <Checkbox
@@ -87,4 +87,4 @@ const AdvancedOCRSettings: React.FC<AdvancedOCRSettingsProps> = ({
   );
 };
 
-export default AdvancedOCRSettings; 
\ No newline at end of file
+export default AdvancedOCRSettings;
diff --git a/frontend/src/components/tools/ocr/OCRSettings.tsx b/frontend/src/components/tools/ocr/OCRSettings.tsx
index 6009888b9..959601166 100644
--- a/frontend/src/components/tools/ocr/OCRSettings.tsx
+++ b/frontend/src/components/tools/ocr/OCRSettings.tsx
@@ -6,7 +6,7 @@ import { OCRParameters } from '../../../hooks/tools/ocr/useOCRParameters';
 
 interface OCRSettingsProps {
   parameters: OCRParameters;
-  onParameterChange: (key: keyof OCRParameters, value: any) => void;
+  onParameterChange: <K extends keyof OCRParameters>(key: K, value: OCRParameters[K]) => void;
   disabled?: boolean;
 }
 
diff --git a/frontend/src/components/tools/removePassword/RemovePasswordSettings.tsx b/frontend/src/components/tools/removePassword/RemovePasswordSettings.tsx
index 5e1493036..cd97dbd96 100644
--- a/frontend/src/components/tools/removePassword/RemovePasswordSettings.tsx
+++ b/frontend/src/components/tools/removePassword/RemovePasswordSettings.tsx
@@ -4,7 +4,7 @@ import { RemovePasswordParameters } from "../../../hooks/tools/removePassword/us
 
 interface RemovePasswordSettingsProps {
   parameters: RemovePasswordParameters;
-  onParameterChange: (key: keyof RemovePasswordParameters, value: string) => void;
+  onParameterChange: <K extends keyof RemovePasswordParameters>(key: K, value: RemovePasswordParameters[K]) => void;
   disabled?: boolean;
 }
 
diff --git a/frontend/src/components/tools/sanitize/SanitizeSettings.tsx b/frontend/src/components/tools/sanitize/SanitizeSettings.tsx
index fb5304431..21ef7c0aa 100644
--- a/frontend/src/components/tools/sanitize/SanitizeSettings.tsx
+++ b/frontend/src/components/tools/sanitize/SanitizeSettings.tsx
@@ -4,7 +4,7 @@ import { SanitizeParameters, defaultParameters } from "../../../hooks/tools/sani
 
 interface SanitizeSettingsProps {
   parameters: SanitizeParameters;
-  onParameterChange: (key: keyof SanitizeParameters, value: boolean) => void;
+  onParameterChange: <K extends keyof SanitizeParameters>(key: K, value: SanitizeParameters[K]) => void;
   disabled?: boolean;
 }
 
diff --git a/frontend/src/components/tools/split/SplitSettings.tsx b/frontend/src/components/tools/split/SplitSettings.tsx
index 2cf988f6d..936b5a09f 100644
--- a/frontend/src/components/tools/split/SplitSettings.tsx
+++ b/frontend/src/components/tools/split/SplitSettings.tsx
@@ -1,11 +1,11 @@
 import { Stack, TextInput, Select, Checkbox } from '@mantine/core';
 import { useTranslation } from 'react-i18next';
-import { isSplitMode, SPLIT_MODES, SPLIT_TYPES } from '../../../constants/splitConstants';
+import { isSplitMode, isSplitType, SPLIT_MODES, SPLIT_TYPES } from '../../../constants/splitConstants';
 import { SplitParameters } from '../../../hooks/tools/split/useSplitParameters';
 
 export interface SplitSettingsProps {
   parameters: SplitParameters;
-  onParameterChange: (parameter: keyof SplitParameters, value: string | boolean) => void;
+  onParameterChange: <K extends keyof SplitParameters>(key: K, value: SplitParameters[K]) => void;
   disabled?: boolean;
 }
 
@@ -62,7 +62,7 @@ const SplitSettings = ({
       <Select
         label={t("split-by-size-or-count.type.label", "Split Type")}
         value={parameters.splitType}
-        onChange={(v) => v && onParameterChange('splitType', v)}
+        onChange={(v) => isSplitType(v) && onParameterChange('splitType', v)}
         disabled={disabled}
         data={[
           { value: SPLIT_TYPES.SIZE, label: t("split-by-size-or-count.type.size", "By Size") },