refactor: bookmark editor data loader

- split previous function into two steps
  - fetch data from API and return JSON as a callback
  - handle UI updates and check/process JSON data
- move error message out of bookmarks container for easier resetting

app/core/src/main/resources/static/js/pages/edit-table-of-contents.js

@@ -1,25 +1,19 @@
 document.addEventListener("DOMContentLoaded", function () {
   const bookmarksContainer = document.getElementById("bookmarks-container");
+  const errorMessageContainer = document.getElementById("error-message-container");
   const addBookmarkBtn = document.getElementById("addBookmarkBtn");
   const bookmarkDataInput = document.getElementById("bookmarkData");
   let bookmarks = [];
   let counter = 0; // Used for generating unique IDs
 
-  // Add event listener to the file input to extract existing bookmarks
+  // callback function on file input change to extract bookmarks from PDF
-  document.getElementById("fileInput-input").addEventListener("change", async function (e) {
+  async function getBookmarkDataFromPdf(event) {
-    if (!e.target.files || e.target.files.length === 0) {
+    if (!event.target.files || event.target.files.length === 0) {
       return;
     }
 
-    // Reset bookmarks initially
-    bookmarks = [];
-    updateBookmarksUI();
-
     const formData = new FormData();
-    formData.append("file", e.target.files[0]);
+    formData.append("file", event.target.files[0]);
-
-    // Show loading indicator
-    showLoadingIndicator();
 
     try {
       // Call the API to extract bookmarks using fetchWithCsrf for CSRF protection
@@ -29,32 +23,49 @@ document.addEventListener("DOMContentLoaded", function () {
       });
 
       if (!response.ok) {
-        throw new Error(`Failed to extract bookmarks: ${response.status} ${response.statusText}`);
+        throw new Error(`Failed to fetch API: ${response.status} ${response.statusText}`);
       }
 
       const extractedBookmarks = await response.json();
+      return extractedBookmarks;
+    } catch (error) {
+      throw new Error("Error extracting bookmark data:", error);
+    }
+  }
+
+  // display new bookmark data given by a callback function that loads or fetches the data
+  async function loadBookmarks(getBookmarkDataCallback) {
+    // reset bookmarks
+    bookmarks = [];
+    updateBookmarksUI();
+    showLoadingIndicator();
+
+    try {
+      // Get new bookmarks from the callback
+      const newBookmarks = await getBookmarkDataCallback();
 
       // Convert extracted bookmarks to our format with IDs
-      if (extractedBookmarks && extractedBookmarks.length > 0) {
+      if (newBookmarks && newBookmarks.length > 0) {
-        bookmarks = extractedBookmarks.map(convertExtractedBookmark);
+        bookmarks = newBookmarks.map(convertExtractedBookmark);
-      } else {
-        showEmptyState();
       }
     } catch (error) {
-      // Show error message
+      bookmarks = [];
-      showErrorMessage("Failed to extract bookmarks. You can still create new ones.");
+      throw new Error(`Error loading bookmarks: ${error}`);
-
-      // Add a default bookmark if no bookmarks and error
-      if (bookmarks.length === 0) {
-        showEmptyState();
-      }
     } finally {
-      // Remove loading indicator
       removeLoadingIndicator();
-
-      // Update the UI
       updateBookmarksUI();
     }
+  }
+
+  // Add event listener to the file input to extract existing bookmarks
+  document.getElementById("fileInput-input").addEventListener("change", async function (event) {
+    try {
+      await loadBookmarks(async function () {
+        return getBookmarkDataFromPdf(event);
+      });
+    } catch {
+      showErrorMessage("Failed to extract bookmarks. You can still create new ones.");
+    }
   });
 
   function showLoadingIndicator() {
@@ -62,6 +73,7 @@ document.addEventListener("DOMContentLoaded", function () {
     loadingEl.className = "alert alert-info";
     loadingEl.textContent = "Loading bookmarks from PDF...";
     loadingEl.id = "loading-bookmarks";
+    errorMessageContainer.innerHTML = "";
     bookmarksContainer.innerHTML = "";
     bookmarksContainer.appendChild(loadingEl);
   }
@@ -77,7 +89,7 @@ document.addEventListener("DOMContentLoaded", function () {
     const errorEl = document.createElement("div");
     errorEl.className = "alert alert-danger";
     errorEl.textContent = message;
-    bookmarksContainer.appendChild(errorEl);
+    errorMessageContainer.appendChild(errorEl);
   }
 
   function showEmptyState() {

app/core/src/main/resources/templates/edit-table-of-contents.html

@@ -51,6 +51,10 @@
                   <h5 th:text="#{editTableOfContents.editorTitle}"></h5>
                   <p th:text="#{editTableOfContents.editorDesc}"></p>
 
+                  <div id="error-message-container">
+                    <!-- Error messages will be added here dynamically -->
+                  </div>
+
                   <div id="bookmarks-container">
                     <!-- Bookmarks will be added here dynamically -->
                   </div>