From 427b44be69681ed5567762aa8904c7cd157dec51 Mon Sep 17 00:00:00 2001 From: Anthony Stirling <77850077+Frooodle@users.noreply.github.com> Date: Thu, 2 Oct 2025 17:47:17 +0100 Subject: [PATCH] fix: Add v2-announcement tags for Docker builds on v1.3.2_V2Announcement branch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove blocking condition `if: github.ref != 'refs/heads/main'` from regular and ultra-lite builds - Add v2-announcement tag to regular Dockerfile for branch testing - Add v2-announcement-ultra-lite tag to ultra-lite Dockerfile - Add test repo to image targets for all variants - Fixes "tag is needed when pushing to registry" error 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- .github/workflows/push-docker.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/push-docker.yml b/.github/workflows/push-docker.yml index 9936bf652..ecdebd633 100644 --- a/.github/workflows/push-docker.yml +++ b/.github/workflows/push-docker.yml @@ -90,21 +90,21 @@ jobs: - name: Generate tags id: meta uses: docker/metadata-action@c1e51972afc2121e065aed6d45c65596fe445f3f # v5.8.0 - if: github.ref != 'refs/heads/main' with: images: | ${{ secrets.DOCKER_HUB_USERNAME }}/s-pdf ghcr.io/${{ steps.repoowner.outputs.lowercase }}/s-pdf ghcr.io/${{ steps.repoowner.outputs.lowercase }}/stirling-pdf ${{ secrets.DOCKER_HUB_ORG_USERNAME }}/stirling-pdf + ${{ secrets.DOCKER_HUB_USERNAME }}/test tags: | type=raw,value=${{ steps.versionNumber.outputs.versionNumber }},enable=${{ github.ref == 'refs/heads/master' }} type=raw,value=latest,enable=${{ github.ref == 'refs/heads/master' }} + type=raw,value=v2-announcement,enable=${{ github.ref == 'refs/heads/v1.3.2_V2Announcement' }} - name: Build and push main Dockerfile id: build-push-regular uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6.18.0 - if: github.ref != 'refs/heads/main' with: builder: ${{ steps.buildx.outputs.name }} context: . @@ -143,9 +143,11 @@ jobs: ghcr.io/${{ steps.repoowner.outputs.lowercase }}/s-pdf ghcr.io/${{ steps.repoowner.outputs.lowercase }}/stirling-pdf ${{ secrets.DOCKER_HUB_ORG_USERNAME }}/stirling-pdf + ${{ secrets.DOCKER_HUB_USERNAME }}/test tags: | type=raw,value=${{ steps.versionNumber.outputs.versionNumber }}-ultra-lite,enable=${{ github.ref == 'refs/heads/master' }} type=raw,value=latest-ultra-lite,enable=${{ github.ref == 'refs/heads/master' }} + type=raw,value=v2-announcement-ultra-lite,enable=${{ github.ref == 'refs/heads/v1.3.2_V2Announcement' }} - name: Build and push Dockerfile-ultra-lite id: build-push-lite