Mirrors/Stirling-PDF
Mirrors/Stirling-PDF
1
0
Fork 0
mirror of https://github.com/Frooodle/Stirling-PDF.git synced 2025-09-08 17:51:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Enable ESLint no-empty rule (#4342)

Browse Source 
# Description of Changes
Enable ESLint [no-empty
rule](https://eslint.org/docs/latest/rules/no-empty)
This commit is contained in:
James Brunton 2025-09-04 15:59:31 +01:00 committed by GitHub
parent 295e682e03
commit 6d3b08d9b6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
frontend/eslint.config.mjs
View File

@ -15,7 +15,6 @@ export default defineConfig(
}, },
{ {
rules: { rules: {
"no-empty": "off", // Temporarily disabled until codebase conformant
"no-empty-pattern": "off", // Temporarily disabled until codebase conformant "no-empty-pattern": "off", // Temporarily disabled until codebase conformant
"no-undef": "off", // Temporarily disabled until codebase conformant "no-undef": "off", // Temporarily disabled until codebase conformant
"no-useless-escape": "off", // Temporarily disabled until codebase conformant "no-useless-escape": "off", // Temporarily disabled until codebase conformant

4
frontend/src/components/shared/fitText/textFit.ts
View File

@ -82,8 +82,8 @@ export function adjustFontSizeToFit(
return () => { return () => {
cancelAnimationFrame(raf); cancelAnimationFrame(raf);
try { ro.disconnect(); } catch {} try { ro.disconnect(); } catch { /* Ignore errors */ }
try { mo.disconnect(); } catch {} try { mo.disconnect(); } catch { /* Ignore errors */ }
}; };
} }

12
frontend/src/services/pdfWorkerManager.ts
View File

@ -1,6 +1,6 @@
/** /**
* PDF.js Worker Manager - Centralized worker lifecycle management * PDF.js Worker Manager - Centralized worker lifecycle management
* *
* Prevents infinite worker creation by managing PDF.js workers globally * Prevents infinite worker creation by managing PDF.js workers globally
* and ensuring proper cleanup when operations complete. * and ensuring proper cleanup when operations complete.
*/ */
@ -86,7 +86,7 @@ class PDFWorkerManager {
const pdf = await loadingTask.promise; const pdf = await loadingTask.promise;
this.activeDocuments.add(pdf); this.activeDocuments.add(pdf);
this.workerCount++; this.workerCount++;
return pdf; return pdf;
} catch (error) { } catch (error) {
// If document creation fails, make sure to clean up the loading task // If document creation fails, make sure to clean up the loading task
@ -94,6 +94,7 @@ class PDFWorkerManager {
try { try {
loadingTask.destroy(); loadingTask.destroy();
} catch (destroyError) { } catch (destroyError) {
// Ignore errors
} }
} }
throw error; throw error;
@ -125,7 +126,7 @@ class PDFWorkerManager {
documentsToDestroy.forEach(pdf => { documentsToDestroy.forEach(pdf => {
this.destroyDocument(pdf); this.destroyDocument(pdf);
}); });
this.activeDocuments.clear(); this.activeDocuments.clear();
this.workerCount = 0; this.workerCount = 0;
} }
@ -166,9 +167,10 @@ class PDFWorkerManager {
try { try {
pdf.destroy(); pdf.destroy();
} catch (error) { } catch (error) {
// Ignore errors
} }
}); });
this.activeDocuments.clear(); this.activeDocuments.clear();
this.workerCount = 0; this.workerCount = 0;
} }
@ -182,4 +184,4 @@ class PDFWorkerManager {
} }
// Export singleton instance // Export singleton instance
export const pdfWorkerManager = PDFWorkerManager.getInstance(); export const pdfWorkerManager = PDFWorkerManager.getInstance();