From 915a33bbc23fa1c8142c3be1bf1c9f3934a0d9cb Mon Sep 17 00:00:00 2001 From: Ludy Date: Mon, 29 Dec 2025 11:33:57 +0100 Subject: [PATCH] fix(ci): correct pip --require-hashes usage in TOML check workflow (#5336) # Description of Changes This pull request updates the Python dependency installation step in the `.github/workflows/check_toml.yml` workflow. Instead of installing a single dependency directly, it now installs all dependencies listed in a requirements file, which helps centralize and manage dependencies more effectively. Dependency management improvements: * Changed the Python dependency installation to use the `requirements_sync_readme.txt` file, allowing for easier updates and consistent dependency management. (.github/workflows/check_toml.yml) --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. --- .github/workflows/check_toml.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/check_toml.yml b/.github/workflows/check_toml.yml index afb70e0c9..dd5a28ac3 100644 --- a/.github/workflows/check_toml.yml +++ b/.github/workflows/check_toml.yml @@ -199,8 +199,7 @@ jobs: python-version: "3.12" - name: Install Python dependencies - run: | - pip install --require-hashes tomli-w==1.2.0 --hash sha256:188306098d013b691fcadc011abd66727d3c414c571bb01b1a174ba8c983cf90 + run: pip install --require-hashes -r ./.github/scripts/requirements_sync_readme.txt - name: Run Python script to check files id: run-check