Mirrors/Stirling-PDF
Mirrors/Stirling-PDF
1
0
Fork 0
mirror of https://github.com/Frooodle/Stirling-PDF.git synced 2025-09-26 17:52:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix parameter type definitions and metadata validation

Browse Source 
Updated parameter types in AutomationOperation and AutomationTool to allow undefined values. Fixed logic in useChangeMetadataParameters to use logical OR instead of nullish coalescing for metadata validation.
This commit is contained in:
Ludy87 2025-09-25 10:05:49 +02:00
parent c3b604791a
commit 966d80b0fc
No known key found for this signature in database
GPG Key ID: 92696155E0220F94
2 changed files with 6 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/src/hooks/tools/changeMetadata/useChangeMetadataParameters.ts
View File

@ -89,6 +89,7 @@ const validateParameters = (params: ChangeMetadataParameters): boolean => {
} }
// At least one field should have content for the operation to be meaningful // At least one field should have content for the operation to be meaningful
/* eslint-disable @typescript-eslint/prefer-nullish-coalescing */
const hasStandardMetadata = !!( const hasStandardMetadata = !!(
params.title.trim() params.title.trim()
|| params.author.trim() || params.author.trim()
@ -97,8 +98,8 @@ const validateParameters = (params: ChangeMetadataParameters): boolean => {
|| params.creator.trim() || params.creator.trim()
|| params.producer.trim() || params.producer.trim()
|| params.creationDate || params.creationDate
?? params.modificationDate || params.modificationDate
?? params.trapped !== TrappedStatus.UNKNOWN || params.trapped !== TrappedStatus.UNKNOWN
); );
const hasCustomMetadata = params.customMetadata.some( const hasCustomMetadata = params.customMetadata.some(

36
frontend/src/types/automation.ts
View File

@ -4,7 +4,7 @@
export interface AutomationOperation { export interface AutomationOperation {
operation: string; operation: string;
parameters: Record<string, JsonValue>; parameters: Record<string, JsonValue | undefined>;
} }
export interface AutomationConfig { export interface AutomationConfig {
@ -22,7 +22,7 @@ export interface AutomationTool {
operation: string; operation: string;
name: string; name: string;
configured: boolean; configured: boolean;
parameters?: Record<string, JsonValue>; parameters?: Record<string, JsonValue | undefined>;
} }
export type AutomationStep = typeof import('../constants/automation').AUTOMATION_STEPS[keyof typeof import('../constants/automation').AUTOMATION_STEPS]; export type AutomationStep = typeof import('../constants/automation').AUTOMATION_STEPS[keyof typeof import('../constants/automation').AUTOMATION_STEPS];
@ -82,34 +82,4 @@ export type JsonValue =
| JsonValue[] | JsonValue[]
| { [key: string]: JsonValue }; | { [key: string]: JsonValue };
export type JsonObject = Record<string, JsonValue>; export type JsonObject = { [key: string]: JsonValue };
export interface AutomationOperation {
operation: string;
// Wurde von Record<string, string | number | boolean | null> auf JSON erweitert
parameters: Record<string, JsonValue>;
}
export interface AutomationConfig {
id: string;
name: string;
description?: string;
icon?: string;
operations: AutomationOperation[];
createdAt: string;
updatedAt: string;
}
export interface AutomationStepData {
step: AutomationStep;
mode?: AutomationMode;
automation?: AutomationConfig;
}
export interface ExecutionStep {
id: string;
operation: string;
name: string;
status: 'pending' | 'running' | 'completed' | 'error';
error?: string;
}