Mirrors/Stirling-PDF
Mirrors/Stirling-PDF
1
0
Fork 0
mirror of https://github.com/Frooodle/Stirling-PDF.git synced 2025-11-16 01:21:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

size race condition fix

Browse Source
This commit is contained in:
Anthony Stirling 2025-11-10 08:57:52 +00:00
parent b4e33002b6
commit a7f17947df
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/common/src/main/java/stirling/software/common/service/CustomPDFDocumentFactory.java
View File

@ -41,7 +41,7 @@ public class CustomPDFDocumentFactory {
// Memory thresholds and limits // Memory thresholds and limits
private static final long SMALL_FILE_THRESHOLD = 10 * 1024 * 1024; // 10 MB public static final long SMALL_FILE_THRESHOLD = 10 * 1024 * 1024; // 10 MB
// Files smaller than this threshold are loaded entirely in memory for better performance. // Files smaller than this threshold are loaded entirely in memory for better performance.
// These files use IOUtils.createMemoryOnlyStreamCache() which keeps all document data in RAM. // These files use IOUtils.createMemoryOnlyStreamCache() which keeps all document data in RAM.
// No temp files are created for document data, reducing I/O operations but consuming more // No temp files are created for document data, reducing I/O operations but consuming more

7
app/proprietary/src/main/java/stirling/software/SPDF/service/PdfJsonConversionService.java
View File

@ -309,6 +309,13 @@ public class PdfJsonConversionService {
byte[] cachedPdfBytes = null; byte[] cachedPdfBytes = null;
// Pre-read file bytes before loading PDDocument, since loading may delete the file
// (small files get loaded into memory and original is deleted)
// This is needed for lazy image caching where we need the bytes later
if (Files.size(workingPath) <= CustomPDFDocumentFactory.SMALL_FILE_THRESHOLD) {
cachedPdfBytes = Files.readAllBytes(workingPath);
}
try (PDDocument document = pdfDocumentFactory.load(workingPath, true)) { try (PDDocument document = pdfDocumentFactory.load(workingPath, true)) {
int totalPages = document.getNumberOfPages(); int totalPages = document.getNumberOfPages();
// Only use lazy images for real async jobs where client can access the cache // Only use lazy images for real async jobs where client can access the cache