Enforce type checking in CI (#4126)

# Description of Changes
Currently, the `tsconfig.json` file enforces strict type checking, but
nothing in CI checks that the code is actually correctly typed. [Vite
only transpiles TypeScript
code](https://vite.dev/guide/features.html#transpile-only) so doesn't
ensure that the TS code we're running is correct.

This PR adds running of the type checker to CI and fixes the type errors
that have already crept into the codebase.

Note that many of the changes I've made to 'fix the types' are just
using `any` to disable the type checker because the code is under too
much churn to fix anything properly at the moment. I still think
enabling the type checker now is the best course of action though
because otherwise we'll never be able to fix all of them, and it should
at least help us not break things when adding new code.

Co-authored-by: James <james@crosscourtanalytics.com>

frontend/src/utils/fileUtils.ts

@@ -49,12 +49,16 @@ export function createEnhancedFileFromStored(storedFile: StoredFile, thumbnail?:
     size: storedFile.size,
     type: storedFile.type,
     lastModified: storedFile.lastModified,
+    webkitRelativePath: '',
     // Lazy-loading File interface methods
     arrayBuffer: async () => {
       const data = await fileStorage.getFileData(storedFile.id);
       if (!data) throw new Error(`File ${storedFile.name} not found in IndexedDB - may have been purged`);
       return data;
     },
+    bytes: async () => {
+      return new Uint8Array();
+    },
     slice: (start?: number, end?: number, contentType?: string) => {
       // Return a promise-based slice that loads from IndexedDB
       return new Blob([], { type: contentType || storedFile.type });
@@ -66,9 +70,9 @@ export function createEnhancedFileFromStored(storedFile: StoredFile, thumbnail?:
       const data = await fileStorage.getFileData(storedFile.id);
       if (!data) throw new Error(`File ${storedFile.name} not found in IndexedDB - may have been purged`);
       return new TextDecoder().decode(data);
-    }
+    },
   } as FileWithUrl;
-  
+
   return enhancedFile;
 }
 
@@ -79,28 +83,28 @@ export async function loadFilesFromIndexedDB(): Promise<FileWithUrl[]> {
   try {
     await fileStorage.init();
     const storedFiles = await fileStorage.getAllFileMetadata();
-    
+
     if (storedFiles.length === 0) {
       return [];
     }
-    
+
     const restoredFiles: FileWithUrl[] = storedFiles
       .filter(storedFile => {
         // Filter out corrupted entries
-        return storedFile && 
-               storedFile.name && 
+        return storedFile &&
+               storedFile.name &&
                typeof storedFile.size === 'number';
       })
       .map(storedFile => {
         try {
-          return createEnhancedFileFromStored(storedFile);
+          return createEnhancedFileFromStored(storedFile as any);
         } catch (error) {
           console.error('Failed to restore file:', storedFile?.name || 'unknown', error);
           return null;
         }
       })
       .filter((file): file is FileWithUrl => file !== null);
-      
+
     return restoredFiles;
   } catch (error) {
     console.error('Failed to load files from IndexedDB:', error);
@@ -134,17 +138,17 @@ export function shouldUseDirectIndexedDBAccess(file: FileWithUrl): boolean {
  */
 export function detectFileExtension(filename: string): string {
   if (!filename || typeof filename !== 'string') return '';
-  
+
   const parts = filename.split('.');
   // If there's no extension (no dots or only one part), return empty string
   if (parts.length <= 1) return '';
-  
+
   // Get the last part (extension) in lowercase
   let extension = parts[parts.length - 1].toLowerCase();
-  
+
   // Normalize common extension variants
   if (extension === 'jpeg') extension = 'jpg';
-  
+
   return extension;
 }
 
@@ -155,10 +159,10 @@ export function detectFileExtension(filename: string): string {
  */
 export function getFilenameWithoutExtension(filename: string): string {
   if (!filename || typeof filename !== 'string') return '';
-  
+
   const parts = filename.split('.');
   if (parts.length <= 1) return filename;
-  
+
   // Return all parts except the last one (extension)
   return parts.slice(0, -1).join('.');
 }
@@ -172,4 +176,4 @@ export function getFilenameWithoutExtension(filename: string): string {
 export function changeFileExtension(filename: string, newExtension: string): string {
   const nameWithoutExt = getFilenameWithoutExtension(filename);
   return `${nameWithoutExt}.${newExtension}`;
-}
+}

frontend/src/utils/thumbnailUtils.ts

@@ -6,9 +6,9 @@ import { getDocument } from "pdfjs-dist";
  */
 export function calculateScaleFromFileSize(fileSize: number): number {
   const MB = 1024 * 1024;
-  
+
   if (fileSize < 1 * MB) return 0.6;      // < 1MB: High quality
-  if (fileSize < 5 * MB) return 0.4;      // 1-5MB: Medium-high quality  
+  if (fileSize < 5 * MB) return 0.4;      // 1-5MB: Medium-high quality
   if (fileSize < 15 * MB) return 0.3;     // 5-15MB: Medium quality
   if (fileSize < 30 * MB) return 0.2;     // 15-30MB: Low-medium quality
   return 0.15;                            // 30MB+: Low quality
@@ -182,43 +182,41 @@ export async function generateThumbnailForFile(file: File): Promise<string | und
     console.log('File is not a PDF or image, generating placeholder:', file.name);
     return generatePlaceholderThumbnail(file);
   }
-  
+
+  // Calculate quality scale based on file size
+  console.log('Generating thumbnail for', file.name);
+  const scale = calculateScaleFromFileSize(file.size);
+  console.log(`Using scale ${scale} for ${file.name} (${(file.size / 1024 / 1024).toFixed(1)}MB)`);
   try {
-    console.log('Generating thumbnail for', file.name);
-    
-    // Calculate quality scale based on file size
-    const scale = calculateScaleFromFileSize(file.size);
-    console.log(`Using scale ${scale} for ${file.name} (${(file.size / 1024 / 1024).toFixed(1)}MB)`);
-    
     // Only read first 2MB for thumbnail generation to save memory
     const chunkSize = 2 * 1024 * 1024; // 2MB
     const chunk = file.slice(0, Math.min(chunkSize, file.size));
     const arrayBuffer = await chunk.arrayBuffer();
-    
-    const pdf = await getDocument({ 
+
+    const pdf = await getDocument({
       data: arrayBuffer,
       disableAutoFetch: true,
       disableStream: true
     }).promise;
-    
+
     const page = await pdf.getPage(1);
     const viewport = page.getViewport({ scale }); // Dynamic scale based on file size
     const canvas = document.createElement("canvas");
     canvas.width = viewport.width;
     canvas.height = viewport.height;
     const context = canvas.getContext("2d");
-    
+
     if (!context) {
       throw new Error('Could not get canvas context');
     }
-    
+
     await page.render({ canvasContext: context, viewport }).promise;
     const thumbnail = canvas.toDataURL();
-    
+
     // Immediately clean up memory after thumbnail generation
     pdf.destroy();
     console.log('Thumbnail generated and PDF destroyed for', file.name);
-    
+
     return thumbnail;
   } catch (error) {
     if (error instanceof Error) {
@@ -227,27 +225,27 @@ export async function generateThumbnailForFile(file: File): Promise<string | und
         // Return a placeholder or try with full file instead of chunk
         try {
           const fullArrayBuffer = await file.arrayBuffer();
-          const pdf = await getDocument({ 
+          const pdf = await getDocument({
             data: fullArrayBuffer,
             disableAutoFetch: true,
             disableStream: true,
             verbosity: 0 // Reduce PDF.js warnings
           }).promise;
-          
+
           const page = await pdf.getPage(1);
           const viewport = page.getViewport({ scale });
           const canvas = document.createElement("canvas");
           canvas.width = viewport.width;
           canvas.height = viewport.height;
           const context = canvas.getContext("2d");
-          
+
           if (!context) {
             throw new Error('Could not get canvas context');
           }
-          
+
           await page.render({ canvasContext: context, viewport }).promise;
           const thumbnail = canvas.toDataURL();
-          
+
           pdf.destroy();
           return thumbnail;
         } catch (fallbackError) {
@@ -262,4 +260,4 @@ export async function generateThumbnailForFile(file: File): Promise<string | und
     console.warn('Unknown error generating thumbnail for', file.name, error);
     return undefined;
   }
-}
+}

frontend/src/utils/toolOperationTracker.ts

@@ -22,7 +22,7 @@ export const createOperation = <TParams = void>(
       parameters: params,
       fileSize: selectedFiles.reduce((sum, f) => sum + f.size, 0)
     }
-  };
+  } as any /* FIX ME*/;
 
   return { operation, operationId, fileId };
-};
+};