From c19abe0da79243d7c13be88f39081564747e75ff Mon Sep 17 00:00:00 2001 From: Ludy Date: Mon, 29 Sep 2025 13:48:35 +0200 Subject: [PATCH] refactor(frontend): add display names for forwardRef components (#4523) # Description of Changes - Added `displayName` properties to `QuickAccessBar` and `TextInput` components. - This improves debugging and React DevTools readability by ensuring components have clear, identifiable names instead of anonymous `ForwardRef`. - Minor formatting cleanup in `QuickAccessBar` for consistency. --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. Co-authored-by: Reece Browne <74901996+reecebrowne@users.noreply.github.com> --- frontend/src/components/shared/QuickAccessBar.tsx | 10 ++++++---- frontend/src/components/shared/TextInput.tsx | 2 ++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/frontend/src/components/shared/QuickAccessBar.tsx b/frontend/src/components/shared/QuickAccessBar.tsx index 2ebe45002..8bc536bdb 100644 --- a/frontend/src/components/shared/QuickAccessBar.tsx +++ b/frontend/src/components/shared/QuickAccessBar.tsx @@ -41,10 +41,10 @@ const QuickAccessBar = forwardRef((_, ref) => { // Helper function to render navigation buttons with URL support const renderNavButton = (config: ButtonConfig, index: number) => { const isActive = isNavButtonActive(config, activeButton, isFilesModalOpen, configModalOpen, selectedToolKey, leftPanelView); - + // Check if this button has URL navigation support - const navProps = config.type === 'navigation' && (config.id === 'read' || config.id === 'automate') - ? getToolNavigation(config.id) + const navProps = config.type === 'navigation' && (config.id === 'read' || config.id === 'automate') + ? getToolNavigation(config.id) : null; const handleClick = (e?: React.MouseEvent) => { @@ -59,7 +59,7 @@ const QuickAccessBar = forwardRef((_, ref) => { return (
handleClick(e), @@ -249,4 +249,6 @@ const QuickAccessBar = forwardRef((_, ref) => { ); }); +QuickAccessBar.displayName = 'QuickAccessBar'; + export default QuickAccessBar; diff --git a/frontend/src/components/shared/TextInput.tsx b/frontend/src/components/shared/TextInput.tsx index a5dd90569..63c69bb08 100644 --- a/frontend/src/components/shared/TextInput.tsx +++ b/frontend/src/components/shared/TextInput.tsx @@ -107,3 +107,5 @@ export const TextInput = forwardRef(({
); }); + +TextInput.displayName = 'TextInput';