Mirrors/Stirling-PDF
1
0
Fork 0
mirror of https://github.com/Frooodle/Stirling-PDF.git synced 2026-02-17 13:52:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

perf: Logging statements to use parameterized messages (#4399)

Browse Source
This commit is contained in:
Balázs Szücs
2025-09-28 22:17:58 +02:00
committed by GitHub
parent d5a3f768bc
commit e44d5f3714
10 changed files with 25 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/common/src/main/java/stirling/software/common/model/ApplicationProperties.java
View File

@@ -73,11 +73,11 @@ public class ApplicationProperties {
public PropertySource<?> dynamicYamlPropertySource(ConfigurableEnvironment environment)
throws IOException {
String configPath = InstallationPathConfig.getSettingsPath();
log.debug("Attempting to load settings from: " + configPath);
log.debug("Attempting to load settings from: {}", configPath);
File file = new File(configPath);
if (!file.exists()) {
log.error("Warning: Settings file does not exist at: " + configPath);
log.error("Warning: Settings file does not exist at: {}", configPath);
}
Resource resource = new FileSystemResource(configPath);
@@ -90,7 +90,7 @@ public class ApplicationProperties {
new YamlPropertySourceFactory().createPropertySource(null, encodedResource);
environment.getPropertySources().addFirst(propertySource);
log.debug("Loaded properties: " + propertySource.getSource());
log.debug("Loaded properties: {}", propertySource.getSource());
return propertySource;
}

6
app/common/src/main/java/stirling/software/common/util/ProcessExecutor.java
View File

@@ -167,7 +167,7 @@ public class ProcessExecutor {
semaphore.acquire();
try {
log.info("Running command: " + String.join(" ", command));
log.info("Running command: {}", String.join(" ", command));
ProcessBuilder processBuilder = new ProcessBuilder(command);
// Use the working directory if it's set
@@ -252,7 +252,7 @@ public class ProcessExecutor {
String outputMessage = String.join("\n", outputLines);
messages += outputMessage;
if (!liveUpdates) {
log.info("Command output:\n" + outputMessage);
log.info("Command output:\n{}", outputMessage);
}
}
@@ -260,7 +260,7 @@ public class ProcessExecutor {
String errorMessage = String.join("\n", errorLines);
messages += errorMessage;
if (!liveUpdates) {
log.warn("Command error output:\n" + errorMessage);
log.warn("Command error output:\n{}", errorMessage);
}
if (exitCode != 0) {
if (isQpdf && exitCode == 3) {