Enable and fix no-empty linting rule

This commit is contained in:
James Brunton 2025-09-02 16:57:03 +01:00
parent 0de0bb2d41
commit ef7c25482e
3 changed files with 9 additions and 8 deletions

View File

@ -15,7 +15,6 @@ export default defineConfig(
},
{
"rules": {
"no-empty": "off", // Temporarily disabled until codebase conformant
"no-empty-pattern": "off", // Temporarily disabled until codebase conformant
"no-undef": "off", // Temporarily disabled until codebase conformant
"no-useless-escape": "off", // Temporarily disabled until codebase conformant

View File

@ -82,8 +82,8 @@ export function adjustFontSizeToFit(
return () => {
cancelAnimationFrame(raf);
try { ro.disconnect(); } catch {}
try { mo.disconnect(); } catch {}
try { ro.disconnect(); } catch { /* Ignore errors */ }
try { mo.disconnect(); } catch { /* Ignore errors */ }
};
}

View File

@ -1,6 +1,6 @@
/**
* PDF.js Worker Manager - Centralized worker lifecycle management
*
*
* Prevents infinite worker creation by managing PDF.js workers globally
* and ensuring proper cleanup when operations complete.
*/
@ -86,7 +86,7 @@ class PDFWorkerManager {
const pdf = await loadingTask.promise;
this.activeDocuments.add(pdf);
this.workerCount++;
return pdf;
} catch (error) {
// If document creation fails, make sure to clean up the loading task
@ -94,6 +94,7 @@ class PDFWorkerManager {
try {
loadingTask.destroy();
} catch (destroyError) {
// Ignore errors
}
}
throw error;
@ -125,7 +126,7 @@ class PDFWorkerManager {
documentsToDestroy.forEach(pdf => {
this.destroyDocument(pdf);
});
this.activeDocuments.clear();
this.workerCount = 0;
}
@ -166,9 +167,10 @@ class PDFWorkerManager {
try {
pdf.destroy();
} catch (error) {
// Ignore errors
}
});
this.activeDocuments.clear();
this.workerCount = 0;
}
@ -182,4 +184,4 @@ class PDFWorkerManager {
}
// Export singleton instance
export const pdfWorkerManager = PDFWorkerManager.getInstance();
export const pdfWorkerManager = PDFWorkerManager.getInstance();