mirror of
				https://github.com/Frooodle/Stirling-PDF.git
				synced 2025-11-01 01:21:18 +01:00 
			
		
		
		
	Fix showupdate (#3032)
# Description of Changes Please provide a summary of the changes, including:  --- ## Checklist ### General - [x] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [x] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [x] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [x] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#6-testing) for more details.
This commit is contained in:
		
							parent
							
								
									f5ca02df1d
								
							
						
					
					
						commit
						f23a2d508f
					
				@ -57,13 +57,17 @@ async function checkForUpdate() {
 | 
			
		||||
  // Initialize the update button as hidden
 | 
			
		||||
  var updateBtn = document.getElementById("update-btn") || null;
 | 
			
		||||
  var updateLink = document.getElementById("update-link") || null;
 | 
			
		||||
  var updateLinkLegacy = document.getElementById("update-link-legacy") || null;
 | 
			
		||||
  if (updateBtn !== null) {
 | 
			
		||||
    updateBtn.style.display = "none";
 | 
			
		||||
  }
 | 
			
		||||
  if (updateLink !== null) {
 | 
			
		||||
    updateLink.style.display = "none";
 | 
			
		||||
  }
 | 
			
		||||
  if (updateLinkLegacy !== null) {
 | 
			
		||||
    console.log("hidden!");
 | 
			
		||||
    if (!updateLink.classList.contains("visually-hidden")) {
 | 
			
		||||
      updateLink.classList.add("visually-hidden");
 | 
			
		||||
    if (!updateLinkLegacy.classList.contains("visually-hidden")) {
 | 
			
		||||
      updateLinkLegacy.classList.add("visually-hidden");
 | 
			
		||||
    }
 | 
			
		||||
  }
 | 
			
		||||
 | 
			
		||||
@ -76,16 +80,19 @@ async function checkForUpdate() {
 | 
			
		||||
      document.getElementById("update-btn").style.display = "block";
 | 
			
		||||
    }
 | 
			
		||||
    if (updateLink !== null) {
 | 
			
		||||
      document.getElementById("update-link").style.display = "flex";
 | 
			
		||||
    }
 | 
			
		||||
    if (updateLinkLegacy !== null) {
 | 
			
		||||
      document.getElementById("app-update").innerHTML = updateAvailable.replace("{0}", '<b>' + currentVersion + '</b>').replace("{1}", '<b>' + latestVersion + '</b>');
 | 
			
		||||
      if (updateLink.classList.contains("visually-hidden")) {
 | 
			
		||||
        updateLink.classList.remove("visually-hidden");
 | 
			
		||||
      if (updateLinkLegacy.classList.contains("visually-hidden")) {
 | 
			
		||||
        updateLinkLegacy.classList.remove("visually-hidden");
 | 
			
		||||
      }
 | 
			
		||||
    }
 | 
			
		||||
    console.log("visible");
 | 
			
		||||
  } else {
 | 
			
		||||
    if (updateLink !== null) {
 | 
			
		||||
      if (!updateLink.classList.contains("visually-hidden")) {
 | 
			
		||||
        updateLink.classList.add("visually-hidden");
 | 
			
		||||
    if (updateLinkLegacy !== null) {
 | 
			
		||||
      if (!updateLinkLegacy.classList.contains("visually-hidden")) {
 | 
			
		||||
        updateLinkLegacy.classList.add("visually-hidden");
 | 
			
		||||
      }
 | 
			
		||||
    }
 | 
			
		||||
    console.log("hidden");
 | 
			
		||||
 | 
			
		||||
@ -73,12 +73,6 @@ function reorderCards(container) {
 | 
			
		||||
  cards.sort(function (a, b) {
 | 
			
		||||
    var aIsFavorite = localStorage.getItem(a.id) === 'favorite';
 | 
			
		||||
    var bIsFavorite = localStorage.getItem(b.id) === 'favorite';
 | 
			
		||||
    if (a.id === 'update-link') {
 | 
			
		||||
      return -1;
 | 
			
		||||
    }
 | 
			
		||||
    if (b.id === 'update-link') {
 | 
			
		||||
      return 1;
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    if (aIsFavorite && !bIsFavorite) {
 | 
			
		||||
      return -1;
 | 
			
		||||
 | 
			
		||||
@ -55,8 +55,7 @@
 | 
			
		||||
 | 
			
		||||
        <div class="features-container">
 | 
			
		||||
 | 
			
		||||
          <div th:if="${@shouldShow}" class="feature-card favorite update-notice" id="update-link"
 | 
			
		||||
            style="display: none;">
 | 
			
		||||
          <div th:if="${@shouldShow}" class="feature-card favorite update-notice visually-hidden" id="update-link-legacy">
 | 
			
		||||
            <a href="https://github.com/Stirling-Tools/Stirling-PDF/releases" target="_blank" rel="noopener">
 | 
			
		||||
              <div class="d-flex align-items-center">
 | 
			
		||||
                <div id="tool-icon" class="advance" alt="icon">
 | 
			
		||||
 | 
			
		||||
@ -26,14 +26,16 @@
 | 
			
		||||
          <div style="justify-content: center; display: flex;">
 | 
			
		||||
            <div style="margin:0 3rem">
 | 
			
		||||
              <div>
 | 
			
		||||
                <div style="display:flex; flex-direction: column; justify-content: center; width:100%; margin-bottom:1rem">
 | 
			
		||||
                <div
 | 
			
		||||
                  style="display:flex; flex-direction: column; justify-content: center; width:100%; margin-bottom:1rem">
 | 
			
		||||
                  <div style="width:fit-content; margin: 0 auto; padding: 0 3rem">
 | 
			
		||||
                    <p class="lead fs-4"
 | 
			
		||||
                      th:text="${@homeText != 'null' and @homeText != null and @homeText != ''} ? ${@homeText} : #{home.desc}">
 | 
			
		||||
                    </p>
 | 
			
		||||
                  </div>
 | 
			
		||||
                  <div id="groupRecent" style="width: fit-content; margin: 0 auto">
 | 
			
		||||
                    <div th:replace="~{fragments/featureGroupHeader :: featureGroupHeader(groupTitle=#{navbar.recent})}">
 | 
			
		||||
                    <div
 | 
			
		||||
                      th:replace="~{fragments/featureGroupHeader :: featureGroupHeader(groupTitle=#{navbar.recent})}">
 | 
			
		||||
                    </div>
 | 
			
		||||
                    <div class="recent-features">
 | 
			
		||||
                      <div class="newfeature"
 | 
			
		||||
@ -66,8 +68,10 @@
 | 
			
		||||
                    <!-- <option value="server">Popularity in organisation</option> -->
 | 
			
		||||
                  </select>
 | 
			
		||||
                </div>
 | 
			
		||||
                <div style="display: flex; align-items: center; flex-wrap: wrap; align-content: flex-start; width: fit-content; max-width: 100%; gap:2rem;  justify-content: center;">
 | 
			
		||||
                <div th:title="#{home.setFavorites}" style="display: flex; align-items: center; cursor: pointer;" onclick="toggleFavoritesMode()">
 | 
			
		||||
                <div
 | 
			
		||||
                  style="display: flex; align-items: center; flex-wrap: wrap; align-content: flex-start; width: fit-content; max-width: 100%; gap:2rem;  justify-content: center;">
 | 
			
		||||
                  <div th:title="#{home.setFavorites}" style="display: flex; align-items: center; cursor: pointer;"
 | 
			
		||||
                    onclick="toggleFavoritesMode()">
 | 
			
		||||
                    <span class="material-symbols-rounded toggle-favourites"
 | 
			
		||||
                      style="font-size: 2rem;  margin-left: 0.2rem;">
 | 
			
		||||
                      star
 | 
			
		||||
@ -82,13 +86,19 @@
 | 
			
		||||
                  </div>
 | 
			
		||||
                  <a href="home" onclick="setAsDefault('home-legacy')" th:title="#{home.legacyHomepage}"
 | 
			
		||||
                    style="text-decoration: none; color: inherit; cursor: pointer; display: flex; align-items: center;">
 | 
			
		||||
                    </span>
 | 
			
		||||
                    <span class="material-symbols-rounded toggle-favourites"
 | 
			
		||||
                      style="font-size: 2rem; margin-left: 0.2rem;">
 | 
			
		||||
                      home
 | 
			
		||||
                    </span>
 | 
			
		||||
                  </a>
 | 
			
		||||
 | 
			
		||||
                  <a th:if="${@shouldShow}" href="https://github.com/Stirling-Tools/Stirling-PDF/releases"
 | 
			
		||||
                    target="_blank" id="update-link" rel="noopener" th:title="#{settings.update}"
 | 
			
		||||
                    style="text-decoration: none; color: inherit; cursor: pointer; display: flex; align-items: center;">
 | 
			
		||||
                    <span class="material-symbols-rounded toggle-favourites"
 | 
			
		||||
                      style="font-size: 2rem; margin-left: 0.2rem;">
 | 
			
		||||
                      update
 | 
			
		||||
                    </span>
 | 
			
		||||
                  </a>
 | 
			
		||||
                </div>
 | 
			
		||||
 | 
			
		||||
              </div>
 | 
			
		||||
@ -102,20 +112,6 @@
 | 
			
		||||
        border-color: var(--md-nav-color-on-seperator);
 | 
			
		||||
        margin-top: 1rem;
 | 
			
		||||
      ">
 | 
			
		||||
          <div th:if="${@shouldShow}" class="feature-card favorite update-notice" id="update-link"
 | 
			
		||||
            style="display: none;">
 | 
			
		||||
            <a href="https://github.com/Stirling-Tools/Stirling-PDF/releases" target="_blank" rel="noopener">
 | 
			
		||||
              <div class="d-flex align-items-center">
 | 
			
		||||
                <div id="tool-icon" class="advance" alt="icon">
 | 
			
		||||
                  <span class="material-symbols-rounded nav-icon">update</span>
 | 
			
		||||
                </div>
 | 
			
		||||
                <div id="tool-text">
 | 
			
		||||
                  <h5 class="card-title" th:text="#{settings.update}"></h5>
 | 
			
		||||
                  <p class="card-text" id="app-update"></p>
 | 
			
		||||
                </div>
 | 
			
		||||
              </div>
 | 
			
		||||
            </a>
 | 
			
		||||
          </div>
 | 
			
		||||
          <div class="feature-rows">
 | 
			
		||||
            <div id="groupFavorites" class="feature-group">
 | 
			
		||||
              <div th:replace="~{fragments/featureGroupHeader :: featureGroupHeader(groupTitle=#{navbar.favorite})}">
 | 
			
		||||
 | 
			
		||||
		Loading…
	
		Reference in New Issue
	
	Block a user