From f600c6447c9dc9e90d4f9774aaf9635448c89324 Mon Sep 17 00:00:00 2001 From: Anthony Stirling <77850077+Frooodle@users.noreply.github.com> Date: Tue, 25 Nov 2025 11:29:03 +0000 Subject: [PATCH] Remove sign_verify job from multiOSReleases workflow (#4994) Removed the sign_verify job from the multiOSReleases workflow to streamline the release process. # Description of Changes --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. --- .github/workflows/multiOSReleases.yml | 70 +-------------------------- 1 file changed, 1 insertion(+), 69 deletions(-) diff --git a/.github/workflows/multiOSReleases.yml b/.github/workflows/multiOSReleases.yml index e1ac603b3..d05779f7d 100644 --- a/.github/workflows/multiOSReleases.yml +++ b/.github/workflows/multiOSReleases.yml @@ -224,78 +224,10 @@ jobs: path: | ./binaries/* - sign_verify: - needs: [read_versions, build-installers] - strategy: - matrix: - include: - - os: windows-latest - platform: win- - - os: macos-latest - platform: mac- - # - os: ubuntu-latest - # platform: linux- - runs-on: ubuntu-latest - steps: - - name: Harden Runner - uses: step-security/harden-runner@95d9a5deda9de15063e7595e9719c11c38c90ae2 # v2.13.2 - with: - egress-policy: audit - - - name: Download build artifacts - uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0 - with: - name: ${{ matrix.platform }}binaries - - - name: Display structure of downloaded files - run: ls -R - - - name: Install Cosign - if: matrix.os == 'windows-latest' - uses: sigstore/cosign-installer@faadad0cce49287aee09b3a48701e75088a2c6ad # v4.0.0 - - - name: Generate key pair - if: matrix.os == 'windows-latest' - run: cosign generate-key-pair - - - name: Sign and generate attestations - if: matrix.os == 'windows-latest' - run: | - cosign sign-blob \ - --key ./cosign.key \ - --yes \ - --output-signature ./Stirling-PDF-win-installer.exe.sig \ - ./Stirling-PDF-win-installer.exe - - cosign attest-blob \ - --predicate - \ - --key ./cosign.key \ - --yes \ - --output-attestation ./Stirling-PDF-win-installer.exe.intoto.jsonl \ - ./Stirling-PDF-win-installer.exe - - cosign verify-blob \ - --key ./cosign.pub \ - --signature ./Stirling-PDF-win-installer.exe.sig \ - ./Stirling-PDF-win-installer.exe - - - name: Display structure of downloaded files - run: ls -R - - - name: Upload signed artifacts - uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0 - with: - retention-days: 1 - if-no-files-found: error - name: ${{ matrix.platform }}signed - path: | - ./Stirling-PDF-${{ matrix.platform }}installer.* - ./Stirling-PDF-${{ matrix.platform }}x86_64-installer.* - !cosign.* create-release: if: github.event_name != 'workflow_dispatch' || github.event.inputs.test_mode != 'true' - needs: [read_versions, sign_verify, sign_verify-portable] + needs: [read_versions, sign_verify-portable] runs-on: ubuntu-latest permissions: contents: write