mirror of
https://github.com/Frooodle/Stirling-PDF.git
synced 2025-08-29 13:48:46 +02:00
1f41cb97b0
# Description of Changes - **What was changed** - In `.github/workflows/PR-Demo-cleanup.yml`, updated the GitHub Script step to properly destructure the list of comments and renamed the flag from the undefined `deploymentComment` to `hasDeploymentComment`. - Enhanced output logic to set the `present` flag based on either label presence or comment presence. - **Why the change was made** - The cleanup job was failing with a `ReferenceError: deploymentComment is not defined` because the variable used in `core.setOutput()` did not exist. - Ensuring the flag accurately reflects whether a deployment label or comment was present prevents unexpected workflow failures. --- ## Checklist ### General - [x] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [x] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. |
||
|---|---|---|
| .. | ||
| ai_pr_title_review.yml | ||
| auto-labelerV2.yml | ||
| build.yml | ||
| check_properties.yml | ||
| codeql.yml-disabled | ||
| dependency-review.yml | ||
| licenses-update.yml | ||
| manage-label.yml | ||
| multiOSReleases.yml | ||
| PR-Demo-cleanup.yml | ||
| PR-Demo-Comment-with-react.yml | ||
| pre_commit.yml | ||
| push-docker.yml | ||
| releaseArtifacts.yml | ||
| scorecards.yml | ||
| sonarqube.yml | ||
| stale.yml | ||
| swagger.yml | ||
| sync_files.yml | ||
| testdriver.yml | ||