mirror of
https://github.com/Frooodle/Stirling-PDF.git
synced 2025-12-18 20:04:17 +01:00
7b58b50c00
# Description of Changes TLDR: - Introduced `AtomicBoolean` to detect error messages dynamically - Changed logging to use `log.debug` for non-error lines and `log.info` for error-related lines during live updates - Improved error and output stream handling for better log verbosity and behaviour This pull request improves the logging behavior in the `ProcessExecutor` utility by making log output more informative and easier to follow, especially when errors occur. Now, lines containing "ERROR" (case-insensitive) and all subsequent lines are logged at the info level, while other lines are logged at the debug level. This helps to highlight errors during process execution without overwhelming the logs with less important information. **Logging improvements:** * Added an `AtomicBoolean` flag (`errorDetected`) to track when an error message appears in process output or error streams. * Modified both error and output stream handlers to: * Check if each line contains "ERROR" (case-insensitive) and set `errorDetected` if so. * Log lines at the info level if an error has been detected, otherwise log at the debug level. **Dependency update:** * Imported `AtomicBoolean` to support the new error tracking logic. <!-- Please provide a summary of the changes, including: - What was changed - Why the change was made - Any challenges encountered Closes #(issue_number) --> --- ## Checklist ### General - [X] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [X] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [X] I have performed a self-review of my own code - [X] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [X] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. --------- Signed-off-by: Balázs Szücs <bszucs1209@gmail.com> |
||
|---|---|---|
| .. | ||
| common | ||
| core | ||
| proprietary | ||
| allowed-licenses.json | ||