mirror of
https://github.com/Frooodle/Stirling-PDF.git
synced 2025-11-16 01:21:16 +01:00
Main Issues Fixed: 1. Tools Disabled on Initial Login (Required Page Refresh) Problem: After successful login, all PDF tools appeared grayed out/disabled until the user refreshed the page. Root Cause: Race condition where tools checked endpoint availability before JWT was stored in localStorage. Fix: - Implemented optimistic defaults in useEndpointConfig - assumes endpoints are enabled when no JWT exists - Added JWT availability event system (jwt-available event) to notify components when authentication is ready - Tools now remain enabled during auth initialization instead of defaulting to disabled 2. Session Lost on Page Refresh (Immediate Logout) Problem: Users were immediately logged out when refreshing the page, losing their authenticated session. Root Causes: - Spring Security form login was redirecting API calls to /login with 302 responses instead of returning JSON - /api/v1/auth/me endpoint was incorrectly in the permitAll list - JWT filter wasn't allowing /api/v1/config endpoints without authentication Fixes: - Backend: Disabled form login in v2/JWT mode by adding && !v2Enabled condition to form login configuration - Backend: Removed /api/v1/auth/me from permitAll list - it now requires authentication - Backend: Added /api/v1/config to public endpoints in JWT filter - Backend: Configured proper exception handling for API endpoints to return JSON (401) instead of HTML redirects (302) 3. Multiple Duplicate API Calls Problem: After login, /app-config was called 5+ times, /endpoints-enabled and /me called multiple times, causing unnecessary network traffic. Root Cause: Multiple React components each had their own instance of useAppConfig and useEndpointConfig hooks, each fetching data independently. Fix: - Frontend: Created singleton AppConfigContext provider to ensure only one global config fetch - Frontend: Added global caching to useEndpointConfig with module-level cache variables - Frontend: Implemented fetch deduplication with fetchCount tracking and globalFetchedSets - Result: Reduced API calls from 5+ to 1-2 per endpoint (2 in dev due to React StrictMode) Additional Improvements: CORS Configuration - Added flexible CORS configuration matching SaaS pattern - Explicitly allows localhost development ports (3000, 5173, 5174, etc.) - No hardcoded URLs in application.properties Security Handlers Integration - Added IP-based account locking without dependency on form login - Preserved audit logging with @Audited annotations Key Code Changes: Backend Files: - SecurityConfiguration.java - Disabled form login for v2, added CORS config - JwtAuthenticationFilter.java - Added /api/v1/config to public endpoints - JwtAuthenticationEntryPoint.java - Returns JSON for API requests Frontend Files: - AppConfigContext.tsx - New singleton context for app configuration - useEndpointConfig.ts - Added global caching and deduplication - UseSession.tsx - Removed redundant config checking - Various hooks - Updated to use context providers instead of direct fetching --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: stirlingbot[bot] <stirlingbot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ludy <Ludy87@users.noreply.github.com> Co-authored-by: EthanHealy01 <80844253+EthanHealy01@users.noreply.github.com> Co-authored-by: Ethan <ethan@MacBook-Pro.local> Co-authored-by: Anthony Stirling <77850077+Frooodle@users.noreply.github.com> Co-authored-by: stirlingbot[bot] <195170888+stirlingbot[bot]@users.noreply.github.com> Co-authored-by: ConnorYoh <40631091+ConnorYoh@users.noreply.github.com> Co-authored-by: Connor Yoh <connor@stirlingpdf.com>
219 lines
5.6 KiB
TypeScript
219 lines
5.6 KiB
TypeScript
import { createContext, useContext, useEffect, useState, ReactNode, useCallback } from 'react';
|
|
import { springAuth } from '@app/auth/springAuthClient';
|
|
import type { Session, User, AuthError } from '@app/auth/springAuthClient';
|
|
|
|
/**
|
|
* Auth Context Type
|
|
* Simplified version without SaaS-specific features (credits, subscriptions)
|
|
*/
|
|
interface AuthContextType {
|
|
session: Session | null;
|
|
user: User | null;
|
|
loading: boolean;
|
|
error: AuthError | null;
|
|
signOut: () => Promise<void>;
|
|
refreshSession: () => Promise<void>;
|
|
}
|
|
|
|
const AuthContext = createContext<AuthContextType>({
|
|
session: null,
|
|
user: null,
|
|
loading: true,
|
|
error: null,
|
|
signOut: async () => {},
|
|
refreshSession: async () => {},
|
|
});
|
|
|
|
/**
|
|
* Auth Provider Component
|
|
*
|
|
* Manages authentication state and provides it to the entire app.
|
|
* Integrates with Spring Security + JWT backend.
|
|
*/
|
|
export function AuthProvider({ children }: { children: ReactNode }) {
|
|
const [session, setSession] = useState<Session | null>(null);
|
|
const [loading, setLoading] = useState(true);
|
|
const [error, setError] = useState<AuthError | null>(null);
|
|
|
|
/**
|
|
* Refresh current session
|
|
*/
|
|
const refreshSession = useCallback(async () => {
|
|
try {
|
|
setLoading(true);
|
|
setError(null);
|
|
console.debug('[Auth] Refreshing session...');
|
|
|
|
const { data, error } = await springAuth.refreshSession();
|
|
|
|
if (error) {
|
|
console.error('[Auth] Session refresh error:', error);
|
|
setError(error);
|
|
setSession(null);
|
|
} else {
|
|
console.debug('[Auth] Session refreshed successfully');
|
|
setSession(data.session);
|
|
}
|
|
} catch (err) {
|
|
console.error('[Auth] Unexpected error during session refresh:', err);
|
|
setError(err as AuthError);
|
|
} finally {
|
|
setLoading(false);
|
|
}
|
|
}, []);
|
|
|
|
/**
|
|
* Sign out user
|
|
*/
|
|
const signOut = useCallback(async () => {
|
|
try {
|
|
setError(null);
|
|
console.debug('[Auth] Signing out...');
|
|
|
|
const { error } = await springAuth.signOut();
|
|
|
|
if (error) {
|
|
console.error('[Auth] Sign out error:', error);
|
|
setError(error);
|
|
} else {
|
|
console.debug('[Auth] Signed out successfully');
|
|
setSession(null);
|
|
}
|
|
} catch (err) {
|
|
console.error('[Auth] Unexpected error during sign out:', err);
|
|
setError(err as AuthError);
|
|
}
|
|
}, []);
|
|
|
|
/**
|
|
* Initialize auth on mount
|
|
*/
|
|
useEffect(() => {
|
|
let mounted = true;
|
|
|
|
const initializeAuth = async () => {
|
|
try {
|
|
console.debug('[Auth] Initializing auth...');
|
|
|
|
// Skip config check entirely - let the app handle login state
|
|
// The config will be fetched by useAppConfig when needed
|
|
const { data, error } = await springAuth.getSession();
|
|
|
|
if (!mounted) return;
|
|
|
|
if (error) {
|
|
console.error('[Auth] Initial session error:', error);
|
|
setError(error);
|
|
} else {
|
|
console.debug('[Auth] Initial session loaded:', {
|
|
hasSession: !!data.session,
|
|
userId: data.session?.user?.id,
|
|
email: data.session?.user?.email,
|
|
});
|
|
setSession(data.session);
|
|
}
|
|
} catch (err) {
|
|
console.error('[Auth] Unexpected error during auth initialization:', err);
|
|
if (mounted) {
|
|
setError(err as AuthError);
|
|
}
|
|
} finally {
|
|
if (mounted) {
|
|
setLoading(false);
|
|
}
|
|
}
|
|
};
|
|
|
|
initializeAuth();
|
|
|
|
// Subscribe to auth state changes
|
|
const { data: { subscription } } = springAuth.onAuthStateChange(
|
|
async (event, newSession) => {
|
|
if (!mounted) return;
|
|
|
|
console.debug('[Auth] Auth state change:', {
|
|
event,
|
|
hasSession: !!newSession,
|
|
userId: newSession?.user?.id,
|
|
email: newSession?.user?.email,
|
|
timestamp: new Date().toISOString(),
|
|
});
|
|
|
|
// Schedule state update
|
|
setTimeout(() => {
|
|
if (mounted) {
|
|
setSession(newSession);
|
|
setError(null);
|
|
|
|
// Handle specific events
|
|
if (event === 'SIGNED_OUT') {
|
|
console.debug('[Auth] User signed out, clearing session');
|
|
} else if (event === 'SIGNED_IN') {
|
|
console.debug('[Auth] User signed in successfully');
|
|
} else if (event === 'TOKEN_REFRESHED') {
|
|
console.debug('[Auth] Token refreshed');
|
|
} else if (event === 'USER_UPDATED') {
|
|
console.debug('[Auth] User updated');
|
|
}
|
|
}
|
|
}, 0);
|
|
}
|
|
);
|
|
|
|
return () => {
|
|
mounted = false;
|
|
subscription.unsubscribe();
|
|
};
|
|
}, []);
|
|
|
|
const value: AuthContextType = {
|
|
session,
|
|
user: session?.user ?? null,
|
|
loading,
|
|
error,
|
|
signOut,
|
|
refreshSession,
|
|
};
|
|
|
|
return (
|
|
<AuthContext.Provider value={value}>
|
|
{children}
|
|
</AuthContext.Provider>
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Hook to access auth context
|
|
* Must be used within AuthProvider
|
|
*/
|
|
export function useAuth() {
|
|
const context = useContext(AuthContext);
|
|
|
|
if (context === undefined) {
|
|
throw new Error('useAuth must be used within an AuthProvider');
|
|
}
|
|
|
|
return context;
|
|
}
|
|
|
|
/**
|
|
* Debug hook to expose auth state for debugging
|
|
* Can be used in development to monitor auth state
|
|
*/
|
|
export function useAuthDebug() {
|
|
const auth = useAuth();
|
|
|
|
useEffect(() => {
|
|
console.debug('[Auth Debug] Current auth state:', {
|
|
hasSession: !!auth.session,
|
|
hasUser: !!auth.user,
|
|
loading: auth.loading,
|
|
hasError: !!auth.error,
|
|
userId: auth.user?.id,
|
|
email: auth.user?.email,
|
|
});
|
|
}, [auth.session, auth.user, auth.loading, auth.error]);
|
|
|
|
return auth;
|
|
}
|