mirror of
https://github.com/Frooodle/Stirling-PDF.git
synced 2026-02-17 13:52:14 +01:00
8f6fcee428
Previously, activating signature placement mode would immediately set signaturesApplied=false, blocking export even when no signatures were actually placed on the PDF. This caused the "unapplied signatures" warning to appear incorrectly after clicking "Apply Signatures". Changes: - Remove signaturesApplied=false from activateDrawMode and activateSignaturePlacementMode in SignatureContext - Add signaturesApplied=false to onAnnotationEvent handler in SignatureAPIBridge when event.type === 'create' - Now signatures are only marked as unapplied when actually placed This ensures: - Users can activate placement mode without triggering export warning - Export is only blocked when signatures are actually placed but not applied - After applying signatures, users can immediately export without warning 🤖 Generated with [Claude Code](https://claude.com/claude-code) # Description of Changes <!-- Please provide a summary of the changes, including: - What was changed - Why the change was made - Any challenges encountered Closes #(issue_number) --> --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. Co-authored-by: Claude <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| components | ||
| constants | ||
| contexts | ||
| data | ||
| hooks | ||
| i18n | ||
| pages | ||
| services | ||
| styles | ||
| testing | ||
| tests | ||
| theme | ||
| tools | ||
| types | ||
| utils | ||
| workers | ||
| App.tsx | ||
| i18n.ts | ||
| setupTests.js | ||
| setupTests.ts | ||