mirror of
https://github.com/Frooodle/Stirling-PDF.git
synced 2026-02-01 20:10:35 +01:00
91bf9abbaa
# Description of Changes This PR fixes resource leaks and memory issues in PDF processing by implementing proper resource management patterns throughout the codebase. ## Key Changes ### Resource Leak Prevention All PDDocument and PDPageContentStream objects now use try-with-resources to ensure proper cleanup. Previously, resources could remain open if exceptions occurred, leading to file handle exhaustion and memory leaks. ### Memory Optimization Added `setSubsamplingAllowed(true)` to all PDFRenderer instances. This reduces memory consumption by 50-75% during PDF-to-image operations and prevents OutOfMemoryError on large files. **Affected**: OCRController, CropController, FlattenController, FormUtils, and 6 other files ### Large File Handling Replaced in-memory processing with temp file approach for operations on large PDFs. This prevents loading entire documents into memory. **Example (GetInfoOnPDF.java):** - Before: Loaded entire PDF into ByteArrayOutputStream - After: Saves to temp file, streams from disk, cleans up in finally block **Also changed**: PrintFileController, SplitPdfBySizeController ### PDPageContentStream Construction Standardized constructor calls with explicit parameters: - AppendMode: Controls content placement - compress: true for stream compression - resetContext: true for clean graphics state This prevents graphics state corruption and provides better control over rendering. ### Exception Handling - Added NoSuchFileException handling for temp file issues - Check if response is committed before sending error responses - Better error messages for temp file cleanup failures ### Code Quality - Replaced loops with IntStream where appropriate (SplitPdfBySectionsController) - Updated deprecated API usage (PDAnnotationTextMarkup → PDAnnotationHighlight) - Added null checks in Type3FontLibrary - Removed redundant document.close() calls ### Dependencies Added `org.apache.pdfbox:pdfbox-io` dependency for proper I/O handling. <!-- Please provide a summary of the changes, including: - What was changed - Why the change was made - Any challenges encountered Closes #(issue_number) --> --- ## Checklist ### General - [X] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [X] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [X] I have performed a self-review of my own code - [X] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [X] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [X] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. --------- Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
50 lines
1.9 KiB
Groovy
50 lines
1.9 KiB
Groovy
// Configure bootRun to disable it or point to a main class
|
|
bootRun {
|
|
enabled = false
|
|
}
|
|
spotless {
|
|
java {
|
|
target 'src/**/java/**/*.java'
|
|
googleJavaFormat(googleJavaFormatVersion).aosp().reorderImports(false)
|
|
|
|
importOrder("java", "javax", "org", "com", "net", "io", "jakarta", "lombok", "me", "stirling")
|
|
toggleOffOn()
|
|
trimTrailingWhitespace()
|
|
leadingTabsToSpaces()
|
|
endWithNewline()
|
|
}
|
|
yaml {
|
|
target '**/*.yml', '**/*.yaml'
|
|
trimTrailingWhitespace()
|
|
leadingTabsToSpaces()
|
|
endWithNewline()
|
|
}
|
|
format 'gradle', {
|
|
target '**/gradle/*.gradle', '**/*.gradle'
|
|
trimTrailingWhitespace()
|
|
leadingTabsToSpaces()
|
|
endWithNewline()
|
|
}
|
|
}
|
|
dependencies {
|
|
api 'org.springframework.boot:spring-boot-starter-web'
|
|
api 'org.springframework.boot:spring-boot-starter-aop'
|
|
// api 'org.springframework.boot:spring-boot-starter-thymeleaf' // Deprecated - UI moved to React frontend
|
|
api 'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:20240325.1'
|
|
api 'com.fathzer:javaluator:3.0.6'
|
|
api 'com.posthog.java:posthog:1.2.0'
|
|
api 'org.apache.commons:commons-lang3:3.20.0'
|
|
api 'com.drewnoakes:metadata-extractor:2.19.0' // Image metadata extractor
|
|
api 'com.vladsch.flexmark:flexmark-html2md-converter:0.64.8'
|
|
api "org.apache.pdfbox:pdfbox:$pdfboxVersion"
|
|
api "org.apache.pdfbox:pdfbox-io:$pdfboxVersion"
|
|
api "org.apache.pdfbox:xmpbox:$pdfboxVersion"
|
|
api "org.apache.pdfbox:preflight:$pdfboxVersion"
|
|
api 'com.github.junrar:junrar:7.5.7' // RAR archive support for CBR files
|
|
api 'jakarta.servlet:jakarta.servlet-api:6.1.0'
|
|
api 'org.snakeyaml:snakeyaml-engine:2.10'
|
|
api "org.springdoc:springdoc-openapi-starter-webmvc-ui:2.8.14"
|
|
api 'jakarta.mail:jakarta.mail-api:2.1.5'
|
|
runtimeOnly 'org.eclipse.angus:angus-mail:2.0.5'
|
|
}
|