mirror of
https://github.com/Frooodle/Stirling-PDF.git
synced 2026-02-01 20:10:35 +01:00
# Description of Changes ## What was changed - Updated several Mantine `label` compositions in `AdminSecuritySection.tsx` to avoid invalid HTML nesting that can trigger React hydration errors (e.g., a `<div>` rendered inside a `<p>`). - Changed `Group` used inside `NumberInput` / `Select` labels to render as an inline element via `component="span"`. - Added `name` attributes to multiple form controls (`Switch`, `Select`, `NumberInput`, `Textarea`) to satisfy browser/autofill recommendations and improve form field identification. ## Why the change was made - Fixes the runtime warning/error: - `In HTML, <div> cannot be a descendant of <p>. This will cause a hydration error.` - Caused by block-level wrappers inside Mantine `Text`/`p` label rendering. - Addresses the browser audit warning: - `A form field element should have an id or name attribute` - Adding stable `name` attributes improves autofill behavior and form accessibility tooling. --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. |
||
|---|---|---|
| .. | ||
| assets | ||
| core | ||
| desktop | ||
| proprietary | ||
| global.d.ts | ||
| index.tsx | ||
| logo.svg | ||
| output.css | ||
| reportWebVitals.js | ||