mirror of
https://github.com/Frooodle/Stirling-PDF.git
synced 2026-04-06 03:19:39 +02:00
dbff05814f
# Description of Changes Ages ago I made #4835 to try and fix all the `any` type usage in the system but never got it finished, and there were just too many to review and ensure it still worked. There's even more now. My new tactic is to fix folder by folder. This fixes the `any` typing in the `saas/` folder, and also enables `no-unnecessary-type-assertion`, which really helps reduce pointless `as` casts that AI generates when the type is already known. I hope to expand both of these to the rest of the folders soon, but one folder is better than none.
95 lines
2.9 KiB
JavaScript
95 lines
2.9 KiB
JavaScript
// @ts-check
|
|
|
|
import eslint from '@eslint/js';
|
|
import globals from 'globals';
|
|
import { defineConfig } from 'eslint/config';
|
|
import tseslint from 'typescript-eslint';
|
|
|
|
const srcGlobs = [
|
|
'src/**/*.{js,mjs,jsx,ts,tsx}',
|
|
];
|
|
const nodeGlobs = [
|
|
'scripts/**/*.{js,ts,mjs}',
|
|
'*.config.{js,ts,mjs}',
|
|
];
|
|
|
|
export default defineConfig(
|
|
{
|
|
// Everything that contains 3rd party code that we don't want to lint
|
|
ignores: [
|
|
'dist',
|
|
'node_modules',
|
|
'public',
|
|
'src-tauri',
|
|
],
|
|
},
|
|
eslint.configs.recommended,
|
|
tseslint.configs.recommended,
|
|
{
|
|
rules: {
|
|
'no-restricted-imports': [
|
|
'error',
|
|
{
|
|
patterns: [
|
|
".*", // Disallow any relative imports (they should be '@app/x/y/z' or similar)
|
|
"src/*", // Disallow any absolute imports (they should be '@app/x/y/z' or similar)
|
|
],
|
|
},
|
|
],
|
|
'@typescript-eslint/no-empty-object-type': [
|
|
'error',
|
|
{
|
|
// Allow empty extending interfaces because there's no real reason not to, and it makes it obvious where to put extra attributes in the future
|
|
allowInterfaces: 'with-single-extends',
|
|
},
|
|
],
|
|
'@typescript-eslint/no-explicit-any': 'off', // Temporarily disabled until codebase conformant
|
|
'@typescript-eslint/no-require-imports': 'off', // Temporarily disabled until codebase conformant
|
|
'@typescript-eslint/no-unused-vars': [
|
|
'error',
|
|
{
|
|
'args': 'all', // All function args must be used (or explicitly ignored)
|
|
'argsIgnorePattern': '^_', // Allow unused variables beginning with an underscore
|
|
'caughtErrors': 'all', // Caught errors must be used (or explicitly ignored)
|
|
'caughtErrorsIgnorePattern': '^_', // Allow unused variables beginning with an underscore
|
|
'destructuredArrayIgnorePattern': '^_', // Allow unused variables beginning with an underscore
|
|
'varsIgnorePattern': '^_', // Allow unused variables beginning with an underscore
|
|
'ignoreRestSiblings': true, // Allow unused variables when removing attributes from objects (otherwise this requires explicit renaming like `({ x: _x, ...y }) => y`, which is clunky)
|
|
},
|
|
],
|
|
},
|
|
},
|
|
// Folders that have been cleaned up and are now conformant - stricter rules enforced here
|
|
{
|
|
files: ['src/saas/**/*.{js,mjs,jsx,ts,tsx}'],
|
|
languageOptions: {
|
|
parserOptions: {
|
|
project: true,
|
|
tsconfigRootDir: import.meta.dirname,
|
|
},
|
|
},
|
|
rules: {
|
|
'@typescript-eslint/no-explicit-any': 'error',
|
|
'@typescript-eslint/no-unnecessary-type-assertion': 'error',
|
|
},
|
|
},
|
|
// Config for browser scripts
|
|
{
|
|
files: srcGlobs,
|
|
languageOptions: {
|
|
globals: {
|
|
...globals.browser,
|
|
}
|
|
}
|
|
},
|
|
// Config for node scripts
|
|
{
|
|
files: nodeGlobs,
|
|
languageOptions: {
|
|
globals: {
|
|
...globals.node,
|
|
}
|
|
}
|
|
},
|
|
);
|