Replace function for cleaning up user seriesHideFromContinueListening to not use old model

server/Server.js

@@ -383,31 +383,24 @@ class Server {
     }
 
     // Remove series from hide from continue listening that no longer exist
-    const users = await Database.userModel.getOldUsers()
-    for (const _user of users) {
-      let hasUpdated = false
-      if (_user.seriesHideFromContinueListening.length) {
-        const seriesHiding = (
-          await Database.seriesModel.findAll({
-            where: {
-              id: _user.seriesHideFromContinueListening
-            },
-            attributes: ['id'],
-            raw: true
+    try {
+      const users = await Database.sequelize.query(`SELECT u.id, u.username, u.extraData, json_group_array(value) AS seriesIdsToRemove FROM users u, json_each(u.extraData->"seriesHideFromContinueListening") LEFT JOIN series se ON se.id = value WHERE se.id IS NULL GROUP BY u.id;`, {
+        model: Database.userModel,
+        type: Sequelize.QueryTypes.SELECT
       })
-        ).map((se) => se.id)
-        _user.seriesHideFromContinueListening = _user.seriesHideFromContinueListening.filter((seriesId) => {
-          if (!seriesHiding.includes(seriesId)) {
-            // Series removed
-            hasUpdated = true
-            return false
+      for (const user of users) {
+        const extraData = JSON.parse(user.extraData)
+        const existingSeriesIds = extraData.seriesHideFromContinueListening
+        const seriesIdsToRemove = JSON.parse(user.dataValues.seriesIdsToRemove)
+        Logger.info(`[Server] Found ${seriesIdsToRemove.length} non-existent series in seriesHideFromContinueListening for user "${user.username}" - Removing (${seriesIdsToRemove.join(',')})`)
+        const newExtraData = {
+          ...extraData,
+          seriesHideFromContinueListening: existingSeriesIds.filter((s) => !seriesIdsToRemove.includes(s))
         }
-          return true
-        })
-      }
-      if (hasUpdated) {
-        await Database.updateUser(_user)
+        await user.update({ extraData: newExtraData })
       }
+    } catch (error) {
+      Logger.error(`[Server] Failed to cleanup users seriesHideFromContinueListening`, error)
     }
   }