Mirrors/audiobookshelf
Mirrors/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2025-08-14 13:47:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

modified serialization and deserialization of users to only use the useres id, only creating oidc related enpoints, if oidc is configured

Browse Source
This commit is contained in:
David Leimroth 2022-02-09 16:49:17 +01:00
parent cd3feee583
commit 4b93882494
2 changed files with 13 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/Auth.js
View File

@ -2,6 +2,7 @@ const bcrypt = require('bcryptjs')
const jwt = require('jsonwebtoken')
const Logger = require('./Logger')
const User = require('./objects/User')
const { getId } = require('./utils/index')
class Auth {
constructor(db) {
@ -216,7 +217,6 @@ class Auth {
async handleOIDCVerification(issuer, profile, cb) {
Logger.debug(`[Auth] handleOIDCVerification ${issuer}`)
let user = this.db.users.find(u => u.id === profile.id)
if (!user && this.db.SSOSettings.createNewUser) {
// create a user

32
server/Server.js
View File

@ -140,16 +140,16 @@ class Server {
passportInit() {
if (this.db.SSOSettings.isOIDCConfigured) {
Logger.debug(`[Server] passportInit OIDC is configured - init`)
passport.serializeUser((user, next) => {
next(null, user);
next(null, {userId: user.id});
})
passport.deserializeUser((obj, next) => {
this.db.users.find(u => u.id === obj.userId)
next(null, obj);
})
// Initialize passport OIDC verification
passport.use(new OidcStrategy(this.db.SSOSettings.getOIDCSettings(), this.auth.handleOIDCVerification))
passport.use(new OidcStrategy(this.db.SSOSettings.getOIDCSettings(), this.auth.handleOIDCVerification.bind(this.auth)))
} else {
Logger.debug(`[Server] passportInit OIDC not configured`)
}
@ -260,23 +260,15 @@ class Server {
app.post('/logout', this.authMiddleware.bind(this), this.logout.bind(this))
app.get("/oidc/login", (() => {
if (!this.db.SSOSettings.isOIDCConfigured) return (req, res) => res.redirect("/");
return passport.authenticate('openidconnect')
})())
app.get("/oidc/callback",
(() => {
if (!this.db.SSOSettings.isOIDCConfigured) return (req, res) => res.redirect("/");
return passport.authenticate('openidconnect', { failureRedirect: '/oidc/login', failureMessage: true }),
async (req, res) => {
const token = this.auth.generateAccessToken({ userId: req.user.id })
res.cookie('sso', true, { httpOnly: false /* TODO: Set secure: true */ });
res.redirect('/');
}
})()
)
if (this.db.SSOSettings.isOIDCConfigured) {
app.get("/oidc/login", passport.authenticate('openidconnect'))
app.get("/oidc/callback", passport.authenticate('openidconnect', { failureRedirect: '/login', failureMessage: true }),
async (req, res) => {
res.cookie('sso', true, { httpOnly: false /* TODO: Set secure: true */ });
res.redirect('/');
}
)
}
app.get('/ping', (req, res) => {
Logger.info('Recieved ping')