From 4cb8098fa02aafe1b3e70ad977904e6d376ca9cc Mon Sep 17 00:00:00 2001
From: "danny.rich" <danny.rich@jasper.ai>
Date: Mon, 3 Nov 2025 17:14:53 -0500
Subject: [PATCH] fix types and simplify

---
 client/components/cards/LazyBookCard.vue     | 5 ++---
 client/components/modals/item/tabs/Match.vue | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/client/components/cards/LazyBookCard.vue b/client/components/cards/LazyBookCard.vue
index ce024b69d..8a8fe6174 100644
--- a/client/components/cards/LazyBookCard.vue
+++ b/client/components/cards/LazyBookCard.vue
@@ -350,9 +350,8 @@ export default {
         return '\u00A0'
       }
       if (this.orderBy === 'media.metadata.rating') {
-        if (this.mediaMetadata.rating) {
-          const ratingValue = typeof this.mediaMetadata.rating === 'object' && this.mediaMetadata.rating.average ? this.mediaMetadata.rating.average : Number(this.mediaMetadata.rating)
-          if (!isNaN(ratingValue) && ratingValue > 0) return `Rating: ${ratingValue.toFixed(1)}`
+        if (this.mediaMetadata.rating && !isNaN(this.mediaMetadata.rating) && this.mediaMetadata.rating > 0) {
+          return `Rating: ${Number(this.mediaMetadata.rating).toFixed(1)}`
         }
         return '\u00A0'
       }
diff --git a/client/components/modals/item/tabs/Match.vue b/client/components/modals/item/tabs/Match.vue
index b2f5c501e..f76f3bab2 100644
--- a/client/components/modals/item/tabs/Match.vue
+++ b/client/components/modals/item/tabs/Match.vue
@@ -179,7 +179,7 @@
           <div class="grow ml-4">
             <ui-text-input-with-label v-model="selectedMatch.rating" type="number" step="0.1" min="0" max="5" :disabled="!selectedMatchUsage.rating" label="Rating" />
             <p v-if="mediaMetadata.rating" class="text-xs ml-1 text-white/60">
-              {{ $strings.LabelCurrently }} <a :title="$strings.LabelClickToUseCurrentValue" class="cursor-pointer hover:underline" @click.stop="setMatchFieldValue('rating', typeof mediaMetadata.rating === 'object' && mediaMetadata.rating.average ? mediaMetadata.rating.average : Number(mediaMetadata.rating))">{{ typeof mediaMetadata.rating === 'object' && mediaMetadata.rating.average ? mediaMetadata.rating.average.toFixed(1) : Number(mediaMetadata.rating).toFixed(1) }}</a>
+              {{ $strings.LabelCurrently }} <a :title="$strings.LabelClickToUseCurrentValue" class="cursor-pointer hover:underline" @click.stop="setMatchFieldValue('rating', Number(mediaMetadata.rating))">{{ Number(mediaMetadata.rating).toFixed(1) }}</a>
             </p>
           </div>
         </div>
@@ -591,8 +591,7 @@ export default {
         if (!isNaN(ratingValue) && ratingValue > 0) {
           updatePayload.metadata.rating = ratingValue
         } else if (ratingValue === 0 || isNaN(ratingValue)) {
-          // Set to null to remove rating
-          updatePayload.metadata.rating = null
+          updatePayload.metadata.rating = undefined
         }
       }