Merge pull request #2103 from selfhost-alt/faster-scan-for-empty-series

Scan for empty book series more efficiently
This commit is contained in:
advplyr 2023-09-17 15:54:33 -05:00 committed by GitHub
commit 4e01722ba6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -666,7 +666,11 @@ class Database {
async cleanDatabase() { async cleanDatabase() {
// Remove invalid Podcast records // Remove invalid Podcast records
const podcastsWithNoLibraryItem = await this.podcastModel.findAll({ const podcastsWithNoLibraryItem = await this.podcastModel.findAll({
where: Sequelize.where(Sequelize.literal(`(SELECT count(*) FROM libraryItems li WHERE li.mediaId = podcast.id)`), 0) include: {
model: this.libraryItemModel,
required: false
},
where: { '$libraryItem.id$': null }
}) })
for (const podcast of podcastsWithNoLibraryItem) { for (const podcast of podcastsWithNoLibraryItem) {
Logger.warn(`Found podcast "${podcast.title}" with no libraryItem - removing it`) Logger.warn(`Found podcast "${podcast.title}" with no libraryItem - removing it`)
@ -675,7 +679,11 @@ class Database {
// Remove invalid Book records // Remove invalid Book records
const booksWithNoLibraryItem = await this.bookModel.findAll({ const booksWithNoLibraryItem = await this.bookModel.findAll({
where: Sequelize.where(Sequelize.literal(`(SELECT count(*) FROM libraryItems li WHERE li.mediaId = book.id)`), 0) include: {
model: this.libraryItemModel,
required: false
},
where: { '$libraryItem.id$': null }
}) })
for (const book of booksWithNoLibraryItem) { for (const book of booksWithNoLibraryItem) {
Logger.warn(`Found book "${book.title}" with no libraryItem - removing it`) Logger.warn(`Found book "${book.title}" with no libraryItem - removing it`)
@ -684,7 +692,11 @@ class Database {
// Remove empty series // Remove empty series
const emptySeries = await this.seriesModel.findAll({ const emptySeries = await this.seriesModel.findAll({
where: Sequelize.where(Sequelize.literal(`(SELECT count(*) FROM bookSeries bs WHERE bs.seriesId = series.id)`), 0) include: {
model: this.bookSeriesModel,
required: false
},
where: { '$bookSeries.id$': null }
}) })
for (const series of emptySeries) { for (const series of emptySeries) {
Logger.warn(`Found series "${series.name}" with no books - removing it`) Logger.warn(`Found series "${series.name}" with no books - removing it`)