From 5041f80cb031bc2006ef3f530eab859f42c90240 Mon Sep 17 00:00:00 2001
From: CoffeeKnyte <67730400+CoffeeKnyte@users.noreply.github.com>
Date: Wed, 1 May 2024 07:24:42 -0400
Subject: [PATCH] Added limit variable to getAuthorsWithCount()

- Clarified and updated the comments
- added parameter "limit" to getAuthorsWithCount()
- the limit is set to 10 when called from LibraryController.js
- as per Nichwall's comments
---
 server/utils/queries/authorFilters.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/server/utils/queries/authorFilters.js b/server/utils/queries/authorFilters.js
index e13158fe..e684232b 100644
--- a/server/utils/queries/authorFilters.js
+++ b/server/utils/queries/authorFilters.js
@@ -5,7 +5,7 @@ module.exports = {
   /**
    * Get authors total count
    * @param {string} libraryId
-   * @returns {{id:string, name:string, count:number}}
+   * @returns {number} count
    */
   async getAuthorsTotalCount(libraryId) {
     const authorsCount = await Database.authorModel.count({
@@ -19,9 +19,10 @@ module.exports = {
   /**
    * Get authors with count of num books
    * @param {string} libraryId 
+   * @param {number} limit 
    * @returns {{id:string, name:string, count:number}}
    */
-  async getAuthorsWithCount(libraryId) {
+  async getAuthorsWithCount(libraryId, limit) {
     const authors = await Database.bookAuthorModel.findAll({
       include: [{
         model: Database.authorModel,
@@ -37,7 +38,7 @@ module.exports = {
       ],
       group: ['authorId', 'author.id'], // Include 'author.id' to satisfy GROUP BY with JOIN
       order: [[Sequelize.literal('count'), 'DESC']],
-      limit: 10
+      limit: limit
     })
     return authors.map(au => {
       return {