From 74d26eece415af8cf84c8a72f0f160b5a515625e Mon Sep 17 00:00:00 2001
From: advplyr <advplyr@protonmail.com>
Date: Wed, 11 May 2022 18:34:17 -0500
Subject: [PATCH] Add:Re-broadcast podcast with RSS feed no longer experimental
 #553, Update:Podcast RSS feed modal warnings and note text

---
 client/components/modals/rssfeed/ViewModal.vue | 15 ++++++++++++++-
 client/pages/item/_id/index.vue                |  3 ++-
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/client/components/modals/rssfeed/ViewModal.vue b/client/components/modals/rssfeed/ViewModal.vue
index cc8240ac..56b036f5 100644
--- a/client/components/modals/rssfeed/ViewModal.vue
+++ b/client/components/modals/rssfeed/ViewModal.vue
@@ -18,12 +18,16 @@
       <div v-else class="w-full">
         <p class="text-lg font-semibold mb-4">Open RSS Feed</p>
 
-        <div class="w-full relative">
+        <div class="w-full relative mb-2">
           <ui-text-input-with-label v-model="newFeedSlug" label="RSS Feed Slug" />
           <p class="text-xs text-gray-400 py-0.5 px-1">Feed will be {{ demoFeedUrl }}</p>
         </div>
+
+        <p v-if="isHttp" class="w-full pt-2 text-warning text-xs">Warning: Most podcast apps will require the RSS feed URL is using HTTPS</p>
+        <p v-if="hasEpisodesWithoutPubDate" class="w-full pt-2 text-warning text-xs">Warning: 1 or more of your episodes do not have a Pub Date. Some podcast apps require this.</p>
       </div>
       <div v-show="userIsAdminOrUp" class="flex items-center pt-6">
+        <p class="text-xs text-gray-300">Note: RSS feed URLs are not authenticated</p>
         <div class="flex-grow" />
         <ui-btn v-if="currentFeedUrl" color="error" small @click="closeFeed">Close RSS Feed</ui-btn>
         <ui-btn v-else color="success" small @click="openFeed">Open RSS Feed</ui-btn>
@@ -85,6 +89,15 @@ export default {
     },
     demoFeedUrl() {
       return `${window.origin}/feed/${this.newFeedSlug}`
+    },
+    isHttp() {
+      return window.origin.startsWith('http://')
+    },
+    episodes() {
+      return this.media.episodes || []
+    },
+    hasEpisodesWithoutPubDate() {
+      return this.episodes.some((ep) => !ep.pubDate)
     }
   },
   methods: {
diff --git a/client/pages/item/_id/index.vue b/client/pages/item/_id/index.vue
index 473e32d8..1097de37 100644
--- a/client/pages/item/_id/index.vue
+++ b/client/pages/item/_id/index.vue
@@ -383,7 +383,8 @@ export default {
       return this.$store.getters['user/getUserCanDownload']
     },
     showRssFeedBtn() {
-      if (!this.showExperimentalFeatures) return false
+      if (!this.rssFeedUrl && !this.podcastEpisodes.length) return false // Cannot open RSS feed with no episodes
+
       // If rss feed is open then show feed url to users otherwise just show to admins
       return this.isPodcast && (this.userIsAdminOrUp || this.rssFeedUrl)
     }