Update:Support for ENV variables to disable SSRF request filter (DISABLE_SSRF_REQUEST_FILTER=1) #2549

server/Server.js

@@ -51,6 +51,7 @@ class Server {
     global.RouterBasePath = ROUTER_BASE_PATH
     global.XAccel = process.env.USE_X_ACCEL
     global.AllowCors = process.env.ALLOW_CORS === '1'
+    global.DisableSsrfRequestFilter = process.env.DISABLE_SSRF_REQUEST_FILTER === '1'
 
     if (!fs.pathExistsSync(global.ConfigPath)) {
       fs.mkdirSync(global.ConfigPath)

server/utils/fileUtils.js

@@ -7,13 +7,12 @@ const rra = require('../libs/recursiveReaddirAsync')
 const Logger = require('../Logger')
 const { AudioMimeType } = require('./constants')
 
-
 /**
-* Make sure folder separator is POSIX for Windows file paths. e.g. "C:\Users\Abs" becomes "C:/Users/Abs"
-*
-* @param {String} path - Ugly file path
-* @return {String} Pretty posix file path
-*/
+ * Make sure folder separator is POSIX for Windows file paths. e.g. "C:\Users\Abs" becomes "C:/Users/Abs"
+ *
+ * @param {String} path - Ugly file path
+ * @return {String} Pretty posix file path
+ */
 const filePathToPOSIX = (path) => {
   if (!global.isWin || !path) return path
   return path.replace(/\\/g, '/')
@@ -33,8 +32,8 @@ function isSameOrSubPath(parentPath, childPath) {
   if (parentPath === childPath) return true
   const relativePath = Path.relative(parentPath, childPath)
   return (
-    relativePath === '' // Same path (e.g. parentPath = '/a/b/', childPath = '/a/b')
-    || !relativePath.startsWith('..') && !Path.isAbsolute(relativePath) // Sub path
+    relativePath === '' || // Same path (e.g. parentPath = '/a/b/', childPath = '/a/b')
+    (!relativePath.startsWith('..') && !Path.isAbsolute(relativePath)) // Sub path
   )
 }
 module.exports.isSameOrSubPath = isSameOrSubPath
@@ -106,7 +105,10 @@ async function checkPathIsFile(filepath) {
 module.exports.checkPathIsFile = checkPathIsFile
 
 function getIno(path) {
-  return fs.stat(path, { bigint: true }).then((data => String(data.ino))).catch((err) => {
+  return fs
+    .stat(path, { bigint: true })
+    .then((data) => String(data.ino))
+    .catch((err) => {
       Logger.error('[Utils] Failed to get ino for path', path, err)
       return null
     })
@@ -177,7 +179,8 @@ async function recurseFiles(path, relPathToReplace = null) {
 
   const directoriesToIgnore = []
 
-  list = list.filter((item) => {
+  list = list
+    .filter((item) => {
       if (item.error) {
         Logger.error(`[fileUtils] Recurse files file "${item.fullname}" has error`, item.error)
         return false
@@ -201,21 +204,23 @@ async function recurseFiles(path, relPathToReplace = null) {
       }
 
       // Ignore any file if a directory or the filename starts with "."
-    if (relpath.split('/').find(p => p.startsWith('.'))) {
+      if (relpath.split('/').find((p) => p.startsWith('.'))) {
         Logger.debug(`[fileUtils] Ignoring path has . "${relpath}"`)
         return false
       }
 
       return true
-  }).filter(item => {
+    })
+    .filter((item) => {
       // Filter out items in ignore directories
-    if (directoriesToIgnore.some(dir => item.fullname.startsWith(dir))) {
+      if (directoriesToIgnore.some((dir) => item.fullname.startsWith(dir))) {
         Logger.debug(`[fileUtils] Ignoring path in dir with .ignore "${item.fullname}"`)
         return false
       }
       return true
-  }).map((item) => {
-    var isInRoot = (item.path + '/' === relPathToReplace)
+    })
+    .map((item) => {
+      var isInRoot = item.path + '/' === relPathToReplace
       return {
         name: item.name,
         path: item.fullname.replace(relPathToReplace, ''),
@@ -251,9 +256,10 @@ module.exports.downloadFile = (url, filepath, contentTypeFilter = null) => {
       method: 'GET',
       responseType: 'stream',
       timeout: 30000,
-      httpAgent: ssrfFilter(url),
-      httpsAgent: ssrfFilter(url)
-    }).then((response) => {
+      httpAgent: global.DisableSsrfRequestFilter ? null : ssrfFilter(feedUrl),
+      httpsAgent: global.DisableSsrfRequestFilter ? null : ssrfFilter(feedUrl)
+    })
+      .then((response) => {
         // Validate content type
         if (contentTypeFilter && !contentTypeFilter?.(response.headers?.['content-type'])) {
           return reject(new Error(`Invalid content type "${response.headers?.['content-type'] || ''}"`))
@@ -265,7 +271,8 @@ module.exports.downloadFile = (url, filepath, contentTypeFilter = null) => {
 
         writer.on('finish', resolve)
         writer.on('error', reject)
-    }).catch((err) => {
+      })
+      .catch((err) => {
         Logger.error(`[fileUtils] Failed to download file "${filepath}"`, err)
         reject(err)
       })
@@ -350,14 +357,17 @@ module.exports.getAudioMimeTypeFromExtname = (extname) => {
 
 module.exports.removeFile = (path) => {
   if (!path) return false
-  return fs.remove(path).then(() => true).catch((error) => {
+  return fs
+    .remove(path)
+    .then(() => true)
+    .catch((error) => {
       Logger.error(`[fileUtils] Failed remove file "${path}"`, error)
       return false
     })
 }
 
 module.exports.encodeUriPath = (path) => {
-  const uri = new URL('/', "file://")
+  const uri = new URL('/', 'file://')
   // we assign the path here to assure that URL control characters like # are
   // actually interpreted as part of the URL path
   uri.pathname = path
@@ -398,7 +408,11 @@ module.exports.getWindowsDrives = async () => {
         reject(error)
         return
       }
-      let drives = stdout?.split(/\r?\n/).map(line => line.trim()).filter(line => line).slice(1)
+      let drives = stdout
+        ?.split(/\r?\n/)
+        .map((line) => line.trim())
+        .filter((line) => line)
+        .slice(1)
       const validDrives = []
       for (const drive of drives) {
         let drivepath = drive + '/'
@@ -423,7 +437,8 @@ module.exports.getWindowsDrives = async () => {
 module.exports.getDirectoriesInPath = async (dirPath, level) => {
   try {
     const paths = await fs.readdir(dirPath)
-    let dirs = await Promise.all(paths.map(async dirname => {
+    let dirs = await Promise.all(
+      paths.map(async (dirname) => {
         const fullPath = Path.join(dirPath, dirname)
 
         const lstat = await fs.lstat(fullPath).catch((error) => {
@@ -437,8 +452,9 @@ module.exports.getDirectoriesInPath = async (dirPath, level) => {
           dirname,
           level
         }
-    }))
-    dirs = dirs.filter(d => d)
+      })
+    )
+    dirs = dirs.filter((d) => d)
     return dirs
   } catch (error) {
     Logger.error('Failed to readdir', dirPath, error)

server/utils/podcastUtils.js

@@ -234,10 +234,10 @@ module.exports.getPodcastFeed = (feedUrl, excludeEpisodeMetadata = false) => {
     timeout: 12000,
     responseType: 'arraybuffer',
     headers: { Accept: 'application/rss+xml, application/xhtml+xml, application/xml, */*;q=0.8' },
-    httpAgent: ssrfFilter(feedUrl),
-    httpsAgent: ssrfFilter(feedUrl)
-  }).then(async (data) => {
-
+    httpAgent: global.DisableSsrfRequestFilter ? null : ssrfFilter(feedUrl),
+    httpsAgent: global.DisableSsrfRequestFilter ? null : ssrfFilter(feedUrl)
+  })
+    .then(async (data) => {
       // Adding support for ios-8859-1 encoded RSS feeds.
       //  See: https://github.com/advplyr/audiobookshelf/issues/1489
       const contentType = data.headers?.['content-type'] || '' // e.g. text/xml; charset=iso-8859-1
@@ -261,7 +261,8 @@ module.exports.getPodcastFeed = (feedUrl, excludeEpisodeMetadata = false) => {
       payload.podcast.metadata.feedUrl = feedUrl
 
       return payload.podcast
-  }).catch((error) => {
+    })
+    .catch((error) => {
       Logger.error('[podcastUtils] getPodcastFeed Error', error)
       return null
     })
@@ -283,7 +284,7 @@ module.exports.findMatchingEpisodesInFeed = (feed, searchTitle) => {
   }
 
   const matches = []
-  feed.episodes.forEach(ep => {
+  feed.episodes.forEach((ep) => {
     if (!ep.title) return
 
     const epTitle = ep.title.toLowerCase().trim()