From a326a90417916223c7b93ce6456893a435411a92 Mon Sep 17 00:00:00 2001
From: Nicholas Wallace <nicholaslwallace@gmail.com>
Date: Sun, 17 Nov 2024 20:42:02 -0700
Subject: [PATCH] Add: check fields exist in `filterData`

---
 server/utils/queries/libraryFilters.js | 31 +++++++++++++++-----------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/server/utils/queries/libraryFilters.js b/server/utils/queries/libraryFilters.js
index 64ad07ee0..d0ebe7c3e 100644
--- a/server/utils/queries/libraryFilters.js
+++ b/server/utils/queries/libraryFilters.js
@@ -507,13 +507,15 @@ module.exports = {
       })
 
       if (changedPodcasts === 0) {
-        // If nothing has changed, check if the number of podcasts in
-        // library is still the same as prior check before updating cache creation time
-
-        if (podcastCountFromDatabase === Database.libraryFilterData[libraryId].podcastCount) {
-          Logger.debug(`Filter data for ${libraryId} has not changed, returning cached data and updating cache time after ${((Date.now() - start) / 1000).toFixed(2)}s`)
-          Database.libraryFilterData[libraryId].loadedAt = Date.now()
-          return cachedFilterData
+        // Verify that the count exists in the libraryFilterData object
+        if (Database.libraryFilterData[libraryId] && Database.libraryFilterData[libraryId].podcastCount) {
+          // If nothing has changed, check if the number of podcasts in
+          // library is still the same as prior check before updating cache creation time
+          if (podcastCountFromDatabase === Database.libraryFilterData[libraryId].podcastCount) {
+            Logger.debug(`Filter data for ${libraryId} has not changed, returning cached data and updating cache time after ${((Date.now() - start) / 1000).toFixed(2)}s`)
+            Database.libraryFilterData[libraryId].loadedAt = Date.now()
+            return cachedFilterData
+          }
         }
       }
 
@@ -611,12 +613,15 @@ module.exports = {
       })
 
       if (changedBooks + changedSeries + changedAuthors === 0) {
-        // If nothing has changed, check if the number of authors, series, and books
-        // matches the prior check before updating cache creation time
-        if (bookCountFromDatabase === Database.libraryFilterData[libraryId].bookCount && seriesCountFromDatabase === Database.libraryFilterData[libraryId].seriesCount && authorCountFromDatabase === Database.libraryFilterData[libraryId].authorCount) {
-          Logger.debug(`Filter data for ${libraryId} has not changed, returning cached data and updating cache time after ${((Date.now() - start) / 1000).toFixed(2)}s`)
-          Database.libraryFilterData[libraryId].loadedAt = Date.now()
-          return cachedFilterData
+        // Verify that the counts exist in the libraryFilterData object
+        if (Database.libraryFilterData[libraryId] && Database.libraryFilterData[libraryId].bookCount && Database.libraryFilterData[libraryId].seriesCount && Database.libraryFilterData[libraryId].authorCount) {
+          // If nothing has changed, check if the number of authors, series, and books
+          // matches the prior check before updating cache creation time
+          if (bookCountFromDatabase === Database.libraryFilterData[libraryId].bookCount && seriesCountFromDatabase === Database.libraryFilterData[libraryId].seriesCount && authorCountFromDatabase === Database.libraryFilterData[libraryId].authorCount) {
+            Logger.debug(`Filter data for ${libraryId} has not changed, returning cached data and updating cache time after ${((Date.now() - start) / 1000).toFixed(2)}s`)
+            Database.libraryFilterData[libraryId].loadedAt = Date.now()
+            return cachedFilterData
+          }
         }
       }