Mirrors/audiobookshelf
Mirrors/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2025-01-03 00:06:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

Respond with bad request to unvalid request data

Browse Source 
This patch updates the batch progress update endpoint to respond with a
`400 Bad Request` instead of a `500 Internal Server Error` if a user
sends an invalid request with no body. This is a user error after all.

```
❯ curl -i -X PATCH \
  'http://127.0.0.1:3333/api/me/progress/batch/update' \
  -H 'Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5Q_MoRptP0oI' \
  -H 'Content-Type: application/json'
HTTP/1.1 400 Bad Request
…

Missing request payload
```
This commit is contained in:
Lars Kiesow 2022-11-23 02:15:36 +01:00
parent c285dd666d
commit a8162b57ba
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/controllers/MeController.js
View File

@ -91,7 +91,7 @@ class MeController {
async batchUpdateMediaProgress(req, res) { async batchUpdateMediaProgress(req, res) {
var itemProgressPayloads = req.body var itemProgressPayloads = req.body
if (!itemProgressPayloads || !itemProgressPayloads.length) { if (!itemProgressPayloads || !itemProgressPayloads.length) {
return res.sendStatus(500) return res.status(400).send('Missing request payload')
} }
var shouldUpdate = false var shouldUpdate = false