From 75007bb371ff7403fdb895268e1cffc7d3c01695 Mon Sep 17 00:00:00 2001 From: Nicholas Wallace Date: Thu, 11 Apr 2024 01:28:40 +0000 Subject: [PATCH 1/5] Fix: i18n-integration not running on PRs --- .github/workflows/i18n-integration.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/i18n-integration.yml b/.github/workflows/i18n-integration.yml index cee07b20..87dcd195 100644 --- a/.github/workflows/i18n-integration.yml +++ b/.github/workflows/i18n-integration.yml @@ -1,6 +1,9 @@ name: Verify all i18n files are alphabetized on: + pull_request: + paths: + - client/strings/** # Should only check if any strings changed push: paths: - client/strings/** # Should only check if any strings changed From 6ed6fff6bdbb1f225e2f031b2597095d1456372a Mon Sep 17 00:00:00 2001 From: Nicholas Wallace Date: Thu, 11 Apr 2024 01:29:00 +0000 Subject: [PATCH 2/5] Update i18n workflow to 1.2.0 --- .github/workflows/i18n-integration.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/i18n-integration.yml b/.github/workflows/i18n-integration.yml index 87dcd195..12d82c3e 100644 --- a/.github/workflows/i18n-integration.yml +++ b/.github/workflows/i18n-integration.yml @@ -25,6 +25,6 @@ jobs: # The only argument is the `directory`, which is where the i18n files are # stored. - name: Run Update JSON Files action - uses: audiobookshelf/audiobookshelf-i18n-updater@v1.1.1 + uses: audiobookshelf/audiobookshelf-i18n-updater@v1.2.0 with: directory: "client/strings/" # Adjust the directory path as needed From 9a0b8de354cb6cdcfcdb6691579ae81740fc41dc Mon Sep 17 00:00:00 2001 From: Nicholas Wallace Date: Thu, 11 Apr 2024 01:31:22 +0000 Subject: [PATCH 3/5] Example: bad key in `es.json` --- client/strings/es.json | 1 + 1 file changed, 1 insertion(+) diff --git a/client/strings/es.json b/client/strings/es.json index 1b0bfbec..a7080739 100644 --- a/client/strings/es.json +++ b/client/strings/es.json @@ -8,6 +8,7 @@ "ButtonAddYourFirstLibrary": "Crea tu Primera Biblioteca", "ButtonApply": "Aplicar", "ButtonApplyChapters": "Aplicar Capítulos", + "Button ApplyChapters": "Aplicar Capítulos", "ButtonAuthors": "Autores", "ButtonBrowseForFolder": "Buscar por Carpeta", "ButtonCancel": "Cancelar", From f702358bbdecfcb822493419c407fe5eb24caaec Mon Sep 17 00:00:00 2001 From: Nicholas Wallace Date: Thu, 11 Apr 2024 01:33:38 +0000 Subject: [PATCH 4/5] Example: missing key in `es.json` --- client/strings/es.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/client/strings/es.json b/client/strings/es.json index a7080739..a725cd85 100644 --- a/client/strings/es.json +++ b/client/strings/es.json @@ -8,7 +8,6 @@ "ButtonAddYourFirstLibrary": "Crea tu Primera Biblioteca", "ButtonApply": "Aplicar", "ButtonApplyChapters": "Aplicar Capítulos", - "Button ApplyChapters": "Aplicar Capítulos", "ButtonAuthors": "Autores", "ButtonBrowseForFolder": "Buscar por Carpeta", "ButtonCancel": "Cancelar", @@ -779,5 +778,6 @@ "ToastSocketDisconnected": "Socket desconectado", "ToastSocketFailedToConnect": "Error al conectar al Socket", "ToastUserDeleteFailed": "Error al eliminar el usuario", - "ToastUserDeleteSuccess": "Usuario eliminado" + "ToastUserDeleteSuccess": "Usuario eliminado", + "ZZZZ": "example" } \ No newline at end of file From 9e1686232bde7d3820c3973e3fbe0133b3ed9bef Mon Sep 17 00:00:00 2001 From: Nicholas Wallace Date: Thu, 11 Apr 2024 01:34:32 +0000 Subject: [PATCH 5/5] Example: `es.json` is fixed --- client/strings/es.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/client/strings/es.json b/client/strings/es.json index a725cd85..1b0bfbec 100644 --- a/client/strings/es.json +++ b/client/strings/es.json @@ -778,6 +778,5 @@ "ToastSocketDisconnected": "Socket desconectado", "ToastSocketFailedToConnect": "Error al conectar al Socket", "ToastUserDeleteFailed": "Error al eliminar el usuario", - "ToastUserDeleteSuccess": "Usuario eliminado", - "ZZZZ": "example" + "ToastUserDeleteSuccess": "Usuario eliminado" } \ No newline at end of file