From d9c9289d655f6050e1db97c62a62944eaf5591e9 Mon Sep 17 00:00:00 2001
From: Kieran Eglin <kieran.eglin@gmail.com>
Date: Tue, 28 Nov 2023 12:11:14 -0800
Subject: [PATCH] Added error handling; Made querystring helper

---
 client/components/cards/ItemUploadCard.vue | 27 +++++++++++++++-------
 client/mixins/apiRequestHelpers.js         | 12 ++++++++++
 client/strings/en-us.json                  |  3 +++
 3 files changed, 34 insertions(+), 8 deletions(-)
 create mode 100644 client/mixins/apiRequestHelpers.js

diff --git a/client/components/cards/ItemUploadCard.vue b/client/components/cards/ItemUploadCard.vue
index a393a170..4a40f2b7 100644
--- a/client/components/cards/ItemUploadCard.vue
+++ b/client/components/cards/ItemUploadCard.vue
@@ -65,8 +65,10 @@
 
 <script>
 import Path from 'path'
+import apiRequestHelpers from '@/mixins/apiRequestHelpers'
 
 export default {
+  mixins: [apiRequestHelpers],
   props: {
     item: {
       type: Object,
@@ -132,27 +134,36 @@ export default {
       }
 
       this.isFetchingMetadata = true
+      this.error = ''
 
       try {
-        const searchQueryString = `title=${this.itemData.title}&author=${this.itemData.author}&provider=${this.provider}`
+        const searchQueryString = this.buildQuerystring({
+          title: this.itemData.title,
+          author: this.itemData.author,
+          provider: this.provider
+        })
         const [bestCandidate, ..._rest] = await this.$axios.$get(`/api/search/books?${searchQueryString}`)
 
-        this.itemData = {
-          ...this.itemData,
-          title: bestCandidate?.title,
-          author: bestCandidate?.author,
-          series: (bestCandidate?.series || [])[0]?.series
+        if (bestCandidate) {
+          this.itemData = {
+            ...this.itemData,
+            title: bestCandidate?.title,
+            author: bestCandidate?.author,
+            series: (bestCandidate?.series || [])[0]?.series
+          }
+        } else {
+          this.error = this.$strings.ErrorUploadFetchMetadataNoResults
         }
       } catch (e) {
         console.error('Failed', e)
-        // TODO: do something with the error?
+        this.error = this.$strings.ErrorUploadFetchMetadataAPI
       } finally {
         this.isFetchingMetadata = false
       }
     },
     getData() {
       if (!this.itemData.title) {
-        this.error = 'Must have a title'
+        this.error = this.$strings.ErrorUploadLacksTitle
         return null
       }
       this.error = ''
diff --git a/client/mixins/apiRequestHelpers.js b/client/mixins/apiRequestHelpers.js
new file mode 100644
index 00000000..41a28b4d
--- /dev/null
+++ b/client/mixins/apiRequestHelpers.js
@@ -0,0 +1,12 @@
+export default {
+  methods: {
+    buildQuerystring(obj, opts = { includePrefix: false }) {
+      let querystring = Object
+        .entries(obj)
+        .map(([key, val]) => `${encodeURIComponent(key)}=${encodeURIComponent(val)}`)
+        .join('&')
+
+      return (opts.includePrefix ? '?' : '').concat(querystring)
+    }
+  }
+}
diff --git a/client/strings/en-us.json b/client/strings/en-us.json
index 5b73de36..857627e9 100644
--- a/client/strings/en-us.json
+++ b/client/strings/en-us.json
@@ -87,6 +87,9 @@
   "ButtonUserEdit": "Edit user {0}",
   "ButtonViewAll": "View All",
   "ButtonYes": "Yes",
+  "ErrorUploadFetchMetadataAPI": "Error fetching metadata",
+  "ErrorUploadFetchMetadataNoResults": "Could not fetch metadata - try updating title and/or author",
+  "ErrorUploadLacksTitle": "Must have a title",
   "HeaderAccount": "Account",
   "HeaderAdvanced": "Advanced",
   "HeaderAppriseNotificationSettings": "Apprise Notification Settings",