* Fix difficulty overwriting export name

* Fix NaN for score selector
This commit is contained in:
Nicolas Mowen 2024-08-13 09:12:06 -06:00 committed by GitHub
parent b0d42ea116
commit 1b876bf8d3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 17 deletions

View File

@ -44,7 +44,7 @@ export default function ExportCard({
const [editName, setEditName] = useState<{ const [editName, setEditName] = useState<{
original: string; original: string;
update: string; update?: string;
}>(); }>();
const submitRename = useCallback(() => { const submitRename = useCallback(() => {
@ -52,7 +52,7 @@ export default function ExportCard({
return; return;
} }
onRename(exportedRecording.id, editName.update); onRename(exportedRecording.id, editName.update ?? "");
setEditName(undefined); setEditName(undefined);
}, [editName, exportedRecording, onRename, setEditName]); }, [editName, exportedRecording, onRename, setEditName]);
@ -64,7 +64,7 @@ export default function ExportCard({
modifiers.down && modifiers.down &&
!modifiers.repeat && !modifiers.repeat &&
editName && editName &&
editName.update.length > 0 (editName.update?.length ?? 0) > 0
) { ) {
submitRename(); submitRename();
} }
@ -92,7 +92,11 @@ export default function ExportCard({
className="mt-3" className="mt-3"
type="search" type="search"
placeholder={editName?.original} placeholder={editName?.original}
value={editName?.update || editName?.original} value={
editName?.update == undefined
? editName?.original
: editName?.update
}
onChange={(e) => onChange={(e) =>
setEditName({ setEditName({
original: editName.original ?? "", original: editName.original ?? "",
@ -159,7 +163,7 @@ export default function ExportCard({
onClick={() => onClick={() =>
setEditName({ setEditName({
original: exportedRecording.name, original: exportedRecording.name,
update: "", update: undefined,
}) })
} }
> >

View File

@ -494,12 +494,16 @@ function PlusFilterGroup({
className="w-12" className="w-12"
inputMode="numeric" inputMode="numeric"
value={Math.round((currentScoreRange?.at(0) ?? 0.5) * 100)} value={Math.round((currentScoreRange?.at(0) ?? 0.5) * 100)}
onChange={(e) => onChange={(e) => {
setCurrentScoreRange([ const value = e.target.value;
parseInt(e.target.value) / 100.0,
currentScoreRange?.at(1) ?? 1.0, if (value) {
]) setCurrentScoreRange([
} parseInt(value) / 100.0,
currentScoreRange?.at(1) ?? 1.0,
]);
}
}}
/> />
<DualThumbSlider <DualThumbSlider
className="w-full" className="w-full"
@ -513,12 +517,16 @@ function PlusFilterGroup({
className="w-12" className="w-12"
inputMode="numeric" inputMode="numeric"
value={Math.round((currentScoreRange?.at(1) ?? 1.0) * 100)} value={Math.round((currentScoreRange?.at(1) ?? 1.0) * 100)}
onChange={(e) => onChange={(e) => {
setCurrentScoreRange([ const value = e.target.value;
currentScoreRange?.at(0) ?? 0.5,
parseInt(e.target.value) / 100.0, if (value) {
]) setCurrentScoreRange([
} currentScoreRange?.at(0) ?? 0.5,
parseInt(value) / 100.0,
]);
}
}}
/> />
</div> </div>
<DropdownMenuSeparator /> <DropdownMenuSeparator />