From 292499aebc934f4e08168d82ae6d4665af44ac28 Mon Sep 17 00:00:00 2001 From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com> Date: Mon, 16 Dec 2024 10:18:34 -0600 Subject: [PATCH] Improve review message again (#15538) --- .../overlay/detail/ReviewDetailDialog.tsx | 22 ++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/web/src/components/overlay/detail/ReviewDetailDialog.tsx b/web/src/components/overlay/detail/ReviewDetailDialog.tsx index d3c8864b7..8d2f13d89 100644 --- a/web/src/components/overlay/detail/ReviewDetailDialog.tsx +++ b/web/src/components/overlay/detail/ReviewDetailDialog.tsx @@ -280,12 +280,24 @@ export default function ReviewDetailDialog({ {hasMismatch && (
- Some objects may have been detected in this review item that - did not qualify as an alert or detection. Adjust your - configuration if you want Frigate to save tracked objects for - any missing labels. + {(() => { + const detectedCount = Math.abs( + (events?.length ?? 0) - + (review?.data.detections.length ?? 0), + ); + const objectLabel = + detectedCount === 1 ? "object was" : "objects were"; + + return `${detectedCount} unavailable ${objectLabel} detected and included in this review item.`; + })()}{" "} + Those objects either did not qualify as an alert or detection + or have already been cleaned up/deleted. {missingObjects.length > 0 && ( -
{missingObjects.join(", ")}
+
+ Adjust your configuration if you want Frigate to save + tracked objects for the following labels:{" "} + {missingObjects.join(", ")} +
)}
)}