clean up unneeded code (#11587)

This commit is contained in:
Josh Hawkins 2024-05-28 09:05:04 -05:00 committed by GitHub
parent 4165639308
commit 2fda383782
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -225,7 +225,7 @@ export default function LiveCameraView({
} }
}, [camera, fullResolution]); }, [camera, fullResolution]);
const aspectRatio = useMemo<number>(() => { const constrainedAspectRatio = useMemo<number>(() => {
if (isMobile || fullscreen) { if (isMobile || fullscreen) {
return cameraAspectRatio; return cameraAspectRatio;
} else { } else {
@ -236,18 +236,11 @@ export default function LiveCameraView({
}, [cameraAspectRatio, containerAspectRatio, fullscreen]); }, [cameraAspectRatio, containerAspectRatio, fullscreen]);
const growClassName = useMemo(() => { const growClassName = useMemo(() => {
let aspect;
if (fullResolution.width && fullResolution.height) {
aspect = fullResolution.width / fullResolution.height;
} else {
aspect = camera.detect.width / camera.detect.height;
}
if (isMobile) { if (isMobile) {
if (isPortrait) { if (isPortrait) {
return "absolute left-0.5 right-0.5 top-[50%] -translate-y-[50%]"; return "absolute left-0.5 right-0.5 top-[50%] -translate-y-[50%]";
} else { } else {
if (aspect > containerAspectRatio) { if (cameraAspectRatio > containerAspectRatio) {
return "p-2 absolute left-0 top-[50%] -translate-y-[50%]"; return "p-2 absolute left-0 top-[50%] -translate-y-[50%]";
} else { } else {
return "p-2 absolute top-0.5 bottom-0.5 left-[50%] -translate-x-[50%]"; return "p-2 absolute top-0.5 bottom-0.5 left-[50%] -translate-x-[50%]";
@ -256,7 +249,7 @@ export default function LiveCameraView({
} }
if (fullscreen) { if (fullscreen) {
if (aspect > containerAspectRatio) { if (cameraAspectRatio > containerAspectRatio) {
return "absolute inset-x-2 top-[50%] -translate-y-[50%]"; return "absolute inset-x-2 top-[50%] -translate-y-[50%]";
} else { } else {
return "absolute inset-y-2 left-[50%] -translate-x-[50%]"; return "absolute inset-y-2 left-[50%] -translate-x-[50%]";
@ -264,7 +257,7 @@ export default function LiveCameraView({
} else { } else {
return "absolute top-0.5 bottom-0.5 left-[50%] -translate-x-[50%]"; return "absolute top-0.5 bottom-0.5 left-[50%] -translate-x-[50%]";
} }
}, [camera, fullscreen, isPortrait, fullResolution, containerAspectRatio]); }, [fullscreen, isPortrait, cameraAspectRatio, containerAspectRatio]);
return ( return (
<TransformWrapper minScale={1.0}> <TransformWrapper minScale={1.0}>
@ -398,7 +391,7 @@ export default function LiveCameraView({
ref={clickOverlayRef} ref={clickOverlayRef}
onClick={handleOverlayClick} onClick={handleOverlayClick}
style={{ style={{
aspectRatio: aspectRatio, aspectRatio: constrainedAspectRatio,
}} }}
> >
<LivePlayer <LivePlayer