From 4a5fe4138e206fe425bfccaafa61910e297035bd Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Sun, 1 Dec 2024 12:08:03 -0600
Subject: [PATCH] Explore audio event tweaks (#15291)

---
 .../components/menu/SearchResultActions.tsx   |  39 +++---
 .../overlay/detail/SearchDetailDialog.tsx     | 120 +++++++++---------
 2 files changed, 82 insertions(+), 77 deletions(-)

diff --git a/web/src/components/menu/SearchResultActions.tsx b/web/src/components/menu/SearchResultActions.tsx
index 277ce2169..fee12a50f 100644
--- a/web/src/components/menu/SearchResultActions.tsx
+++ b/web/src/components/menu/SearchResultActions.tsx
@@ -108,13 +108,15 @@ export default function SearchResultActions({
           </a>
         </MenuItem>
       )}
-      <MenuItem
-        aria-label="Show the object lifecycle"
-        onClick={showObjectLifecycle}
-      >
-        <FaArrowsRotate className="mr-2 size-4" />
-        <span>View object lifecycle</span>
-      </MenuItem>
+      {searchResult.data.type == "object" && (
+        <MenuItem
+          aria-label="Show the object lifecycle"
+          onClick={showObjectLifecycle}
+        >
+          <FaArrowsRotate className="mr-2 size-4" />
+          <span>View object lifecycle</span>
+        </MenuItem>
+      )}
       {config?.semantic_search?.enabled && isContextMenu && (
         <MenuItem
           aria-label="Find similar tracked objects"
@@ -182,17 +184,18 @@ export default function SearchResultActions({
         </ContextMenu>
       ) : (
         <>
-          {config?.semantic_search?.enabled && (
-            <Tooltip>
-              <TooltipTrigger>
-                <MdImageSearch
-                  className="size-5 cursor-pointer text-primary-variant hover:text-primary"
-                  onClick={findSimilar}
-                />
-              </TooltipTrigger>
-              <TooltipContent>Find similar</TooltipContent>
-            </Tooltip>
-          )}
+          {config?.semantic_search?.enabled &&
+            searchResult.data.type == "object" && (
+              <Tooltip>
+                <TooltipTrigger>
+                  <MdImageSearch
+                    className="size-5 cursor-pointer text-primary-variant hover:text-primary"
+                    onClick={findSimilar}
+                  />
+                </TooltipTrigger>
+                <TooltipContent>Find similar</TooltipContent>
+              </Tooltip>
+            )}
 
           {!isMobileOnly &&
             config?.plus?.enabled &&
diff --git a/web/src/components/overlay/detail/SearchDetailDialog.tsx b/web/src/components/overlay/detail/SearchDetailDialog.tsx
index f63dffcc1..b0eeac98d 100644
--- a/web/src/components/overlay/detail/SearchDetailDialog.tsx
+++ b/web/src/components/overlay/detail/SearchDetailDialog.tsx
@@ -452,7 +452,7 @@ function ObjectDetailsTab({
             draggable={false}
             src={`${apiHost}api/events/${search.id}/thumbnail.jpg`}
           />
-          {config?.semantic_search.enabled && (
+          {config?.semantic_search.enabled && search.data.type == "object" && (
             <Button
               aria-label="Find similar tracked objects"
               onClick={() => {
@@ -626,65 +626,67 @@ export function ObjectSnapshotTab({
                 </div>
               )}
             </TransformComponent>
-            {search.data.type == "object" && search.plus_id !== "not_enabled" && search.end_time && (
-              <Card className="p-1 text-sm md:p-2">
-                <CardContent className="flex flex-col items-center justify-between gap-3 p-2 md:flex-row">
-                  <div className={cn("flex flex-col space-y-3")}>
-                    <div
-                      className={
-                        "text-lg font-semibold leading-none tracking-tight"
-                      }
-                    >
-                      Submit To Frigate+
-                    </div>
-                    <div className="text-sm text-muted-foreground">
-                      Objects in locations you want to avoid are not false
-                      positives. Submitting them as false positives will confuse
-                      the model.
-                    </div>
-                  </div>
-
-                  <div className="flex flex-row justify-center gap-2 md:justify-end">
-                    {state == "reviewing" && (
-                      <>
-                        <Button
-                          className="bg-success"
-                          aria-label="Confirm this label for Frigate Plus"
-                          onClick={() => {
-                            setState("uploading");
-                            onSubmitToPlus(false);
-                          }}
-                        >
-                          This is{" "}
-                          {/^[aeiou]/i.test(search?.label || "") ? "an" : "a"}{" "}
-                          {search?.label}
-                        </Button>
-                        <Button
-                          className="text-white"
-                          aria-label="Do not confirm this label for Frigate Plus"
-                          variant="destructive"
-                          onClick={() => {
-                            setState("uploading");
-                            onSubmitToPlus(true);
-                          }}
-                        >
-                          This is not{" "}
-                          {/^[aeiou]/i.test(search?.label || "") ? "an" : "a"}{" "}
-                          {search?.label}
-                        </Button>
-                      </>
-                    )}
-                    {state == "uploading" && <ActivityIndicator />}
-                    {state == "submitted" && (
-                      <div className="flex flex-row items-center justify-center gap-2">
-                        <FaCheckCircle className="text-success" />
-                        Submitted
+            {search.data.type == "object" &&
+              search.plus_id !== "not_enabled" &&
+              search.end_time && (
+                <Card className="p-1 text-sm md:p-2">
+                  <CardContent className="flex flex-col items-center justify-between gap-3 p-2 md:flex-row">
+                    <div className={cn("flex flex-col space-y-3")}>
+                      <div
+                        className={
+                          "text-lg font-semibold leading-none tracking-tight"
+                        }
+                      >
+                        Submit To Frigate+
                       </div>
-                    )}
-                  </div>
-                </CardContent>
-              </Card>
-            )}
+                      <div className="text-sm text-muted-foreground">
+                        Objects in locations you want to avoid are not false
+                        positives. Submitting them as false positives will
+                        confuse the model.
+                      </div>
+                    </div>
+
+                    <div className="flex flex-row justify-center gap-2 md:justify-end">
+                      {state == "reviewing" && (
+                        <>
+                          <Button
+                            className="bg-success"
+                            aria-label="Confirm this label for Frigate Plus"
+                            onClick={() => {
+                              setState("uploading");
+                              onSubmitToPlus(false);
+                            }}
+                          >
+                            This is{" "}
+                            {/^[aeiou]/i.test(search?.label || "") ? "an" : "a"}{" "}
+                            {search?.label}
+                          </Button>
+                          <Button
+                            className="text-white"
+                            aria-label="Do not confirm this label for Frigate Plus"
+                            variant="destructive"
+                            onClick={() => {
+                              setState("uploading");
+                              onSubmitToPlus(true);
+                            }}
+                          >
+                            This is not{" "}
+                            {/^[aeiou]/i.test(search?.label || "") ? "an" : "a"}{" "}
+                            {search?.label}
+                          </Button>
+                        </>
+                      )}
+                      {state == "uploading" && <ActivityIndicator />}
+                      {state == "submitted" && (
+                        <div className="flex flex-row items-center justify-center gap-2">
+                          <FaCheckCircle className="text-success" />
+                          Submitted
+                        </div>
+                      )}
+                    </div>
+                  </CardContent>
+                </Card>
+              )}
           </div>
         </TransformWrapper>
       </div>