* Don't require previews to show motion ui

* Fix recording text to match hls player logic
This commit is contained in:
Nicolas Mowen 2024-07-21 13:14:59 -06:00 committed by GitHub
parent 29345c429a
commit 68e6ffdfef
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions

View File

@ -238,7 +238,7 @@ export default function DynamicVideoPlayer({
{!isScrubbing && (isLoading || isBuffering) && !noRecording && ( {!isScrubbing && (isLoading || isBuffering) && !noRecording && (
<ActivityIndicator className="absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2" /> <ActivityIndicator className="absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2" />
)} )}
{!isScrubbing && noRecording && ( {!isScrubbing && !isLoading && noRecording && (
<div className="absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2"> <div className="absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2">
No recordings found for this time No recordings found for this time
</div> </div>

View File

@ -957,7 +957,7 @@ function MotionReview({
); );
} }
if (!relevantPreviews) { if (relevantPreviews == undefined) {
return <ActivityIndicator />; return <ActivityIndicator />;
} }
@ -999,7 +999,7 @@ function MotionReview({
camera={camera.name} camera={camera.name}
timeRange={currentTimeRange} timeRange={currentTimeRange}
startTime={previewStart} startTime={previewStart}
cameraPreviews={relevantPreviews || []} cameraPreviews={relevantPreviews}
isScrubbing={scrubbing} isScrubbing={scrubbing}
onControllerReady={(controller) => { onControllerReady={(controller) => {
videoPlayersRef.current[camera.name] = controller; videoPlayersRef.current[camera.name] = controller;