From 6dd6ca5de596ae6071f3c01ed97119e03fcd7af2 Mon Sep 17 00:00:00 2001
From: Nicolas Mowen <nickmowen213@gmail.com>
Date: Mon, 25 Mar 2024 14:56:13 -0600
Subject: [PATCH] Only allow visible cameras to go live on dashboard (#10671)

* Only show live cameras that are currently visible

* Add back black background

* fix
---
 web/src/components/player/LivePlayer.tsx    | 17 ++++---
 web/src/components/player/PreviewPlayer.tsx |  6 +--
 web/src/views/live/LiveDashboardView.tsx    | 54 ++++++++++++++++++++-
 3 files changed, 64 insertions(+), 13 deletions(-)

diff --git a/web/src/components/player/LivePlayer.tsx b/web/src/components/player/LivePlayer.tsx
index 8be3f71b9..a8fe5d3b1 100644
--- a/web/src/components/player/LivePlayer.tsx
+++ b/web/src/components/player/LivePlayer.tsx
@@ -10,10 +10,10 @@ import { useCameraActivity } from "@/hooks/use-camera-activity";
 import { useRecordingsState } from "@/api/ws";
 import { LivePlayerMode } from "@/types/live";
 import useCameraLiveMode from "@/hooks/use-camera-live-mode";
-import { isDesktop } from "react-device-detect";
 import CameraActivityIndicator from "../indicators/CameraActivityIndicator";
 
 type LivePlayerProps = {
+  cameraRef?: (ref: HTMLDivElement | null) => void;
   className?: string;
   cameraConfig: CameraConfig;
   preferredLiveMode?: LivePlayerMode;
@@ -26,6 +26,7 @@ type LivePlayerProps = {
 };
 
 export default function LivePlayer({
+  cameraRef = undefined,
   className,
   cameraConfig,
   preferredLiveMode,
@@ -140,6 +141,8 @@ export default function LivePlayer({
 
   return (
     <div
+      ref={cameraRef}
+      data-camera={cameraConfig.name}
       className={`relative flex justify-center ${liveMode == "jsmpeg" ? "size-full" : "w-full"} outline cursor-pointer ${
         activeTracking
           ? "outline-severity_alert outline-3 rounded-2xl shadow-severity_alert"
@@ -171,13 +174,11 @@ export default function LivePlayer({
         )}
       </div>
 
-      {isDesktop && (
-        <div className="absolute right-2 top-2 size-4">
-          {recording == "ON" && (
-            <MdCircle className="size-2 drop-shadow-md shadow-danger text-danger animate-pulse" />
-          )}
-        </div>
-      )}
+      <div className="absolute right-2 top-2 size-4">
+        {recording == "ON" && (
+          <MdCircle className="size-2 drop-shadow-md shadow-danger text-danger animate-pulse" />
+        )}
+      </div>
     </div>
   );
 }
diff --git a/web/src/components/player/PreviewPlayer.tsx b/web/src/components/player/PreviewPlayer.tsx
index 197986677..76a16fe9d 100644
--- a/web/src/components/player/PreviewPlayer.tsx
+++ b/web/src/components/player/PreviewPlayer.tsx
@@ -234,7 +234,7 @@ function PreviewVideoPlayer({
 
   return (
     <div
-      className={`relative w-full rounded-2xl overflow-hidden ${className ?? ""} ${onClick ? "cursor-pointer" : ""}`}
+      className={`relative w-full rounded-2xl bg-black overflow-hidden ${className ?? ""} ${onClick ? "cursor-pointer" : ""}`}
       onClick={onClick}
     >
       {currentHourFrame && (
@@ -247,7 +247,7 @@ function PreviewVideoPlayer({
         ref={canvasRef}
         width={videoWidth}
         height={videoHeight}
-        className={`absolute h-full left-1/2 -translate-x-1/2 bg-black ${!loaded && hasCanvas ? "" : "hidden"}`}
+        className={`absolute h-full left-1/2 -translate-x-1/2 ${!loaded && hasCanvas ? "" : "hidden"}`}
       />
       <video
         ref={previewRef}
@@ -281,7 +281,7 @@ function PreviewVideoPlayer({
         <Skeleton className="absolute inset-0" />
       )}
       {cameraPreviews && !currentPreview && (
-        <div className="absolute inset-0 bg-black text-white rounded-2xl flex justify-center items-center">
+        <div className="absolute inset-0 text-white rounded-2xl flex justify-center items-center">
           No Preview Found
         </div>
       )}
diff --git a/web/src/views/live/LiveDashboardView.tsx b/web/src/views/live/LiveDashboardView.tsx
index d5a7401c5..649e102b5 100644
--- a/web/src/views/live/LiveDashboardView.tsx
+++ b/web/src/views/live/LiveDashboardView.tsx
@@ -11,7 +11,7 @@ import { TooltipProvider } from "@/components/ui/tooltip";
 import { usePersistence } from "@/hooks/use-persistence";
 import { CameraConfig, FrigateConfig } from "@/types/frigateConfig";
 import { ReviewSegment } from "@/types/review";
-import { useCallback, useEffect, useMemo, useState } from "react";
+import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import { isDesktop, isMobile, isSafari } from "react-device-detect";
 import useSWR from "swr";
 
@@ -79,6 +79,53 @@ export default function LiveDashboardView({
     };
   }, [visibilityListener]);
 
+  const [visibleCameras, setVisibleCameras] = useState<string[]>([]);
+  const visibleCameraObserver = useRef<IntersectionObserver | null>(null);
+  useEffect(() => {
+    const visibleCameras = new Set<string>();
+    visibleCameraObserver.current = new IntersectionObserver(
+      (entries) => {
+        entries.forEach((entry) => {
+          const camera = (entry.target as HTMLElement).dataset.camera;
+
+          if (!camera) {
+            return;
+          }
+
+          if (entry.isIntersecting) {
+            visibleCameras.add(camera);
+          } else {
+            visibleCameras.delete(camera);
+          }
+
+          setVisibleCameras([...visibleCameras]);
+        });
+      },
+      { threshold: 0.5 },
+    );
+
+    return () => {
+      visibleCameraObserver.current?.disconnect();
+    };
+  }, []);
+
+  const cameraRef = useCallback(
+    (node: HTMLElement | null) => {
+      if (!visibleCameraObserver.current) {
+        return;
+      }
+
+      try {
+        if (node) visibleCameraObserver.current.observe(node);
+      } catch (e) {
+        // no op
+      }
+    },
+    // we need to listen on the value of the ref
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [visibleCameraObserver.current],
+  );
+
   const birdseyeConfig = useMemo(() => config?.birdseye, [config]);
 
   return (
@@ -149,9 +196,12 @@ export default function LiveDashboardView({
           }
           return (
             <LivePlayer
+              cameraRef={cameraRef}
               key={camera.name}
               className={grow}
-              windowVisible={windowVisible}
+              windowVisible={
+                windowVisible && visibleCameras.includes(camera.name)
+              }
               cameraConfig={camera}
               preferredLiveMode={isSafari ? "webrtc" : "mse"}
               onClick={() => onSelectCamera(camera.name)}