Mirrors/blakeblackshear.frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2025-02-05 00:15:51 +01:00
Code Issues Projects Releases Wiki Activity

Consider pre and post capture when cleaning up recordings based on review segments (#16096)

Browse Source
This commit is contained in:
Nicolas Mowen 2025-01-23 07:26:53 -07:00 committed by GitHub
parent aedfaa3641
commit 776bb79f0b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
frigate/record/cleanup.py
View File

@ -121,22 +121,29 @@ class RecordingCleanup(threading.Thread):
review_start = 0 review_start = 0
deleted_recordings = set() deleted_recordings = set()
kept_recordings: list[tuple[float, float]] = [] kept_recordings: list[tuple[float, float]] = []
recording: Recordings
for recording in recordings: for recording in recordings:
keep = False keep = False
mode = None mode = None
# Now look for a reason to keep this recording segment # Now look for a reason to keep this recording segment
for idx in range(review_start, len(reviews)): for idx in range(review_start, len(reviews)):
review: ReviewSegment = reviews[idx] review: ReviewSegment = reviews[idx]
severity = review.severity
pre_capture = config.record.get_review_pre_capture(severity)
post_capture = config.record.get_review_post_capture(severity)
# if the review starts in the future, stop checking reviews # if the review starts in the future, stop checking reviews
# and let this recording segment expire # and let this recording segment expire
if review.start_time > recording.end_time: if review.start_time - pre_capture > recording.end_time:
keep = False keep = False
break break
# if the review is in progress or ends after the recording starts, keep it # if the review is in progress or ends after the recording starts, keep it
# and stop looking at reviews # and stop looking at reviews
if review.end_time is None or review.end_time >= recording.start_time: if (
review.end_time is None
or review.end_time + post_capture >= recording.start_time
):
keep = True keep = True
mode = ( mode = (
config.record.alerts.retain.mode config.record.alerts.retain.mode
@ -149,7 +156,7 @@ class RecordingCleanup(threading.Thread):
# this review and check the next review for an overlap. # this review and check the next review for an overlap.
# since the review and recordings are sorted, we can skip review # since the review and recordings are sorted, we can skip review
# that end before the previous recording segment started on future segments # that end before the previous recording segment started on future segments
if review.end_time < recording.start_time: if review.end_time + post_capture < recording.start_time:
review_start = idx review_start = idx
# Delete recordings outside of the retention window or based on the retention mode # Delete recordings outside of the retention window or based on the retention mode