From 7b11ff1af6dc6e9b71a6ffd3d670f6ec433b46f5 Mon Sep 17 00:00:00 2001
From: Nicolas Mowen <nickmowen213@gmail.com>
Date: Sun, 25 Feb 2024 15:36:18 -0700
Subject: [PATCH] Fix reviewed filter (#10039)

---
 frigate/http.py                                 |  2 +-
 web/src/components/filter/ReviewFilterGroup.tsx |  8 ++++----
 web/src/pages/Events.tsx                        | 10 +++++-----
 web/src/types/review.ts                         |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/frigate/http.py b/frigate/http.py
index c496be82b..b2ff9fa79 100644
--- a/frigate/http.py
+++ b/frigate/http.py
@@ -2426,7 +2426,7 @@ def review():
         label_clause = reduce(operator.or_, label_clauses)
         clauses.append((label_clause))
 
-    if reviewed == 1:
+    if reviewed == 0:
         clauses.append((ReviewSegment.has_been_reviewed == False))
 
     if severity:
diff --git a/web/src/components/filter/ReviewFilterGroup.tsx b/web/src/components/filter/ReviewFilterGroup.tsx
index ef51da673..eb71daa22 100644
--- a/web/src/components/filter/ReviewFilterGroup.tsx
+++ b/web/src/components/filter/ReviewFilterGroup.tsx
@@ -90,7 +90,7 @@ export default function ReviewFilterGroup({
         updateLabelFilter={(newLabels) => {
           onUpdateFilter({ ...filter, labels: newLabels });
         }}
-        showReviewed={filter?.showReviewed || false}
+        showReviewed={filter?.showReviewed || 0}
         setShowReviewed={(reviewed) =>
           onUpdateFilter({ ...filter, showReviewed: reviewed })
         }
@@ -228,8 +228,8 @@ type GeneralFilterButtonProps = {
   allLabels: string[];
   selectedLabels: string[] | undefined;
   updateLabelFilter: (labels: string[] | undefined) => void;
-  showReviewed: boolean;
-  setShowReviewed: (reviewed: boolean) => void;
+  showReviewed?: 0 | 1;
+  setShowReviewed: (reviewed?: 0 | 1) => void;
 };
 function GeneralFilterButton({
   allLabels,
@@ -256,7 +256,7 @@ function GeneralFilterButton({
           <Button
             className="capitalize flex justify-between items-center cursor-pointer w-full"
             variant="secondary"
-            onClick={(_) => setShowReviewed(!showReviewed)}
+            onClick={(_) => setShowReviewed(showReviewed == 0 ? 1 : 0)}
           >
             {showReviewed ? (
               <LuCheck className="w-6 h-6" />
diff --git a/web/src/pages/Events.tsx b/web/src/pages/Events.tsx
index 1926e4755..f8a87aecb 100644
--- a/web/src/pages/Events.tsx
+++ b/web/src/pages/Events.tsx
@@ -22,9 +22,9 @@ export default function Events() {
     useApiFilter<ReviewFilter>();
 
   const onUpdateFilter = useCallback((newFilter: ReviewFilter) => {
-      setSize(1);
-      setReviewFilter(newFilter);
-  }, [])
+    setSize(1);
+    setReviewFilter(newFilter);
+  }, []);
 
   // review paging
 
@@ -45,7 +45,7 @@ export default function Events() {
         const pagedParams = {
           cameras: reviewSearchParams["cameras"],
           labels: reviewSearchParams["labels"],
-          reviewed: reviewSearchParams["showReviewed"] == true ? 1 : 0,
+          reviewed: reviewSearchParams["showReviewed"],
           before: lastDate,
           after: reviewSearchParams["after"] || timeRange.after,
           limit: API_LIMIT,
@@ -56,7 +56,7 @@ export default function Events() {
       const params = {
         cameras: reviewSearchParams["cameras"],
         labels: reviewSearchParams["labels"],
-        reviewed: reviewSearchParams["showReviewed"] == true ? 1 : 0,
+        reviewed: reviewSearchParams["showReviewed"],
         limit: API_LIMIT,
         before: reviewSearchParams["before"] || timeRange.before,
         after: reviewSearchParams["after"] || timeRange.after,
diff --git a/web/src/types/review.ts b/web/src/types/review.ts
index 287c89573..6d6126e85 100644
--- a/web/src/types/review.ts
+++ b/web/src/types/review.ts
@@ -25,5 +25,5 @@ export type ReviewFilter = {
   labels?: string[];
   before?: number;
   after?: number;
-  showReviewed?: boolean;
+  showReviewed?: 0 | 1;
 };