Small general filter bugfix (#14870)

This commit is contained in:
Josh Hawkins 2024-11-08 08:49:05 -06:00 committed by GitHub
parent ae30ac6e3c
commit 7bae9463b2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -214,7 +214,9 @@ export default function ReviewFilterGroup({
showAll={filter?.showAll == true} showAll={filter?.showAll == true}
allZones={filterValues.zones} allZones={filterValues.zones}
selectedZones={filter?.zones} selectedZones={filter?.zones}
onUpdateFilter={onUpdateFilter} onUpdateFilter={(general) => {
onUpdateFilter({ ...filter, ...general });
}}
/> />
)} )}
{isMobile && mobileSettingsFeatures.length > 0 && ( {isMobile && mobileSettingsFeatures.length > 0 && (
@ -293,7 +295,7 @@ type GeneralFilterButtonProps = {
allZones: string[]; allZones: string[];
selectedZones?: string[]; selectedZones?: string[];
filter?: GeneralFilter; filter?: GeneralFilter;
onUpdateFilter: (filter: ReviewFilter) => void; onUpdateFilter: (filter: GeneralFilter) => void;
}; };
function GeneralFilterButton({ function GeneralFilterButton({
@ -370,7 +372,11 @@ function GeneralFilterButton({
setOpen(false); setOpen(false);
}} }}
onReset={() => { onReset={() => {
const resetFilter: GeneralFilter = {}; const resetFilter: GeneralFilter = {
labels: undefined,
zones: undefined,
showAll: false,
};
setCurrentFilter(resetFilter); setCurrentFilter(resetFilter);
onUpdateFilter(resetFilter); onUpdateFilter(resetFilter);
}} }}