Mirrors/blakeblackshear.frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2025-01-31 00:18:55 +01:00
Code Issues Projects Releases Wiki Activity

reduce db queries for recording cleanup

Browse Source
This commit is contained in:
Blake Blackshear 2021-09-01 06:44:05 -05:00
parent 7d65c05994
commit 8cc834633e
1 changed files with 57 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

80
frigate/record.py
View File

@ -157,16 +157,16 @@ class RecordingCleanup(threading.Thread):
logger.debug("Start deleted cameras.") logger.debug("Start deleted cameras.")
# Handle deleted cameras # Handle deleted cameras
no_camera_recordings: Recordings = Recordings.select().where(
Recordings.camera.not_in(list(self.config.cameras.keys())),
)
for recording in no_camera_recordings:
expire_days = self.config.record.retain_days expire_days = self.config.record.retain_days
expire_before = ( expire_before = (
datetime.datetime.now() - datetime.timedelta(days=expire_days) datetime.datetime.now() - datetime.timedelta(days=expire_days)
).timestamp() ).timestamp()
if recording.end_time < expire_before: no_camera_recordings: Recordings = Recordings.select().where(
Recordings.camera.not_in(list(self.config.cameras.keys())),
Recordings.end_time < expire_before,
)
for recording in no_camera_recordings:
Path(recording.path).unlink(missing_ok=True) Path(recording.path).unlink(missing_ok=True)
Recordings.delete_by_id(recording.id) Recordings.delete_by_id(recording.id)
logger.debug("End deleted cameras.") logger.debug("End deleted cameras.")
@ -185,36 +185,21 @@ class RecordingCleanup(threading.Thread):
).timestamp() ).timestamp()
expire_date = min(min_end, expire_before) expire_date = min(min_end, expire_before)
# Get recordings to remove # Get recordings to check for expiration
recordings: Recordings = Recordings.select().where( recordings: Recordings = Recordings.select().where(
Recordings.camera == camera, Recordings.camera == camera,
Recordings.end_time < expire_date, Recordings.end_time < expire_date,
) )
for recording in recordings: # Get all the events to check against
# See if there are any associated events
events: Event = Event.select().where( events: Event = Event.select().where(
Event.camera == recording.camera, Event.camera == camera, Event.end_time < expire_date, Event.has_clip
(
Event.start_time.between(
recording.start_time, recording.end_time
) )
| Event.end_time.between(
recording.start_time, recording.end_time
)
| (
(recording.start_time > Event.start_time)
& (recording.end_time < Event.end_time)
)
),
)
keep = False
event_ids = set()
event: Event # mark has_clip false for all expired events
expired_event_ids = set()
for event in events: for event in events:
event_ids.add(event.id) # get the date that this event should expire
# Check event/label retention and keep the recording if within window
expire_days_event = ( expire_days_event = (
0 0
if not config.record.events.enabled if not config.record.events.enabled
@ -223,21 +208,46 @@ class RecordingCleanup(threading.Thread):
) )
) )
expire_before_event = ( expire_before_event = (
datetime.datetime.now() datetime.datetime.now() - datetime.timedelta(days=expire_days_event)
- datetime.timedelta(days=expire_days_event)
).timestamp() ).timestamp()
if recording.end_time >= expire_before_event: # if the event is expired
if event.start_time < expire_before_event:
event.has_clip = False
expired_event_ids.add(event.id)
if expired_event_ids:
# Update associated events
Event.update(has_clip=False).where(
Event.id.in_(list(expired_event_ids))
).execute()
# loop over recordings and see if they overlap with any non-expired events
for recording in recordings:
keep = False
for event in events:
if not event.has_clip:
continue
if (
( # event starts in this segment
event.start_time > recording.start_time
and event.start_time < recording.end_time
)
or ( # event ends in this segment
event.end_time > recording.start_time
and event.end_time < recording.end_time
)
or ( # event spans this segment
recording.start_time > event.start_time
and recording.end_time < event.end_time
)
):
keep = True keep = True
break
# Delete recordings outside of the retention window # Delete recordings outside of the retention window
if not keep: if not keep:
Path(recording.path).unlink(missing_ok=True) Path(recording.path).unlink(missing_ok=True)
Recordings.delete_by_id(recording.id) Recordings.delete_by_id(recording.id)
if event_ids:
# Update associated events
Event.update(has_clip=False).where(
Event.id.in_(list(event_ids))
).execute()
logger.debug(f"End camera: {camera}.") logger.debug(f"End camera: {camera}.")