Faster skeleton with refs (#10063)

* don't load metadata until image has loaded

* correct class name and remove lazy loading pkg

* try refs

* hook

* don't load metadata until image has loaded

* correct class name and remove lazy loading pkg

* try refs

* hook
This commit is contained in:
Josh Hawkins 2024-02-26 12:34:52 -06:00 committed by GitHub
parent 1dd904d89a
commit 93bd9ded88
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 28 additions and 2 deletions

View File

@ -19,6 +19,7 @@ import {
import { LuCheckSquare, LuFileUp, LuTrash } from "react-icons/lu";
import axios from "axios";
import { useFormattedTimestamp } from "@/hooks/use-date-utils";
import useImageLoaded from "@/hooks/use-image-loaded";
import { Skeleton } from "../ui/skeleton";
type PreviewPlayerProps = {
@ -50,7 +51,7 @@ export default function PreviewThumbnailPlayer({
const [hoverTimeout, setHoverTimeout] = useState<NodeJS.Timeout | null>();
const [playback, setPlayback] = useState(false);
const [progress, setProgress] = useState(0);
const [imgLoaded, setImgLoaded] = useState(false);
const [imgRef, imgLoaded, onImgLoad] = useImageLoaded();
const playingBack = useMemo(() => playback, [playback, autoPlayback]);
@ -126,6 +127,7 @@ export default function PreviewThumbnailPlayer({
)}
<div className={`${imgLoaded ? "visible" : "invisible"}`}>
<img
ref={imgRef}
className={`w-full h-full transition-opacity ${
playingBack ? "opacity-0" : "opacity-100"
}`}
@ -135,7 +137,7 @@ export default function PreviewThumbnailPlayer({
)}`}
loading="lazy"
onLoad={() => {
setImgLoaded(true);
onImgLoad();
}}
/>

View File

@ -0,0 +1,24 @@
import { useEffect, useRef, useState } from "react";
const useImageLoaded = (): [
React.RefObject<HTMLImageElement>,
boolean,
() => void,
] => {
const [loaded, setLoaded] = useState(false);
const ref = useRef<HTMLImageElement>(null);
const onLoad = () => {
setLoaded(true);
};
useEffect(() => {
if (ref.current && ref.current?.complete) {
onLoad();
}
});
return [ref, loaded, onLoad];
};
export default useImageLoaded;