FEAT: Ability to reorder & ability to hide Cameras in UI (#2981)

* Add options for reordering and hiding cameras selectively

* Add newline at end of camera file

* Make each camera for birdseye togglable as well

* Update names to be less ambiguous

* Update defaults

* Include sidebar change

* Remove birdseye toggle (will be added in separate PR)

* Remove birdseye toggle (will be added in separate PR)

* Remove birdseye toggle (will be added in separate PR)

* Update sidebar to only sort cameras once

* Simplify sorting logic
This commit is contained in:
Nicolas Mowen 2022-04-15 06:23:02 -06:00 committed by GitHub
parent 41f58c7692
commit a5016afdd4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 85 additions and 24 deletions

View File

@ -436,4 +436,12 @@ cameras:
quality: 70 quality: 70
# Optional: Restrict mqtt messages to objects that entered any of the listed zones (default: no required zones) # Optional: Restrict mqtt messages to objects that entered any of the listed zones (default: no required zones)
required_zones: [] required_zones: []
# Optional: Configuration for how camera is handled in the GUI.
ui:
# Optional: Adjust sort order of cameras in the UI. Larger numbers come later (default: shown below)
# By default the cameras are sorted alphabetically.
order: 0
# Optional: Whether or not to show the camera in the Frigate UI (default: shown below)
dashboard: True
``` ```

View File

@ -514,6 +514,11 @@ class CameraLiveConfig(FrigateBaseModel):
quality: int = Field(default=8, ge=1, le=31, title="Live camera view quality") quality: int = Field(default=8, ge=1, le=31, title="Live camera view quality")
class CameraUiConfig(FrigateBaseModel):
order: int = Field(default=0, title="Order of camera in UI.")
dashboard: bool = Field(default=True, title="Show this camera in Frigate dashboard UI.")
class CameraConfig(FrigateBaseModel): class CameraConfig(FrigateBaseModel):
name: Optional[str] = Field(title="Camera name.", regex="^[a-zA-Z0-9_-]+$") name: Optional[str] = Field(title="Camera name.", regex="^[a-zA-Z0-9_-]+$")
ffmpeg: CameraFfmpegConfig = Field(title="FFmpeg configuration for the camera.") ffmpeg: CameraFfmpegConfig = Field(title="FFmpeg configuration for the camera.")
@ -546,6 +551,9 @@ class CameraConfig(FrigateBaseModel):
detect: DetectConfig = Field( detect: DetectConfig = Field(
default_factory=DetectConfig, title="Object detection configuration." default_factory=DetectConfig, title="Object detection configuration."
) )
ui: CameraUiConfig = Field(
default_factory=CameraUiConfig, title="Camera UI Modifications."
)
birdseye: BirdseyeCameraConfig = Field( birdseye: BirdseyeCameraConfig = Field(
default_factory=BirdseyeCameraConfig, title="Birdseye camera configuration." default_factory=BirdseyeCameraConfig, title="Birdseye camera configuration."
) )

View File

@ -20,6 +20,7 @@ export const handlers = [
detect: { width: 1280, height: 720 }, detect: { width: 1280, height: 720 },
snapshots: {}, snapshots: {},
live: { height: 720 }, live: { height: 720 },
ui: { dashboard: true, order: 0 },
}, },
side: { side: {
name: 'side', name: 'side',
@ -28,6 +29,7 @@ export const handlers = [
detect: { width: 1280, height: 720 }, detect: { width: 1280, height: 720 },
snapshots: {}, snapshots: {},
live: { height: 720 }, live: { height: 720 },
ui: { dashboard: true, order: 1 },
}, },
}, },
}) })

View File

@ -3,15 +3,27 @@ import LinkedLogo from './components/LinkedLogo';
import { Match } from 'preact-router/match'; import { Match } from 'preact-router/match';
import { memo } from 'preact/compat'; import { memo } from 'preact/compat';
import { ENV } from './env'; import { ENV } from './env';
import { useMemo } from 'preact/hooks'
import useSWR from 'swr'; import useSWR from 'swr';
import NavigationDrawer, { Destination, Separator } from './components/NavigationDrawer'; import NavigationDrawer, { Destination, Separator } from './components/NavigationDrawer';
export default function Sidebar() { export default function Sidebar() {
const { data: config } = useSWR('config'); const { data: config } = useSWR('config');
const sortedCameras = useMemo(() => {
if (!config) {
return [];
}
return Object.entries(config.cameras)
.filter(([_, conf]) => conf.ui.dashboard)
.sort(([_, aConf], [__, bConf]) => aConf.ui.order - bConf.ui.order);
}, [config]);
if (!config) { if (!config) {
return null; return null;
} }
const { cameras, birdseye } = config; const { birdseye } = config;
return ( return (
<NavigationDrawer header={<Header />}> <NavigationDrawer header={<Header />}>
@ -19,31 +31,14 @@ export default function Sidebar() {
<Match path="/cameras/:camera/:other?"> <Match path="/cameras/:camera/:other?">
{({ matches }) => {({ matches }) =>
matches ? ( matches ? (
<Fragment> <CameraSection sortedCameras={sortedCameras} />
<Separator />
{Object.keys(cameras).map((camera) => (
<Destination key={camera} href={`/cameras/${camera}`} text={camera} />
))}
<Separator />
</Fragment>
) : null ) : null
} }
</Match> </Match>
<Match path="/recording/:camera/:date?/:hour?/:seconds?"> <Match path="/recording/:camera/:date?/:hour?/:seconds?">
{({ matches }) => {({ matches }) =>
matches ? ( matches ? (
<Fragment> <RecordingSection sortedCameras={sortedCameras} />
<Separator />
{Object.keys(cameras).map((camera) => (
<Destination
key={camera}
path={`/recording/${camera}/:date?/:hour?/:seconds?`}
href={`/recording/${camera}`}
text={camera}
/>
))}
<Separator />
</Fragment>
) : null ) : null
} }
</Match> </Match>
@ -64,10 +59,43 @@ export default function Sidebar() {
); );
} }
function CameraSection({ sortedCameras }) {
return (
<Fragment>
<Separator />
{sortedCameras.map(([camera]) => (
<Destination key={camera} href={`/cameras/${camera}`} text={camera} />
))}
<Separator />
</Fragment>
);
}
function RecordingSection({ sortedCameras }) {
return (
<Fragment>
<Separator />
{sortedCameras.map(([camera, _]) => {
return (
<Destination
key={camera}
path={`/recording/${camera}/:date?/:hour?/:seconds?`}
href={`/recording/${camera}`}
text={camera}
/>
);
})}
<Separator />
</Fragment>
);
}
const Header = memo(() => { const Header = memo(() => {
return ( return (
<div className="text-gray-500"> <div className="text-gray-500">
<LinkedLogo /> <LinkedLogo />
</div> </div>
); );
}); });

View File

@ -1,4 +1,4 @@
import { h } from 'preact'; import { h, Fragment } from 'preact';
import ActivityIndicator from '../components/ActivityIndicator'; import ActivityIndicator from '../components/ActivityIndicator';
import Card from '../components/Card'; import Card from '../components/Card';
import CameraImage from '../components/CameraImage'; import CameraImage from '../components/CameraImage';
@ -16,10 +16,25 @@ export default function Cameras() {
<ActivityIndicator /> <ActivityIndicator />
) : ( ) : (
<div className="grid grid-cols-1 3xl:grid-cols-3 md:grid-cols-2 gap-4 p-2 px-4"> <div className="grid grid-cols-1 3xl:grid-cols-3 md:grid-cols-2 gap-4 p-2 px-4">
{Object.entries(config.cameras).map(([camera, conf]) => ( <SortedCameras unsortedCameras={config.cameras} />
</div>
);
}
function SortedCameras({ unsortedCameras }) {
const sortedCameras = useMemo(() =>
Object.entries(unsortedCameras)
.filter(([_, conf]) => conf.ui.dashboard)
.sort(([_, aConf], [__, bConf]) => aConf.ui.order - bConf.ui.order),
[unsortedCameras]);
return (
<Fragment>
{sortedCameras.map(([camera, conf]) => (
<Camera key={camera} name={camera} conf={conf} /> <Camera key={camera} name={camera} conf={conf} />
))} ))}
</div> </Fragment>
); );
} }