* Keep as optional prop

* put zones inside of scrollable container
This commit is contained in:
Josh Hawkins 2024-06-11 10:05:50 -05:00 committed by GitHub
parent bb359f67a4
commit a8e901b63c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -643,7 +643,7 @@ type GeneralFilterContentProps = {
updateLabelFilter: (labels: string[] | undefined) => void;
setCurrentLabels: (labels: string[] | undefined) => void;
updateZoneFilter?: (zones: string[] | undefined) => void;
setCurrentZones: (zones: string[] | undefined) => void;
setCurrentZones?: (zones: string[] | undefined) => void;
onClose: () => void;
};
export function GeneralFilterContent({
@ -726,7 +726,7 @@ export function GeneralFilterContent({
/>
))}
</div>
</div>
{allZones && setCurrentZones && (
<>
<DropdownMenuSeparator />
@ -755,12 +755,16 @@ export function GeneralFilterContent({
isChecked={currentZones?.includes(item) ?? false}
onCheckedChange={(isChecked) => {
if (isChecked) {
const updatedZones = currentZones ? [...currentZones] : [];
const updatedZones = currentZones
? [...currentZones]
: [];
updatedZones.push(item);
setCurrentZones(updatedZones);
} else {
const updatedZones = currentZones ? [...currentZones] : [];
const updatedZones = currentZones
? [...currentZones]
: [];
// can not deselect the last item
if (updatedZones.length > 1) {
@ -774,6 +778,7 @@ export function GeneralFilterContent({
</div>
</>
)}
</div>
<DropdownMenuSeparator />
<div className="flex items-center justify-evenly p-2">
<Button
@ -795,7 +800,7 @@ export function GeneralFilterContent({
<Button
onClick={() => {
setCurrentLabels(undefined);
setCurrentZones(undefined);
setCurrentZones?.(undefined);
updateLabelFilter(undefined);
}}
>