From a9f139e062a175df312f3ba644bdb2059f8810cf Mon Sep 17 00:00:00 2001
From: Josh Hawkins <32435876+hawkeye217@users.noreply.github.com>
Date: Tue, 29 Apr 2025 17:03:44 -0500
Subject: [PATCH] Fixes (#17961)

* Fix i18n page titles

* fix frontend crash in npu stats

* return empty object for gpu_usages if null

* fix gpu info i18n keys
---
 web/public/locales/en/views/settings.json            | 5 +++--
 web/src/components/overlay/GPUInfoDialog.tsx         | 6 +++---
 web/src/views/settings/CameraSettingsView.tsx        | 4 ++--
 web/src/views/settings/NotificationsSettingsView.tsx | 4 ++++
 web/src/views/system/GeneralMetrics.tsx              | 8 ++++----
 5 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/web/public/locales/en/views/settings.json b/web/public/locales/en/views/settings.json
index 37051dfcb..4d96447fb 100644
--- a/web/public/locales/en/views/settings.json
+++ b/web/public/locales/en/views/settings.json
@@ -6,9 +6,10 @@
     "classification": "Classification Settings - Frigate",
     "masksAndZones": "Mask and Zone Editor - Frigate",
     "motionTuner": "Motion Tuner - Frigate",
-    "object": "Object Settings - Frigate",
+    "object": "Debug - Frigate",
     "general": "General Settings - Frigate",
-    "frigatePlus": "Frigate+ Settings - Frigate"
+    "frigatePlus": "Frigate+ Settings - Frigate",
+    "notifications": "Notification Settings - Frigate"
   },
   "menu": {
     "ui": "UI",
diff --git a/web/src/components/overlay/GPUInfoDialog.tsx b/web/src/components/overlay/GPUInfoDialog.tsx
index d4752aa2f..549a9f9db 100644
--- a/web/src/components/overlay/GPUInfoDialog.tsx
+++ b/web/src/components/overlay/GPUInfoDialog.tsx
@@ -108,7 +108,7 @@ export default function GPUInfoDialog({
               <br />
               <div>
                 {t("general.hardwareInfo.gpuInfo.nvidiaSMIOutput.driver", {
-                  name: nvinfo["0"].driver,
+                  driver: nvinfo["0"].driver,
                 })}
               </div>
               <br />
@@ -116,14 +116,14 @@ export default function GPUInfoDialog({
                 {t(
                   "general.hardwareInfo.gpuInfo.nvidiaSMIOutput.cudaComputerCapability",
                   {
-                    name: nvinfo["0"].cuda_compute,
+                    cuda_compute: nvinfo["0"].cuda_compute,
                   },
                 )}
               </div>
               <br />
               <div>
                 {t("general.hardwareInfo.gpuInfo.nvidiaSMIOutput.vbios", {
-                  name: nvinfo["0"].vbios,
+                  vbios: nvinfo["0"].vbios,
                 })}
               </div>
             </div>
diff --git a/web/src/views/settings/CameraSettingsView.tsx b/web/src/views/settings/CameraSettingsView.tsx
index ce03b5b31..16506b008 100644
--- a/web/src/views/settings/CameraSettingsView.tsx
+++ b/web/src/views/settings/CameraSettingsView.tsx
@@ -251,8 +251,8 @@ export default function CameraSettingsView({
   }
 
   useEffect(() => {
-    document.title = "Camera Settings - Frigate";
-  }, []);
+    document.title = t("documentTitle.camera");
+  }, [t]);
 
   if (!cameraConfig && !selectedCamera) {
     return <ActivityIndicator />;
diff --git a/web/src/views/settings/NotificationsSettingsView.tsx b/web/src/views/settings/NotificationsSettingsView.tsx
index af72060d4..20f9180a4 100644
--- a/web/src/views/settings/NotificationsSettingsView.tsx
+++ b/web/src/views/settings/NotificationsSettingsView.tsx
@@ -299,6 +299,10 @@ export default function NotificationView({
     saveToConfig(values as NotificationSettingsValueType);
   }
 
+  useEffect(() => {
+    document.title = t("documentTitle.notifications");
+  }, [t]);
+
   if (!("Notification" in window) || !window.isSecureContext) {
     return (
       <div className="scrollbar-container order-last mb-10 mt-2 flex h-full w-full flex-col overflow-y-auto rounded-lg border-[1px] border-secondary-foreground bg-background_alt p-2 md:order-none md:mb-0 md:mr-2 md:mt-0">
diff --git a/web/src/views/system/GeneralMetrics.tsx b/web/src/views/system/GeneralMetrics.tsx
index 35a5f8f80..a6be0a418 100644
--- a/web/src/views/system/GeneralMetrics.tsx
+++ b/web/src/views/system/GeneralMetrics.tsx
@@ -240,7 +240,7 @@ export default function GeneralMetrics({
         return;
       }
 
-      Object.entries(stats.gpu_usages || []).forEach(([key, stats]) => {
+      Object.entries(stats.gpu_usages || {}).forEach(([key, stats]) => {
         if (!(key in series)) {
           series[key] = { name: key, data: [] };
         }
@@ -316,7 +316,7 @@ export default function GeneralMetrics({
         return;
       }
 
-      Object.entries(stats.gpu_usages || []).forEach(([key, stats]) => {
+      Object.entries(stats.gpu_usages || {}).forEach(([key, stats]) => {
         if (!(key in series)) {
           series[key] = { name: key, data: [] };
         }
@@ -350,7 +350,7 @@ export default function GeneralMetrics({
         return;
       }
 
-      Object.entries(stats.gpu_usages || []).forEach(([key, stats]) => {
+      Object.entries(stats.gpu_usages || {}).forEach(([key, stats]) => {
         if (!(key in series)) {
           series[key] = { name: key, data: [] };
         }
@@ -386,7 +386,7 @@ export default function GeneralMetrics({
         return;
       }
 
-      Object.entries(stats.npu_usages || []).forEach(([key, stats]) => {
+      Object.entries(stats.npu_usages || {}).forEach(([key, stats]) => {
         if (!(key in series)) {
           series[key] = { name: key, data: [] };
         }