From ab59fdf570185c2fcbda6c5c88d6aa05cde7a2c5 Mon Sep 17 00:00:00 2001 From: Brian H Date: Mon, 2 Feb 2026 19:58:13 +1100 Subject: [PATCH] fix: clean up duplicate SoC list and fix RKNN converter for rk3588s - Remove unused supported_socs variable in rknn.py that duplicated the SUPPORTED_RK_SOCS constant from frigate.const - Add rk3588s to rk3588 mapping in rknn_converter.py to ensure custom ONNX model conversion works on RK3588S devices Co-Authored-By: Claude Opus 4.5 --- frigate/util/rknn_converter.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/frigate/util/rknn_converter.py b/frigate/util/rknn_converter.py index f7ebbf5e6..fdc7e51dd 100644 --- a/frigate/util/rknn_converter.py +++ b/frigate/util/rknn_converter.py @@ -189,13 +189,16 @@ def convert_onnx_to_rknn( logger.debug("Could not determine SoC type") return False + # Map rk3588s to rk3588 for RKNN toolkit compatibility + target_soc = "rk3588" if soc == "rk3588s" else soc + # Get model config for the specified type if model_type not in MODEL_TYPE_CONFIGS: logger.debug(f"Unsupported model type: {model_type}") return False config = MODEL_TYPE_CONFIGS[model_type].copy() - config["target_platform"] = soc + config["target_platform"] = target_soc # RKNN toolkit requires .onnx extension, create temporary copy if needed temp_onnx_path = None