Explore tweaks (#13744)

* Fix loading indicator and explore view when entering a search term

* don't hide iOS video mute button

* use searchTerm instead of search for trigger
This commit is contained in:
Josh Hawkins 2024-09-14 15:08:46 -05:00 committed by GitHub
parent d5acd11164
commit c17524bc3c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 17 additions and 10 deletions

View File

@ -350,7 +350,7 @@ function ObjectDetailsTab({
<div className="flex flex-col gap-1.5"> <div className="flex flex-col gap-1.5">
<div className="text-sm text-primary/40">Description</div> <div className="text-sm text-primary/40">Description</div>
<Textarea <Textarea
className="md:h-64" className="h-64"
placeholder="Description of the tracked object" placeholder="Description of the tracked object"
value={desc} value={desc}
onChange={(e) => setDesc(e.target.value)} onChange={(e) => setDesc(e.target.value)}
@ -447,8 +447,13 @@ function VideoTab({ search, config }: VideoTabProps) {
/> />
</div> </div>
</div> </div>
{!isLoading && ( {!isLoading && reviewItem && (
<div className="absolute right-2 top-2 flex items-center"> <div
className={cn(
"absolute top-2 flex items-center",
isIOS ? "right-8" : "right-2",
)}
>
<Tooltip> <Tooltip>
<TooltipTrigger> <TooltipTrigger>
<Chip <Chip

View File

@ -243,8 +243,8 @@ export default function SearchView({
{uniqueResults?.length == 0 && {uniqueResults?.length == 0 &&
isLoading && isLoading &&
searchFilter && (searchTerm ||
Object.keys(searchFilter).length !== 0 && ( (searchFilter && Object.keys(searchFilter).length !== 0)) && (
<ActivityIndicator className="absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2" /> <ActivityIndicator className="absolute left-1/2 top-1/2 -translate-x-1/2 -translate-y-1/2" />
)} )}
@ -319,11 +319,13 @@ export default function SearchView({
</> </>
)} )}
</div> </div>
{searchFilter && Object.keys(searchFilter).length === 0 && ( {searchFilter &&
<div className="scrollbar-container flex size-full flex-col overflow-y-auto"> Object.keys(searchFilter).length === 0 &&
<ExploreView onSelectSearch={onSelectSearch} /> !searchTerm && (
</div> <div className="scrollbar-container flex size-full flex-col overflow-y-auto">
)} <ExploreView onSelectSearch={onSelectSearch} />
</div>
)}
</div> </div>
); );
} }