Add dynamic configuration for more fields (#22295)

* face recognition dynamic config * lpr dynamic config * safe changes for birdseye dynamic config * bird classification dynamic config * always assign new config to stats emitter to make telemetry fields dynamic * add wildcard support for camera config updates in config_set * update restart required fields for global sections * add test * fix rebase issue * collapsible settings sidebar use the preexisting control available with shadcn's sidebar (cmd/ctrl-B) to give users more space to set masks/zones on smaller screens * dynamic ffmpeg * ensure previews dir exists when ffmpeg processes restart, there's a brief window where the preview frame generation pipeline is torn down and restarted. before these changes, ffmpeg only restarted on crash/stall recovery or full Frigate restart. Now that ffmpeg restarts happen on-demand via config changes, there's a higher chance a frontend request hits the preview_mp4 or preview_gif endpoints during that brief restart window when the directory might not exist yet. The existing os.listdir() call would throw FileNotFoundError without a directory existence check. this fix just checks if the directory exists and returns 404 if not, exactly how preview_thumbnail already handles the same scenario a few lines below * global ffmpeg section * clean up * tweak * fix test
2026-04-19 23:08:08 +02:00 · 2026-03-06 14:45:39 -06:00
parent c9bd907721
commit c2e667c0dd
29 changed files with 489 additions and 146 deletions
--- a/web/src/components/config-form/section-configs/audio.ts
+++ b/web/src/components/config-form/section-configs/audio.ts
@@ -25,14 +25,7 @@ const audio: SectionConfigOverrides = {
    },
  },
  global: {
-    restartRequired: [
-      "enabled",
-      "listen",
-      "filters",
-      "min_volume",
-      "max_not_heard",
-      "num_threads",
-    ],
+    restartRequired: ["num_threads"],
  },
  camera: {
    restartRequired: ["num_threads"],
--- a/web/src/components/config-form/section-configs/birdseye.ts
+++ b/web/src/components/config-form/section-configs/birdseye.ts
@@ -28,10 +28,7 @@ const birdseye: SectionConfigOverrides = {
      "width",
      "height",
      "quality",
-      "mode",
      "layout.scaling_factor",
-      "inactivity_threshold",
-      "layout.max_cameras",
      "idle_heartbeat_fps",
    ],
    uiSchema: {
--- a/web/src/components/config-form/section-configs/classification.ts
+++ b/web/src/components/config-form/section-configs/classification.ts
@@ -3,7 +3,7 @@ import type { SectionConfigOverrides } from "./types";
 const classification: SectionConfigOverrides = {
  base: {
    sectionDocs: "/configuration/custom_classification/object_classification",
-    restartRequired: ["bird.enabled", "bird.threshold"],
+    restartRequired: ["bird.enabled"],
    hiddenFields: ["custom"],
    advancedFields: [],
  },
--- a/web/src/components/config-form/section-configs/detect.ts
+++ b/web/src/components/config-form/section-configs/detect.ts
@@ -30,16 +30,7 @@ const detect: SectionConfigOverrides = {
    ],
  },
  global: {
-    restartRequired: [
-      "enabled",
-      "width",
-      "height",
-      "fps",
-      "min_initialized",
-      "max_disappeared",
-      "annotation_offset",
-      "stationary",
-    ],
+    restartRequired: ["width", "height", "min_initialized", "max_disappeared"],
  },
  camera: {
    restartRequired: ["width", "height", "min_initialized", "max_disappeared"],
--- a/web/src/components/config-form/section-configs/face_recognition.ts
+++ b/web/src/components/config-form/section-configs/face_recognition.ts
@@ -32,18 +32,7 @@ const faceRecognition: SectionConfigOverrides = {
      "blur_confidence_filter",
      "device",
    ],
-    restartRequired: [
-      "enabled",
-      "model_size",
-      "unknown_score",
-      "detection_threshold",
-      "recognition_threshold",
-      "min_area",
-      "min_faces",
-      "save_attempts",
-      "blur_confidence_filter",
-      "device",
-    ],
+    restartRequired: ["enabled", "model_size", "device"],
  },
 };

--- a/web/src/components/config-form/section-configs/ffmpeg.ts
+++ b/web/src/components/config-form/section-configs/ffmpeg.ts
@@ -116,16 +116,7 @@ const ffmpeg: SectionConfigOverrides = {
    },
  },
  global: {
-    restartRequired: [
-      "path",
-      "global_args",
-      "hwaccel_args",
-      "input_args",
-      "output_args",
-      "retry_interval",
-      "apple_compatibility",
-      "gpu",
-    ],
+    restartRequired: [],
    fieldOrder: [
      "hwaccel_args",
      "path",
@@ -162,17 +153,7 @@ const ffmpeg: SectionConfigOverrides = {
    fieldGroups: {
      cameraFfmpeg: ["input_args", "hwaccel_args", "output_args"],
    },
-    restartRequired: [
-      "inputs",
-      "path",
-      "global_args",
-      "hwaccel_args",
-      "input_args",
-      "output_args",
-      "retry_interval",
-      "apple_compatibility",
-      "gpu",
-    ],
+    restartRequired: [],
  },
 };

--- a/web/src/components/config-form/section-configs/lpr.ts
+++ b/web/src/components/config-form/section-configs/lpr.ts
@@ -40,21 +40,7 @@ const lpr: SectionConfigOverrides = {
      "device",
      "replace_rules",
    ],
-    restartRequired: [
-      "enabled",
-      "model_size",
-      "detection_threshold",
-      "min_area",
-      "recognition_threshold",
-      "min_plate_length",
-      "format",
-      "match_distance",
-      "known_plates",
-      "enhancement",
-      "debug_save_plates",
-      "device",
-      "replace_rules",
-    ],
+    restartRequired: ["model_size", "enhancement", "device"],
    uiSchema: {
      format: {
        "ui:options": { size: "md" },
--- a/web/src/components/config-form/section-configs/motion.ts
+++ b/web/src/components/config-form/section-configs/motion.ts
@@ -31,18 +31,7 @@ const motion: SectionConfigOverrides = {
    ],
  },
  global: {
-    restartRequired: [
-      "enabled",
-      "threshold",
-      "lightning_threshold",
-      "skip_motion_threshold",
-      "improve_contrast",
-      "contour_area",
-      "delta_alpha",
-      "frame_alpha",
-      "frame_height",
-      "mqtt_off_delay",
-    ],
+    restartRequired: ["frame_height"],
  },
  camera: {
    restartRequired: ["frame_height"],
--- a/web/src/components/config-form/section-configs/objects.ts
+++ b/web/src/components/config-form/section-configs/objects.ts
@@ -83,7 +83,7 @@ const objects: SectionConfigOverrides = {
    },
  },
  global: {
-    restartRequired: ["track", "alert", "detect", "filters", "genai"],
+    restartRequired: [],
    hiddenFields: [
      "enabled_in_config",
      "mask",
--- a/web/src/components/config-form/section-configs/record.ts
+++ b/web/src/components/config-form/section-configs/record.ts
@@ -29,16 +29,7 @@ const record: SectionConfigOverrides = {
    },
  },
  global: {
-    restartRequired: [
-      "enabled",
-      "expire_interval",
-      "continuous",
-      "motion",
-      "alerts",
-      "detections",
-      "preview",
-      "export",
-    ],
+    restartRequired: [],
  },
  camera: {
    restartRequired: [],
--- a/web/src/components/config-form/section-configs/review.ts
+++ b/web/src/components/config-form/section-configs/review.ts
@@ -44,7 +44,7 @@ const review: SectionConfigOverrides = {
    },
  },
  global: {
-    restartRequired: ["alerts", "detections", "genai"],
+    restartRequired: [],
  },
  camera: {
    restartRequired: [],
--- a/web/src/components/config-form/section-configs/snapshots.ts
+++ b/web/src/components/config-form/section-configs/snapshots.ts
@@ -27,14 +27,7 @@ const snapshots: SectionConfigOverrides = {
    },
  },
  global: {
-    restartRequired: [
-      "enabled",
-      "bounding_box",
-      "crop",
-      "quality",
-      "timestamp",
-      "retain",
-    ],
+    restartRequired: [],
    hiddenFields: ["enabled_in_config", "required_zones"],
  },
  camera: {
--- a/web/src/components/config-form/section-configs/telemetry.ts
+++ b/web/src/components/config-form/section-configs/telemetry.ts
@@ -3,14 +3,7 @@ import type { SectionConfigOverrides } from "./types";
 const telemetry: SectionConfigOverrides = {
  base: {
    sectionDocs: "/configuration/reference",
-    restartRequired: [
-      "network_interfaces",
-      "stats.amd_gpu_stats",
-      "stats.intel_gpu_stats",
-      "stats.intel_gpu_device",
-      "stats.network_bandwidth",
-      "version_check",
-    ],
+    restartRequired: ["version_check"],
    fieldOrder: ["network_interfaces", "stats", "version_check"],
    advancedFields: [],
  },
--- a/web/src/components/config-form/sections/BaseSection.tsx
+++ b/web/src/components/config-form/sections/BaseSection.tsx
@@ -56,6 +56,7 @@ import ActivityIndicator from "@/components/indicators/activity-indicator";
 import { StatusBarMessagesContext } from "@/context/statusbar-provider";
 import {
  cameraUpdateTopicMap,
+  globalCameraDefaultSections,
  buildOverrides,
  buildConfigDataForPath,
  sanitizeSectionData as sharedSanitizeSectionData,
@@ -234,7 +235,10 @@ export function ConfigSection({
      ? cameraUpdateTopicMap[sectionPath]
        ? `config/cameras/${cameraName}/${cameraUpdateTopicMap[sectionPath]}`
        : undefined
-      : `config/${sectionPath}`;
+      : globalCameraDefaultSections.has(sectionPath) &&
+          cameraUpdateTopicMap[sectionPath]
+        ? `config/cameras/*/${cameraUpdateTopicMap[sectionPath]}`
+        : `config/${sectionPath}`;
  // Default: show title for camera level (since it might be collapsible), hide for global
  const shouldShowTitle = showTitle ?? effectiveLevel === "camera";

@@ -827,7 +831,7 @@ export function ConfigSection({

      <div
        className={cn(
-          "w-full border-t border-secondary bg-background pb-5 pt-0",
+          "w-full border-t border-secondary bg-background pt-0",
          !noStickyButtons && "sticky bottom-0 z-50",
        )}
      >
--- a/web/src/pages/Settings.tsx
+++ b/web/src/pages/Settings.tsx
@@ -479,14 +479,7 @@ const CAMERA_SELECT_BUTTON_PAGES = [
  "regionGrid",
 ];

-const ALLOWED_VIEWS_FOR_VIEWER = ["ui", "debug", "notifications"];
-
-const LARGE_BOTTOM_MARGIN_PAGES = [
-  "masksAndZones",
-  "motionTuner",
-  "mediaSync",
-  "regionGrid",
-];
+const ALLOWED_VIEWS_FOR_VIEWER = ["profileSettings", "notifications"];

 // keys for camera sections
 const CAMERA_SECTION_MAPPING: Record<string, SettingsType> = {
@@ -1362,9 +1355,9 @@ export default function Settings() {
          )}
        </div>
      </div>
-      <SidebarProvider>
-        <Sidebar variant="inset" className="relative mb-8 pl-0 pt-0">
-          <SidebarContent className="scrollbar-container mb-24 overflow-y-auto border-r-[1px] border-secondary bg-background py-2">
+      <SidebarProvider className="relative h-full min-h-0 flex-1">
+        <Sidebar variant="inset" className="absolute h-full pl-0 pt-0">
+          <SidebarContent className="scrollbar-container overflow-y-auto border-r-[1px] border-secondary bg-background py-2">
            <SidebarMenu>
              {settingsGroups.map((group) => {
                const filteredItems = group.items.filter((item) =>
@@ -1452,8 +1445,7 @@ export default function Settings() {
        <SidebarInset>
          <div
            className={cn(
-              "scrollbar-container mb-16 flex-1 overflow-y-auto p-2 pr-0",
-              LARGE_BOTTOM_MARGIN_PAGES.includes(pageToggle) && "mb-24",
+              "scrollbar-container flex-1 overflow-y-auto pl-2 pr-0 pt-2",
            )}
          >
            {(() => {
--- a/web/src/utils/configUtil.ts
+++ b/web/src/utils/configUtil.ts
@@ -54,6 +54,20 @@ export const cameraUpdateTopicMap: Record<string, string> = {
  ui: "ui",
 };

+// Sections where global config serves as the default for per-camera config.
+// Global updates to these sections are fanned out to all cameras via wildcard.
+export const globalCameraDefaultSections = new Set([
+  "detect",
+  "objects",
+  "motion",
+  "record",
+  "snapshots",
+  "review",
+  "audio",
+  "notifications",
+  "ffmpeg",
+]);
+
 // ---------------------------------------------------------------------------
 // buildOverrides — pure recursive diff of current vs stored config & defaults
 // ---------------------------------------------------------------------------
@@ -476,6 +490,9 @@ export function prepareSectionSavePayload(opts: {
  if (level === "camera" && cameraName) {
    const topic = cameraUpdateTopicMap[sectionPath];
    updateTopic = topic ? `config/cameras/${cameraName}/${topic}` : undefined;
+  } else if (globalCameraDefaultSections.has(sectionPath)) {
+    const topic = cameraUpdateTopicMap[sectionPath];
+    updateTopic = topic ? `config/cameras/*/${topic}` : `config/${sectionPath}`;
  } else {
    updateTopic = `config/${sectionPath}`;
  }
--- a/web/src/views/settings/UiSettingsView.tsx
+++ b/web/src/views/settings/UiSettingsView.tsx
@@ -210,7 +210,7 @@ export default function UiSettingsView() {
  ];

  return (
-    <div className="flex size-full flex-col md:pb-8">
+    <div className="flex size-full flex-col">
      <Toaster position="top-center" closeButton={true} />
      <Heading as="h4" className="mb-3">
        {t("general.title")}