Mirrors/blakeblackshear.frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2026-03-07 02:18:07 +01:00
Code Issues Projects Releases Wiki Activity

Fixes (#18833)

Browse Source 
* Don't allow editing of sub label until object lifecycle has ended

* Update sub labels in ended review segments

When manually editing a sub label for a tracked object from the UI, any review segments containing that tracked object did not have their sub_labels and objects values altered

* simplify

* Additional onvif debug logs in get_camera_status

* Ensure that best object is only set when the snapshot is actually updated.

* Don't hide downlaod button when there is no review item

---------

Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
This commit is contained in:
Josh Hawkins
2025-06-23 18:40:21 -05:00
committed by GitHub
parent 8a9ebe9292
commit cc368dd20f
4 changed files with 114 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
web/src/components/overlay/detail/SearchDetailDialog.tsx
View File

@@ -721,7 +721,7 @@ function ObjectDetailsTab({
ns: "objects",
})}
{search.sub_label && ` (${search.sub_label})`}
{isAdmin && (
{isAdmin && search.end_time && (
<Tooltip>
<TooltipTrigger asChild>
<span>
@@ -1242,13 +1242,13 @@ export function VideoTab({ search }: VideoTabProps) {
<>
<span tabIndex={0} className="sr-only" />
<GenericVideoPlayer source={source}>
{reviewItem && (
<div
className={cn(
"absolute top-2 z-10 flex items-center gap-2",
isIOS ? "right-8" : "right-2",
)}
>
<div
className={cn(
"absolute top-2 z-10 flex items-center gap-2",
isIOS ? "right-8" : "right-2",
)}
>
{reviewItem && (
<Tooltip>
<TooltipTrigger>
<Chip
@@ -1271,25 +1271,25 @@ export function VideoTab({ search }: VideoTabProps) {
</TooltipContent>
</TooltipPortal>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<a
download
href={`${baseUrl}api/${search.camera}/${clipTimeRange}/clip.mp4`}
>
<Chip className="cursor-pointer rounded-md bg-gray-500 bg-gradient-to-br from-gray-400 to-gray-500">
<FaDownload className="size-4 text-white" />
</Chip>
</a>
</TooltipTrigger>
<TooltipPortal>
<TooltipContent>
{t("button.download", { ns: "common" })}
</TooltipContent>
</TooltipPortal>
</Tooltip>
</div>
)}
)}
<Tooltip>
<TooltipTrigger asChild>
<a
download
href={`${baseUrl}api/${search.camera}/${clipTimeRange}/clip.mp4`}
>
<Chip className="cursor-pointer rounded-md bg-gray-500 bg-gradient-to-br from-gray-400 to-gray-500">
<FaDownload className="size-4 text-white" />
</Chip>
</a>
</TooltipTrigger>
<TooltipPortal>
<TooltipContent>
{t("button.download", { ns: "common" })}
</TooltipContent>
</TooltipPortal>
</Tooltip>
</div>
</GenericVideoPlayer>
</>
);